From nobody Wed Feb 21 13:44:23 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TfyDl5SNxz5CCZD; Wed, 21 Feb 2024 13:44:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TfyDl3HvMz4dmk; Wed, 21 Feb 2024 13:44:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708523063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/c4vY/MwaQSOm/b+g/a0CgeetAxQV6GNPVyhSE22UIo=; b=MjmQxr5Rr2TCZAR/SeXqHz4JR67Auvzdv4kStZJ+d077Eq0r8dSwHKNUwKr+lcRGkdKABQ e1r1t7KaRuj0Vt5bdCtkWeQgd/5Bz2+xoiRacriJkszJBwoOhVfypEFG07QR28tCEyK6J5 UJCJfT7XBaxzChj4VaOPBiakpjYPCvyyG1UVGoKOIAAaA5JQcVyp0k+D+yljK8E2nurXlW IyPjb78YVLr2jHgoZXxWF3J6svlgxiL31bvMRWByC211jm7ebyP0JDVz9A8v/4RZl2/U4G 8kzOLd5uL57amnwy2HOfR1tZdZI3T/h5HRrEsEFLn7ca+SDDPLQVxNt+QHLtlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708523063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/c4vY/MwaQSOm/b+g/a0CgeetAxQV6GNPVyhSE22UIo=; b=ZK9SxmPsQ5cyvLf6hDU/N18nUEIvhjSbubG0dahFYwIoa5VRHJqpzUi4C0SBxTlPOrPfcX C/DzWjidaK1VPLwy4DZZAVAKzMDapmREfOP2e3Z3mipBdn/LV9AG4/DfMz133UsjbHJato NX2EXXETQGWCmlPU1vnZ7wQVKOB1xaIhU0rdup3TkMbkf/ZTVRI0RQeh2IwkQJu0UtMnAc uZ0x9AAIl5HUwqsfCCmKHOLVKZ9cipr79+Omk2FRaVXV0UpbeM6Re5rgVMa73D1Are/l9N d4/aQcgALAjH7HNBSEZiTvHeqhovRBFBkao44h+vnNdpe6pIDalWgZJBNl1HBg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708523063; a=rsa-sha256; cv=none; b=ENMOTnCt7LMt4gAVgqwhisOt6EZgcE16EQR9g8Vsp7UXvaQx3O3wa/ghZwlcTIpobyDQlR OVwYBKvX1WTTscKr5PpvZ+hF1xcpNphsVSWcHrXKwwwr9mSYmyJHh3AZQEZSQz1A8beIkJ 2WSu0/+vXqX+u6eeJOCzCXKjDBr2OLugNl26wEFxTyyF0bHSUfeLYeYCnZxOJhADfIu1eS FDa2xuvra2i3iitfiVJv3Onz6TQ7HUTj0bL2DgZ7kCWe8i9kPmrhbIC2j0mVR+XsEOj57U 9VGwI3Xg4TMjQxvaB7AOesw1M6ZY4rpYNoYHtUPiC1XPYw6lOYcRC8m2BeMMjw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TfyDl2NfJz14hh; Wed, 21 Feb 2024 13:44:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 41LDiNvu048896; Wed, 21 Feb 2024 13:44:23 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 41LDiNH4048893; Wed, 21 Feb 2024 13:44:23 GMT (envelope-from git) Date: Wed, 21 Feb 2024 13:44:23 GMT Message-Id: <202402211344.41LDiNH4048893@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Cy Schubert Subject: git: 6b421e431a2d - stable/13 - heimdal: Fix NULL deref List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 6b421e431a2de6eb9e8bd670efffe76e6617d520 Auto-Submitted: auto-generated The branch stable/13 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=6b421e431a2de6eb9e8bd670efffe76e6617d520 commit 6b421e431a2de6eb9e8bd670efffe76e6617d520 Author: Cy Schubert AuthorDate: 2024-02-15 15:41:07 +0000 Commit: Cy Schubert CommitDate: 2024-02-21 13:44:09 +0000 heimdal: Fix NULL deref A flawed logical condition allows a malicious actor to remotely trigger a NULL pointer dereference using a crafted negTokenInit token. Upstream notes: Reported to Heimdal by Michał Kępień . From the report: Acknowledgement --------------- This flaw was found while working on addressing ZDI-CAN-12302: ISC BIND TKEY Query Heap-based Buffer Overflow Remote Code Execution Vulnerability, which was reported to ISC by Trend Micro's Zero Day Security: CVE-2022-3116 Obtained from: upstream 7a19658c1 (cherry picked from commit fc773115fa2dbb6c01377f2ed47dabf79a4e361a) --- crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c b/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c index b60dc19ad8e3..48542f06fcbe 100644 --- a/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c +++ b/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c @@ -605,7 +605,7 @@ acceptor_start * If opportunistic token failed, lets try the other mechs. */ - if (!first_ok && ni->mechToken != NULL) { + if (!first_ok) { size_t j; preferred_mech_type = GSS_C_NO_OID;