From nobody Wed Feb 21 13:43:15 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TfyCS3gRVz5CCqb; Wed, 21 Feb 2024 13:43:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TfyCS1P9Bz4ctm; Wed, 21 Feb 2024 13:43:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708522996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=74MRrMgvoHMReNU73plaOVIMSNLMSMcp40tgviSi2Rg=; b=yvViM1C72xI39ri2rGupc9AEP/pu29HFpoApbYPgiHtkn5tAkXnevyqNM9PVV40NtvqXIV 4K1GnRGJqz8fTquPZwIi98ovVYQJyo4OLg9l6DI+nxQAO2AZsXtWIGhcsKkCvylR0fPDkY LSBN+X214ZsPIZm6pAqu7Jv0q6n6jcFfgr9Q37KQAuXQxl5htIrliqz25pVGaqBvhKAOF0 ESBy46GB/UUwfS/uouxIP/6Fo6AEQXjmY7iHNG8qvKOqhe++/NRBqplu2edxY71yB26f0R O8Pg45S2XHPBALDQWhUQzoiprbnb892gK0Zx9JJ+an+myI6enVpYsLVFJdzAZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708522996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=74MRrMgvoHMReNU73plaOVIMSNLMSMcp40tgviSi2Rg=; b=YYgeFyBjv9lrQL2ROClfZIgjQjJO9qoXdvGReAP8PXJ7OY68TPh9Z+oi/t1vkGIaepv0Bu mGvLbK0yTUCkqX6bOIQKdqzWfJEtQGQndqQvhKPQlsS4a0yoI/JTzQcPTtJxmOT2Z3oyn7 PuRhtBIzMWL/pckSfjCOHQwNXgCO1AlXUDwTbqNvVvSS7Uc86mKYjx/IVShN02oeH+NWIF QTBA95y8HoyVpoobKc6w6wqKijI731S9uZIebh9lLuzT2h6lHC4Xhxx8caCibltH1BHQoY Evsh8xlFUoqa6zKQhq4N+haf1HynZQPvZZ96n9FemhEeRhheoBpLY5FiauzVqg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708522996; a=rsa-sha256; cv=none; b=igG/nGT2ZhAFPRIDLi7Az1583LJDrlBiys0rvEe61Tly+Zs56K3KZovmodBdYUqt9ZmIAg OX0eCXZaz8w/zOp8Kw0dvr/18jl3KJY29+T1eBmC1Gd3zhSSICcB6G0/zJ6QqAKh1a+//A LMtCe0pDxxeop814qSoWeRVWuheZJ0VUWj6Iwg3hybVq1+aKYo3Dl7gWeHgmzozmilv0Ca 5otxbRwXL6q2g7WPNquslZwktlrOfYpcyeWhvX2weqezQZ9Ie761K17SWACRcxgmUuUN6Q 8Z+pRB+x7IzyMCmY86w3SOGasnzYIgmZHcNN81EM74dhxkU+++x1ztf1VtL/qg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TfyCS0Ldhz14L3; Wed, 21 Feb 2024 13:43:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 41LDhFuq048438; Wed, 21 Feb 2024 13:43:15 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 41LDhFOm048435; Wed, 21 Feb 2024 13:43:15 GMT (envelope-from git) Date: Wed, 21 Feb 2024 13:43:15 GMT Message-Id: <202402211343.41LDhFOm048435@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Cy Schubert Subject: git: 5b7c923d9581 - stable/14 - heimdal: Fix NULL deref List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 5b7c923d9581597ee30dece578e256f455ea09ce Auto-Submitted: auto-generated The branch stable/14 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=5b7c923d9581597ee30dece578e256f455ea09ce commit 5b7c923d9581597ee30dece578e256f455ea09ce Author: Cy Schubert AuthorDate: 2024-02-15 15:41:07 +0000 Commit: Cy Schubert CommitDate: 2024-02-21 13:42:58 +0000 heimdal: Fix NULL deref A flawed logical condition allows a malicious actor to remotely trigger a NULL pointer dereference using a crafted negTokenInit token. Upstream notes: Reported to Heimdal by Michał Kępień . From the report: Acknowledgement --------------- This flaw was found while working on addressing ZDI-CAN-12302: ISC BIND TKEY Query Heap-based Buffer Overflow Remote Code Execution Vulnerability, which was reported to ISC by Trend Micro's Zero Day Security: CVE-2022-3116 Obtained from: upstream 7a19658c1 (cherry picked from commit fc773115fa2dbb6c01377f2ed47dabf79a4e361a) --- crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c b/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c index b60dc19ad8e3..48542f06fcbe 100644 --- a/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c +++ b/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c @@ -605,7 +605,7 @@ acceptor_start * If opportunistic token failed, lets try the other mechs. */ - if (!first_ok && ni->mechToken != NULL) { + if (!first_ok) { size_t j; preferred_mech_type = GSS_C_NO_OID;