From nobody Sun Feb 18 21:11:12 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TdJHj1HqTz5Bm3Z; Sun, 18 Feb 2024 21:11:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TdJHh60rbz42N7; Sun, 18 Feb 2024 21:11:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708290672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NhjL6rKxatboINFjxuLZzMr25ABke+VrUBpBUMGojJI=; b=JP0IQEtKX5LfynYqNPbxVAfJdBLH06dkjMR7r6lMrhurjMy6m72T5R7TdIO5sAn7smlATM Vj9adbPF4ZQrYFCKq849fk56U7bIsPiGN7Dzr/YYOkAMAXzE82IY2NHhEoK9CPdqNCKqxX W8AAVugmzhXsto2/mRcCkcmuse4SlGIfAw3tWDUT1v0lW812vqKy+Vo3GFbAbgeGpC5Rv0 60NxeYmjR9urR+8f5pjIglWBiQ9dY+h5KR7njPkZIaHkMeQYkYKOnMQNTc2rgl+p4HFPTG x49buwkYqE2vIpMxF2gxh+w7LO81HuVwurwgnFEDNZivzJH2GCIrnMvCFxL1OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708290672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NhjL6rKxatboINFjxuLZzMr25ABke+VrUBpBUMGojJI=; b=wB8b3IzmlvU/47s206psP6pLx88hJe/qq+otJi7NDU5L/DOaNrRVuYmOkhBZH89Vn3V2Nj 3uABXyovuTnHSQl2h2+0nmWYZhVarYAjqePq1eYimbgTsv/7AvQfVPbrNPCsWaxBbg9ZLG sGafaQfuCDyiRLpo2IMttEk5KjYfo5tftN07yB54xKp3N2LmFv0s9LwWw0cQNvDfBkokMm Xevx9U5RvFKCHcXiRqdV980SHEQyjkvCeVEGRAf1V1R7MPVYsiRCF3qbwY6PmjiHd3/Arl uVnPca6IfZcZF/i4BilxfWyonGy+kINAa/nbD7nIJf3KxBHPlu6WSvG7LxBikQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708290672; a=rsa-sha256; cv=none; b=FL5RzN+j3zjSQGPbHNW/IKKFAsAX37kN6FEQSVrdrUSLFFin6JhEJCKLVP5sahL+s01IKE xz5jN8ZNNXexzywyBj1X1CT6lyR7dXA04gAPKteq4CWSkNEM8CCHk2BokvoagSoccB9XmO t9glTdOzaeoQpdPhinygZ+kayP/h+RTgAglYXECQ0Wfc0yuCDROIh6Q875WO5wgi4MPRRq jnLvZR8SWimLu0ZPl321QKtQjHMgkmvIqletim2em5RR8j5nEYXhKen5H9vfvRg7Ohrcqw 10KfQqBTo7m9w0NM9oyfIaanAMKeDztmmT0SA6hqoM/vwZfXn+DO0X6lwOuaAg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TdJHh50gfz16WJ; Sun, 18 Feb 2024 21:11:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 41ILBC0t013301; Sun, 18 Feb 2024 21:11:12 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 41ILBCgE013298; Sun, 18 Feb 2024 21:11:12 GMT (envelope-from git) Date: Sun, 18 Feb 2024 21:11:12 GMT Message-Id: <202402182111.41ILBCgE013298@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 5193a7cfcbdd - stable/14 - Revert "[ath] Attempt to fix epoch handling." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 5193a7cfcbdd082bc711ee9fd43171ebb26380ae Auto-Submitted: auto-generated The branch stable/14 has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=5193a7cfcbdd082bc711ee9fd43171ebb26380ae commit 5193a7cfcbdd082bc711ee9fd43171ebb26380ae Author: Bjoern A. Zeeb AuthorDate: 2023-11-03 21:50:31 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-02-18 16:43:39 +0000 Revert "[ath] Attempt to fix epoch handling." This reverts commit af2441fbc7fa9e522e7f8697e5a181bdd4ff9e00. Sponsored by: The FreeBSD Foundation (cherry picked from commit eb3821e6d92fa45ece7ec08efde45e35be1bdc95) --- sys/dev/ath/if_ath.c | 2 +- sys/dev/ath/if_ath_rx.c | 11 +---------- sys/dev/ath/if_ath_rx_edma.c | 4 ---- 3 files changed, 2 insertions(+), 15 deletions(-) diff --git a/sys/dev/ath/if_ath.c b/sys/dev/ath/if_ath.c index 094517da5689..31bfa1108592 100644 --- a/sys/dev/ath/if_ath.c +++ b/sys/dev/ath/if_ath.c @@ -758,7 +758,7 @@ ath_attach(u_int16_t devid, struct ath_softc *sc) taskqueue_start_threads(&sc->sc_tq, 1, PI_NET, "%s taskq", device_get_nameunit(sc->sc_dev)); - TASK_INIT(&sc->sc_rxtask, 0, sc->sc_rx.recv_tasklet, sc); + NET_TASK_INIT(&sc->sc_rxtask, 0, sc->sc_rx.recv_tasklet, sc); TASK_INIT(&sc->sc_bmisstask, 0, ath_bmiss_proc, sc); TASK_INIT(&sc->sc_tsfoortask, 0, ath_tsfoor_proc, sc); TASK_INIT(&sc->sc_bstucktask,0, ath_bstuck_proc, sc); diff --git a/sys/dev/ath/if_ath_rx.c b/sys/dev/ath/if_ath_rx.c index c0af0b59ccb5..cd22d9c683dc 100644 --- a/sys/dev/ath/if_ath_rx.c +++ b/sys/dev/ath/if_ath_rx.c @@ -667,8 +667,6 @@ ath_rx_pkt(struct ath_softc *sc, struct ath_rx_status *rs, HAL_STATUS status, int is_good = 0; struct ath_rx_edma *re = &sc->sc_rxedma[qtype]; - NET_EPOCH_ASSERT(); - /* * Calculate the correct 64 bit TSF given * the TSF64 register value and rs_tstamp. @@ -1090,8 +1088,6 @@ ath_rx_proc(struct ath_softc *sc, int resched) int kickpcu = 0; int ret; - NET_EPOCH_ASSERT(); - /* XXX we must not hold the ATH_LOCK here */ ATH_UNLOCK_ASSERT(sc); ATH_PCU_UNLOCK_ASSERT(sc); @@ -1311,7 +1307,6 @@ static void ath_legacy_rx_tasklet(void *arg, int npending) { struct ath_softc *sc = arg; - struct epoch_tracker et; ATH_KTR(sc, ATH_KTR_RXPROC, 1, "ath_rx_proc: pending=%d", npending); DPRINTF(sc, ATH_DEBUG_RX_PROC, "%s: pending %u\n", __func__, npending); @@ -1324,18 +1319,14 @@ ath_legacy_rx_tasklet(void *arg, int npending) } ATH_PCU_UNLOCK(sc); - NET_EPOCH_ENTER(et); ath_rx_proc(sc, 1); - NET_EPOCH_EXIT(et); } static void ath_legacy_flushrecv(struct ath_softc *sc) { - struct epoch_tracker et; - NET_EPOCH_ENTER(et); + ath_rx_proc(sc, 0); - NET_EPOCH_EXIT(et); } static void diff --git a/sys/dev/ath/if_ath_rx_edma.c b/sys/dev/ath/if_ath_rx_edma.c index 6c722ca8275f..fb25fb77b062 100644 --- a/sys/dev/ath/if_ath_rx_edma.c +++ b/sys/dev/ath/if_ath_rx_edma.c @@ -555,7 +555,6 @@ ath_edma_recv_proc_deferred_queue(struct ath_softc *sc, HAL_RX_QUEUE qtype, int16_t nf; ath_bufhead rxlist; struct mbuf *m; - struct epoch_tracker et; TAILQ_INIT(&rxlist); @@ -572,8 +571,6 @@ ath_edma_recv_proc_deferred_queue(struct ath_softc *sc, HAL_RX_QUEUE qtype, TAILQ_CONCAT(&rxlist, &sc->sc_rx_rxlist[qtype], bf_list); ATH_RX_UNLOCK(sc); - NET_EPOCH_ENTER(et); - /* Handle the completed descriptors */ /* * XXX is this SAFE call needed? The ath_buf entries @@ -597,7 +594,6 @@ ath_edma_recv_proc_deferred_queue(struct ath_softc *sc, HAL_RX_QUEUE qtype, if (ngood) { sc->sc_lastrx = tsf; } - NET_EPOCH_EXIT(et); ATH_KTR(sc, ATH_KTR_INTERRUPTS, 1, "ath edma rx deferred proc: ngood=%d\n",