git: 4df1b9cc2bff - stable/13 - hdaa_pcmchannel_setup: do not advertise AC3 8+0

From: Andriy Gapon <avg_at_FreeBSD.org>
Date: Sat, 17 Feb 2024 19:22:40 UTC
The branch stable/13 has been updated by avg:

URL: https://cgit.FreeBSD.org/src/commit/?id=4df1b9cc2bff6098f29ab8af4f12e7bdec3ee9be

commit 4df1b9cc2bff6098f29ab8af4f12e7bdec3ee9be
Author:     Andriy Gapon <avg@FreeBSD.org>
AuthorDate: 2024-01-28 13:18:02 +0000
Commit:     Andriy Gapon <avg@FreeBSD.org>
CommitDate: 2024-02-17 19:22:08 +0000

    hdaa_pcmchannel_setup: do not advertise AC3 8+0
    
    The rest of the sound system supports 7+1 maximum and is not aware of 8+0.
    
    I believe that these messages are caused by 8+0:
    kernel: feeder_init(0xfffff801f935d680) on feeder_matrix returned 22
    kernel: pcm0: feeder_build_matrix(): can't add feeder_matrix
    
    (cherry picked from commit c053a56c0f5df6db5223316831142e1d8afff64f)
---
 sys/dev/sound/pci/hda/hdaa.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sys/dev/sound/pci/hda/hdaa.c b/sys/dev/sound/pci/hda/hdaa.c
index 6d5e27b88b1f..20297f069d26 100644
--- a/sys/dev/sound/pci/hda/hdaa.c
+++ b/sys/dev/sound/pci/hda/hdaa.c
@@ -5428,7 +5428,6 @@ hdaa_pcmchannel_setup(struct hdaa_chan *ch)
 		if (HDA_PARAM_SUPP_STREAM_FORMATS_AC3(fmtcap)) {
 			ch->fmtlist[i++] = SND_FORMAT(AFMT_AC3, 2, 0);
 			if (channels >= 8) {
-				ch->fmtlist[i++] = SND_FORMAT(AFMT_AC3, 8, 0);
 				ch->fmtlist[i++] = SND_FORMAT(AFMT_AC3, 8, 1);
 			}
 		}