From nobody Thu Feb 15 21:30:38 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TbSsW0DXfz5BHRd; Thu, 15 Feb 2024 21:30:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TbSsV6HyQz4Smq; Thu, 15 Feb 2024 21:30:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708032638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XNSlEEhwZ5m0tSCEB1bIi7x3K1DCo03iNaXD988YXMs=; b=YITpZMFHHxkvI+C5PHa0UqF37w+/jQJrBEAeDlUxfIDd7q4zzt2QU0wc9Yottlgy44X1pg j9kDGrWhXrgIvfOShEL72Z2HPFHFSp0cqwTxzeszwAt35RIE3Em5g6RAP6eVY0XoqwBqS2 fGRL7FOTG9n/saB0uPO4RhI1bgVjNNjQY8UqlPFfcqB5jdw4QTDc+jEUct3d0QzNi/JUGo 6yzmNdXFOk+hcUsiT/6uK802usxdbvOiBlU/ps8adXkJktQRAMtRCHJnx0H6LJQktDdWLc u1jvyq+6VsL7uxaeu6yDEydFE/TWqjtN9dsU2FVoetsZYY9J2nsLpF3UGw91sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708032638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XNSlEEhwZ5m0tSCEB1bIi7x3K1DCo03iNaXD988YXMs=; b=sDN5WVFkPcdKiaHfIDKmBrYMtTS8wEOzUOndujizYXi6Q17ECXpi7EV95KkR61KUcoMaQ1 5LfZwsEK030XE5PFLWcWJUm2X8ikE5khebUNqwKi5Wn0QPXM+Um1rEIW47Psm1fKeAf/KE uS0xOtpbqAkekDYmb2vA4dTFC6gES3+Z5m125xSvfFNslDhnKwsU9RQqFtPsxAZ3WHKyn1 XZJ670b36d6kHPHNf3rWHc2zfapMZ033Xq0Kw8q7SdtGt8u5OghSzjjXU4CUDvBk7Ir/pL FJEZarmMHkArEYSSH9HIYX/WUdIORgLcssogNvi13C0b2+R9oRJiJPxPt12DdA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708032638; a=rsa-sha256; cv=none; b=ly2ylg8g6F/yVT/+CwjYSPhEFTmOxAqNxI2JvS+dyEyMN0JPnv2gSZgx235UIOn+uN3S1T VTei/ZASRHNdCTgHmJTGg6RgpZljBkgOuAOYb2i5x9YwXbWGmhET1JSTTG+l2/wIneE2sW 0jI58kX11u80siQgVrkzP7z0Lnrkd7sUHfOnZEX80w7ugVg/q7NHCIl06WsfXzU5H8X/R2 jMtb4OrEL5m4jTne202IA4nOOO7q+FzccU2uYM/lYIFFzovCEucqU3EceGyS8/RuL/bLgq TJls35VgvhFDnI4S4K1W8+vjJKZ7iu9/l1xsHuLAhrFyaPFF49a39QDhg5yEKA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TbSsV5PdMzyDr; Thu, 15 Feb 2024 21:30:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 41FLUcfW063629; Thu, 15 Feb 2024 21:30:38 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 41FLUcAK063626; Thu, 15 Feb 2024 21:30:38 GMT (envelope-from git) Date: Thu, 15 Feb 2024 21:30:38 GMT Message-Id: <202402152130.41FLUcAK063626@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Cy Schubert Subject: git: fc773115fa2d - main - heimdal: Fix NULL deref List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fc773115fa2dbb6c01377f2ed47dabf79a4e361a Auto-Submitted: auto-generated The branch main has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=fc773115fa2dbb6c01377f2ed47dabf79a4e361a commit fc773115fa2dbb6c01377f2ed47dabf79a4e361a Author: Cy Schubert AuthorDate: 2024-02-15 15:41:07 +0000 Commit: Cy Schubert CommitDate: 2024-02-15 21:27:55 +0000 heimdal: Fix NULL deref A flawed logical condition allows a malicious actor to remotely trigger a NULL pointer dereference using a crafted negTokenInit token. Upstream notes: Reported to Heimdal by Michał Kępień . From the report: Acknowledgement --------------- This flaw was found while working on addressing ZDI-CAN-12302: ISC BIND TKEY Query Heap-based Buffer Overflow Remote Code Execution Vulnerability, which was reported to ISC by Trend Micro's Zero Day Security: CVE-2022-3116 Obtained from: upstream 7a19658c1 MFC after: 1 week --- crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c b/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c index b60dc19ad8e3..48542f06fcbe 100644 --- a/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c +++ b/crypto/heimdal/lib/gssapi/spnego/accept_sec_context.c @@ -605,7 +605,7 @@ acceptor_start * If opportunistic token failed, lets try the other mechs. */ - if (!first_ok && ni->mechToken != NULL) { + if (!first_ok) { size_t j; preferred_mech_type = GSS_C_NO_OID;