From nobody Thu Feb 15 01:03:57 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TZxf55zkDz553SR; Thu, 15 Feb 2024 01:03:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TZxf55SVjz4cS2; Thu, 15 Feb 2024 01:03:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707959037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JXMOg0zCFVElafxi7NLzvoQ+Y7SSGhaO7YbEssW9VoI=; b=JXYNB3X86G72FxV48a5YW/ng4Gv9bW4WXuYizqOpmPSwMVH6WnSH4duUhdysqr9m75ArUU keRXAsAK739r+v5x2p/xk4/mh1touPFf8qh3IEL3zF6HbjqHrg0UuskAImH84JK7WQQyVy U7VLXYclnz4tR9GamyVh//a4fJAfUu++xgd0xThuy3sChpkpunl8TjqLEAsyP+7dQySOi/ zUeuPhEFhlMb9ngB5jDYnDsC1JSUN/b+ThZ/Vh6x9QJ3n7bE1oEmziRBubFq8YqpnR5z50 nq3ftYqjskHQLYlOq/1us/Ss4yIxJAa9yqpsDII6mbwi4Kk2B1QodtUmvefvfQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1707959037; a=rsa-sha256; cv=none; b=amauivKLpczWfhwZlH4QFOjECsFLVQOAl4sqYDqdBuhAuaf1ksAWN6ADqt7uP1Sns51OvX 25yeN+jugufjcDkvbGOMaQ0zO0LHJ+bmMKoqEnp6YcQ1PKPKGn98XdiV2aOPdUejG2iAGc xwNt436LvLjMBpbmwY03t7nxP/BpXaqEowTKzVfQFEDsmA8ufjz8oAVZ3ttDWOZg+jiagt heEJZ17oOD1//0VSvE+hibSc1cEUewzQ7nEz8yHjM76v62y/VUBQyhWPgOJ8pfbmx4+6Gi Z/kxqOZzJxP5W70kwDJsMAr0pI7NBK8vxytjHMmZ1FJzLnMB04pZ3vAidjSytQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707959037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JXMOg0zCFVElafxi7NLzvoQ+Y7SSGhaO7YbEssW9VoI=; b=slAeGipQqY123sSsg9NnhmjlFY75D2iMiION/1vnb8sWt3gqPbBqEGQJihfiJBkt0j5rVc Fox58niH1jAZxz+T3OFxvgP0kUvzmefHhq+wbWM5gNYepp+ea5F7Wd4H991H6QhRMz/sNx E8VlsWQn2RcVc58mNQ9mcTpUB7w8Jwgw/WCUtk7HpwwYbusG4HRou2jp6RYB1NxHQd2WlO PruLz+wL0olGncED+DVYahYANmhV4vaiw4BySXG5w3Q7U1pjLOBorcDRZVILHHg7NMbCz/ 701i+M4iBM5FasWItiNBPW0zhPRLxBy6WXqtnvlDOx5s8mpVqGaBIVHhfzCGLg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TZxf54Ch4zLcm; Thu, 15 Feb 2024 01:03:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 41F13vIU005786; Thu, 15 Feb 2024 01:03:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 41F13vvp005783; Thu, 15 Feb 2024 01:03:57 GMT (envelope-from git) Date: Thu, 15 Feb 2024 01:03:57 GMT Message-Id: <202402150103.41F13vvp005783@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Tai-hwa Liang Subject: git: 25a5bb731805 - main - net: bandaid for plugging a fw_com leak in fwip_detach() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avatar X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 25a5bb7318052322190a2880e0e7ef18e06d54bd Auto-Submitted: auto-generated The branch main has been updated by avatar: URL: https://cgit.FreeBSD.org/src/commit/?id=25a5bb7318052322190a2880e0e7ef18e06d54bd commit 25a5bb7318052322190a2880e0e7ef18e06d54bd Author: Tai-hwa Liang AuthorDate: 2024-02-15 01:00:49 +0000 Commit: Tai-hwa Liang CommitDate: 2024-02-15 01:00:49 +0000 net: bandaid for plugging a fw_com leak in fwip_detach() Adding a temporary workaround for plugging a fw_com upon if_fwip unloading. Steps to reproduce(needs two hosts connected with firewire): while true; do ifconfig fwip0 10.0.0.5 up fwcontrol -r ping -c 10.0.0.3 kldunload if_fwip done There's a chance that the unloading of if_fwip.ko triggers following warning: Warning: memory type fw_com leaked memory on destroy (1 allocations, 64 bytes leaked). commit d79b6b8ec267e7eef6e07cf4245159705e24acd5 (origin/main, origin/HEAD) --- sys/net/if_fwsubr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/net/if_fwsubr.c b/sys/net/if_fwsubr.c index 2349ac35fc16..bf3362fc975c 100644 --- a/sys/net/if_fwsubr.c +++ b/sys/net/if_fwsubr.c @@ -802,6 +802,7 @@ firewire_ifdetach(struct ifnet *ifp) { bpfdetach(ifp); if_detach(ifp); + NET_EPOCH_DRAIN_CALLBACKS(); } void