From nobody Mon Feb 12 11:00:20 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TYM1c4xvjz59ZSn; Mon, 12 Feb 2024 11:00:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TYM1c4Nwzz4VGx; Mon, 12 Feb 2024 11:00:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707735620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GpBcbkpSKR3+qLhsUi6FUk3SL/5wbL/Mb4aITLW94+U=; b=t93wul6I1Nz47/mu/KFP/LEg/Sb044poaWRC6/pZn7Lga50M79FBCKW5KkXilZwsOPADtw GLiz+prJjGjgSSxYFcylyIq0Be1kanrNhnkbFO8zxtFib9cK0TIp9sCd7t4pCn46m6I1QV Tq0jZASuO5dvdy6BUmRSFJHE55Q8L5yf0m64cWdW/ObQzxd/FuRSjz6xTaXgP41mfqCTEq NfyNyGv2a+OTkxpoyY3IlCWijXwAmMIcUlu8coGsPqjlI2nF12nF/xpyqmBzVlEQ3Bjwwd 7n6DiL+XwyqjsPiEWr71nXGYjsX2gIZshscPqiKGBSUlcIg5ADPfMKSen1hG2Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1707735620; a=rsa-sha256; cv=none; b=jCKvYHwdZrEMbQz4+3IlvenP5UbrQ/d4EKbD0QXDbpH3jCG/IJSH+PL0lr2+qh2WdQhZiO JuuBq9iap+LefVwmUSmA87wtwjNJ/fmNhP5soLvzZZk5g/q4311q2i6R5x52SZOv932J3x KekkhHcMJrqsCJKUVGR2XAzm6vpcsxdt/on0afuM/a+0Y15/3KqLArEIHp9aflHXFjf/3O YyMdXqPXPaSyGFf9vjWhGdcM/UuCHzyTVjWJE/i1uKqatxQbx4qo1gTf/u5M30w7tzxTyQ 5RuItjpsp3sTqs00kt2VIvVD/PPhtnmZdJvD5ePk5ruBzpE008k9u7alV0R6hw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707735620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GpBcbkpSKR3+qLhsUi6FUk3SL/5wbL/Mb4aITLW94+U=; b=nLcVC9AmcQ7xi2UbYbFgYm70T9eHqjFiiz6MaIBDXsMm7UaHQRI1oGitUOxm84/6C7sAh1 hz+Fp4Udd9+30u41PigaMyIHismtjaGlB1ULtbXhjdPZAst4YR0WzXTFcCe2HMZbADECXg ghXI55lzRR4st8ZX0Vj/U+KBUgxQ4F7BG3bmEFUdsHzgk/R1L+E+aEazff6HLPI7DoQNkA VTrm51HJ7Xmt6MG0JnWFp9M+RlqZrJnvZA9MUMjqJ2wmcVlpzDmmqovrHw2I4xUpQt4ljn EhKiI9JA1u6pSC3exCcuOuwX26IAsZ27yDNrPZkk/k3FP6zjyu7AedJeOvNHRQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TYM1c3VvhzNpw; Mon, 12 Feb 2024 11:00:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 41CB0KGH033241; Mon, 12 Feb 2024 11:00:20 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 41CB0K7h033239; Mon, 12 Feb 2024 11:00:20 GMT (envelope-from git) Date: Mon, 12 Feb 2024 11:00:20 GMT Message-Id: <202402121100.41CB0K7h033239@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 75be886e58dc - main - mixer(8): Allow full PCM device names as input for the -d option List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 75be886e58dc237b633104fc9cf8d7d1285e4003 Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=75be886e58dc237b633104fc9cf8d7d1285e4003 commit 75be886e58dc237b633104fc9cf8d7d1285e4003 Author: Christos Margiolis AuthorDate: 2024-02-12 10:59:02 +0000 Commit: Christos Margiolis CommitDate: 2024-02-12 11:00:05 +0000 mixer(8): Allow full PCM device names as input for the -d option The -d option is a wrapper around hw.snd.default_unit. Currently mixer(8) expects the option argument to be just the unit's number (e.g pcm0 -> 0). To avoid confusion, allow full device names of the form "pcmN" as well. While here, improve the -d option's description in the man page. Sponsored by: The FreeBSD Foundation MFC after: 2 weeks Reviewed by: dev_submerge.ch, imp Differential Revision: https://reviews.freebsd.org/D43794 --- usr.sbin/mixer/mixer.8 | 23 ++++++++++++++--------- usr.sbin/mixer/mixer.c | 6 ++++-- 2 files changed, 18 insertions(+), 11 deletions(-) diff --git a/usr.sbin/mixer/mixer.8 b/usr.sbin/mixer/mixer.8 index 10a461d91693..5750b81c98c5 100644 --- a/usr.sbin/mixer/mixer.8 +++ b/usr.sbin/mixer/mixer.8 @@ -19,7 +19,7 @@ .\" OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN .\" THE SOFTWARE. .\" -.Dd January 12, 2024 +.Dd February 8, 2024 .Dt MIXER 8 .Os .Sh NAME @@ -28,12 +28,11 @@ .Sh SYNOPSIS .Nm .Op Fl f Ar device -.Op Fl d Ar unit +.Op Fl d Ar pcmN | N .Op Fl os .Op Ar dev Ns Op Cm \&. Ns Ar control Ns Op Cm \&= Ns Ar value .Ar ... .Nm -.Op Fl d Ar unit .Op Fl os .Fl a .Nm @@ -44,16 +43,17 @@ The utility is used to set and display soundcard mixer device controls. .Pp The options are as follows: -.Bl -tag -width "-f device" +.Bl -tag -width "-d pcmN | N" .It Fl a Print the values for all mixer devices available in the system .Pq see Sx FILES . -.It Fl d Ar unit +.It Fl d Ar pcmN | N Change the default audio card to -.Ar unit . -The unit has to be an integer value. -To see what unit values are available, look at the number each mixer device has by running -.Nm . +.Ar pcmN , +where N is the unit number (e.g for pcm0, the unit number is 0). +See +.Sx EXAMPLES +on how to list all available audio devices in the system. .It Fl f Ar device Open .Ar device @@ -218,6 +218,11 @@ opens when the option has not been specified. .El .Sh EXAMPLES +List all available audio devices in the system: +.Bd -literal -offset indent +$ mixer -a | grep ^pcm +.Ed +.Pp Increase the volume for the .Cm vol device of the first mixer found by 5%: diff --git a/usr.sbin/mixer/mixer.c b/usr.sbin/mixer/mixer.c index 043c8c412857..0c0c37ccb2bc 100644 --- a/usr.sbin/mixer/mixer.c +++ b/usr.sbin/mixer/mixer.c @@ -66,6 +66,8 @@ main(int argc, char *argv[]) aflag = 1; break; case 'd': + if (strncmp(optarg, "pcm", 3) == 0) + optarg += 3; errno = 0; dunit = strtol(optarg, NULL, 10); if (errno == EINVAL || errno == ERANGE) @@ -194,8 +196,8 @@ next: static void __dead2 usage(void) { - fprintf(stderr, "usage: %1$s [-f device] [-d unit] [-os] [dev[.control[=value]]] ...\n" - " %1$s [-d unit] [-os] -a\n" + fprintf(stderr, "usage: %1$s [-f device] [-d pcmN | N] [-os] [dev[.control[=value]]] ...\n" + " %1$s [-os] -a\n" " %1$s -h\n", getprogname()); exit(1); }