From nobody Fri Feb 09 03:13:40 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TWJpX6jkzz58lQT; Fri, 9 Feb 2024 03:13:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TWJpX5sp9z4Gm3; Fri, 9 Feb 2024 03:13:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707448420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+qJbkZt9EOtCz3aqWvZ7Y/6MpZ3d4uA3WEdV7rRRJOY=; b=EWz5uS5+v4gZltZoon0S49mTnn6MuVgYzXDBPiuO7K5OFlq9Q7mHZ72ATHxuCPL90OS1Jw 8CCtoM5nfp+A/pdTz2ohtrLDJrLzDDO+l1Rs942a8HckPXmDL3SxGFfNzajJsnlMlFNhe1 L85hYECUsKDYZed8w8X1RPpB/b8Dgx6fOcZAmCu6k5z3wW8tTXwqwx56eRr8LzHxz5fHQz vwRxAzrr2xiATmbx8t9TsM7nsl91ZeO4yewST+hlT8wODyeoyI8zY+VpbMSPmuqS/CtxRf g5B4V9Xuw3I9Kq5MjrzpRld3Ihh23XqHh9qE5r7l/5l+QWXOv8iuVTeVnihsGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707448420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+qJbkZt9EOtCz3aqWvZ7Y/6MpZ3d4uA3WEdV7rRRJOY=; b=mmrmQM8Ima54m53oWFpb9r0LoeJs1lANVT2EEINookI2J/sEMjh28VegGvtVJIH0Q0VtLz RMUi6oowJk4TW55gR+qigFjFUJ5MBC9eMBnHSVXdqLN/lKJCJVYFtNr0VMnHvbD463eRhc 552os+14Yr/VpgfpNdYMBNCJPzIJHYQneeZiHX6uA+eBxi8uajThblccCLEaKBrHFyxcHP kYvjEkC8sshn04ZkyxjY6aUIAL5H1xmkiBgOhztwewZ9ty/rJREcN6qxgGu1Bbv3RQ834U PrQ3CwpymCrfC5FNtL6Pgy7z4pzJcCv3qwpao2HGT9uYgDivRJIdsiF3thQtLQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1707448420; a=rsa-sha256; cv=none; b=C2lmktAiKZ6+02nFk4QPuZPNqNP8C+3m3+TtFEa8HRWgkyhoqrSYHLxw/7vD0cvjnGHNwS fb4hwfRp7nVSfcveakj2TeiiMPKTetMfFFut7EPlUraW8Af43YVa2vwOEr9h4+SfX1CusW FtfhT+ijdKSVul1S1mLdfxHeKquwaFH+47yUxDgfoF+g+3j74EI7VikBFTcmmhoDoImau6 JrmR9y/QfGDo1/c1o51v78uZ57C0BZw38L526sta/EBHu6T2X72SjtDAwjrV6jR53P1gck /G5NXIbzMeLUYHUs/AJMJsWsPmSI4CxLWjW2hzrBfACy+sL7hr+vwYJGA+Ufew== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TWJpX4xJ8zGQq; Fri, 9 Feb 2024 03:13:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 4193Dehi096841; Fri, 9 Feb 2024 03:13:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 4193DemE096838; Fri, 9 Feb 2024 03:13:40 GMT (envelope-from git) Date: Fri, 9 Feb 2024 03:13:40 GMT Message-Id: <202402090313.4193DemE096838@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alan Somers Subject: git: 8758bf0aaec1 - main - fusefs: only test for incoherency if FN_SIZECHANGE is set List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8758bf0aaec1d4b2ebcb429e8cabc691c2c95461 Auto-Submitted: auto-generated The branch main has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=8758bf0aaec1d4b2ebcb429e8cabc691c2c95461 commit 8758bf0aaec1d4b2ebcb429e8cabc691c2c95461 Author: Emil Tsalapatis AuthorDate: 2024-02-08 01:13:43 +0000 Commit: Alan Somers CommitDate: 2024-02-09 03:13:24 +0000 fusefs: only test for incoherency if FN_SIZECHANGE is set FUSE emits spurious incoherency warnings in writethrough mode. The warnings are triggered by setattr calls generated by vnode truncation turning the cached va_size vattr stale, causing comparisons with the fresh version provided by the server to fail. Only validate the vnode's va_size vattr if the FN_SIZECHANGE flag is set. This is a part of the research work at RCSLab, University of Waterloo. Reviewed by: asomers MFC after: 1 week Pull Request: https://github.com/freebsd/freebsd-src/pull/1110 --- sys/fs/fuse/fuse_internal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/fs/fuse/fuse_internal.c b/sys/fs/fuse/fuse_internal.c index ffbf1f9bcc40..29d88fc942f4 100644 --- a/sys/fs/fuse/fuse_internal.c +++ b/sys/fs/fuse/fuse_internal.c @@ -269,10 +269,10 @@ fuse_internal_cache_attrs(struct vnode *vp, struct fuse_attr *attr, if (vnode_isreg(vp) && fvdat->cached_attrs.va_size != VNOVAL && + fvdat->flag & FN_SIZECHANGE && attr->size != fvdat->cached_attrs.va_size) { - if ( data->cache_mode == FUSE_CACHE_WB && - fvdat->flag & FN_SIZECHANGE) + if (data->cache_mode == FUSE_CACHE_WB) { const char *msg;