From nobody Fri Feb 02 07:25:18 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TR6k64Mq0z588wq; Fri, 2 Feb 2024 07:25:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TR6k63r30z4cHP; Fri, 2 Feb 2024 07:25:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706858718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WLR6en52YG5+Knl4Cx0qR8xQGNVOrEeBE0gJuLedBtA=; b=NfB6VE0JJZNHwkT/cfCzqpjxPvnyxvsL7+TjiUXKoy1KjxTxCdClcnmhki07u6rp5oC+H4 sRUAWmZAamln6AIgrAt6yfkqUh5pQgQ9wXhWOzZCNxU4cHgmf6Tp49Z/eWGVRoGppYN0y/ tOi3ecsaVlS/DWUB0koWMzgqTu4UF7VyS6HniJftodGoUlELsuGh+jOWQ4lepSo0XAuK0a eDWsyYUAWXYwjCP5E1Ykoasa0YGTQOF4Fo4c4jf9ew8qWXOD9lMcHLhGo62O/Ysm7OQtzT EVi6o8sApkbbckC5Acv6nVNyr+6NdSAW/daFIW1pFdiF5fyMSGnWZ+AYHRpLlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706858718; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WLR6en52YG5+Knl4Cx0qR8xQGNVOrEeBE0gJuLedBtA=; b=XYJRxGaQKisJPOXqBBqHfVNAJhoZOzPIVtHOLy69IO1GcyzOWTA5g9Fg5jAO+vTji7Lyji vSxMzAr6ua5BQLnWYhrn6XAvVSnAwwppw7eK1mekzru+H07keyX2D5G4todysx6bWb3lL7 DpzB/vnzwSlQW0wl2T2w2wUu483B5fmZRy6UzWV9jfexaJwiV8KVo8Ysz+R0M/FaZA/w8B 26RhkztQGdR1gEGDzx1UvxHvMZvx4G1hY8iNrTtjErPGV5n+/fUqqYUPHHN/sQ7Az1Hy98 yi/nMLThjqoIbZirHAUa/3ADezmvzgEbcRDpA7eOHTZzda8+/LZLK0U1xXhMZQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706858718; a=rsa-sha256; cv=none; b=IAdVZIa7Qpa4kXxAtZUoDYRl0TV53k61KYSET9AwXCn/tpStTuG8ISwFZsCTQdHQzYp4O5 TNw021n7iV8lnlqwxKUkutgV7g462FYLmJu/zjtfIz7Z8iJXlsIb07uEZ3pBf5NDE5IQlz F6cOyxaCd2mEZUUreH2LEuTthq4gVOZ6tphVGbyWuUTOTN/c6/7qHaHlXZKe6p5w8wfHHB PQGpuGHobqiCmYi/UFMQH/AQDju5VJXGOq8eCdiAxpcUuR5LYMI8uw7bgoyg1crUi1ninr Tqm+8MPLr6iFZqiO66q474Ht6GJUu4NhcE6C//D5Gp7sJYeQfIcG6qjEnVNIPw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TR6k62w8fzLf4; Fri, 2 Feb 2024 07:25:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 4127PIVx078945; Fri, 2 Feb 2024 07:25:18 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 4127PIqb078942; Fri, 2 Feb 2024 07:25:18 GMT (envelope-from git) Date: Fri, 2 Feb 2024 07:25:18 GMT Message-Id: <202402020725.4127PIqb078942@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 22d12caad69e - main - checkstyle9.pl: Differentiate errors and warnings List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 22d12caad69ef2d8e1c76671b44fd5493490acb7 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=22d12caad69ef2d8e1c76671b44fd5493490acb7 commit 22d12caad69ef2d8e1c76671b44fd5493490acb7 Author: Warner Losh AuthorDate: 2024-02-02 07:23:43 +0000 Commit: Warner Losh CommitDate: 2024-02-02 07:24:32 +0000 checkstyle9.pl: Differentiate errors and warnings Use ::error and ::warning as appropriate to give better meaning to the messages. Sponsored by: Netflix --- tools/build/checkstyle9.pl | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/build/checkstyle9.pl b/tools/build/checkstyle9.pl index dd6eb624e0b4..df9ec2bbd7c1 100755 --- a/tools/build/checkstyle9.pl +++ b/tools/build/checkstyle9.pl @@ -1177,6 +1177,8 @@ sub report { my $output = ''; my $do_color = $color && !$github; $output .= BOLD if $do_color; + $output .= "::error " if $github && $level eq 'ERROR'; + $output .= "::warning " if $github && $level eq 'WARNING'; $output .= $prefix; $output .= RED if $do_color && $level eq 'ERROR'; $output .= MAGENTA if $do_color && $level eq 'WARNING'; @@ -1399,8 +1401,8 @@ sub process { #make up the handle for any error we report on this line $prefix = "$filename:$realline: " if ($emacs && $file); $prefix = "$filename:$linenr: " if ($emacs && !$file); - $prefix = "::error file=$filename,line=$realline:\:" if ($github && $file); - $prefix = "::error file=$realfile,line=$linenr:\:" if ($github && !$file); + $prefix = "file=$filename,line=$realline:\:" if ($github && $file); + $prefix = "file=$realfile,line=$realline:\:" if ($github && !$file); $here = "#$linenr: " if (!$file); $here = "#$realline: " if ($file);