From nobody Tue Dec 31 16:28:55 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YMz1g3Ws3z5jjkh; Tue, 31 Dec 2024 16:28:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YMz1g2byyz4cGB; Tue, 31 Dec 2024 16:28:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735662535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/TsU5M0e3Uw/CR0+b5zNBN5/1RUp9lJ0BqDanCTAlZk=; b=tH/GXiGGHDuygKHGm2x86ytZD2Q30Xp2Y/e2VcZbExRb2vFgtMgkH4Y2yWGMagwnVYTxML 587MkM0X62h9uAa0OBAR3r268umdGULmhkyxyCWrEwwT9uBa5dhs7WgzCSJ/iglSj0jpnJ PgB2R7mG7OgsnhrKs+vryBJ5r73krUeiYsp9mDtbWio1BVAdKMtHsZjuH+zH5PIvXcokaR 4l8XQd1u88WeKHvLnpa/+wte0SNUqXMGMLpWp/eUR13cTtUJz9lIbYUtN6mwC2ntbFvbwE zY2Nz51KCdy+rFdBR6aAwjm0/xK949bKaYLEMSou+iLPpdAQs2hVOHXxXUKtGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735662535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/TsU5M0e3Uw/CR0+b5zNBN5/1RUp9lJ0BqDanCTAlZk=; b=RtSXRR9TmVnvskh63i3ITKzJjuD2AnJG5HQzcf1MhPEU3IZXo3HoyLKHJKEo41kfFmYVSm BLw7vTF6yh+/jLdjB0HXHsEkE6ygLlefcMLCTlSYRJxpwdoNZXmdeXQgG5RZPTOY5x8k5D AJ7eqch+ioNILn3FzbF8X6YEd5Tri9mWbCGiH+zO+YCqW0JIQNSY6N3l1ThVH7B234Umi+ 0Wyjog6D8dHyAqL3awsLcOce3s0gVsnrZfE11vpK59qYb7UyR8+SEh4vbUWpKQRiOMwHkf UUT0i9GjLvs1X4ApvCRxlwhKUsd495AFx9yHEx0lwKgDVBOKam4mI2DcrnDWAg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735662535; a=rsa-sha256; cv=none; b=XN0WiB7MuZ3MwzIqiTahPd42pxpFCiNE9E5Mf/fOMsXeT24HOZgLR6lxjsCMFGGFTSAj2i AIXoYcJZou9e/Sr26PLiLPACwjVbhmYxq7p5tkVJCSR6MkZJEWFsaGSc0cLPS9hVX6BdcO g791VBM3m+V8MdVqu+GdOzpJc6QnviL5Wbfb2I0t8mWM5cocUUnFvKUVLZz9dQ2336gAOS 3gjHcHdOwEMJi4BtfZ9RXCis3Xqp8LMmkZ+3ybdcRl1QzdhAGcZ3V2aGZ5QZdBuM8HxsRp dBnnN5HeVjAoVyLCO8uxCRFJAvA3N0GaxbuGPwpP3f9pxejN3CtnfJReSwK65A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YMz1g22wwzmpB; Tue, 31 Dec 2024 16:28:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4BVGSt9j043478; Tue, 31 Dec 2024 16:28:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4BVGStTu043475; Tue, 31 Dec 2024 16:28:55 GMT (envelope-from git) Date: Tue, 31 Dec 2024 16:28:55 GMT Message-Id: <202412311628.4BVGStTu043475@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 4f3a0c719780 - main - TCP RACK: don't use an uninitialized variable List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4f3a0c719780fdd57c660ceb353bbc71fc555600 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=4f3a0c719780fdd57c660ceb353bbc71fc555600 commit 4f3a0c719780fdd57c660ceb353bbc71fc555600 Author: Michael Tuexen AuthorDate: 2024-12-31 16:26:04 +0000 Commit: Michael Tuexen CommitDate: 2024-12-31 16:26:04 +0000 TCP RACK: don't use an uninitialized variable When storing the old beta values in rack_swap_beta_values(), ensure that the newreno_flags field is initialized appropriately instead of using an uninitialized value. Since the stored newreno_flags aren't actually used, this fix should not have any functional change. Reviewed by: rrs CID: 1523796 MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48260 --- sys/netinet/tcp_stacks/rack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index da68060dd1d2..ef2554926734 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -642,6 +642,7 @@ rack_swap_beta_values(struct tcp_rack *rack, uint8_t flex8) failed = 2; goto out; } + old.newreno_flags = CC_NEWRENO_BETA_ECN_ENABLED; /* Get the current values out */ sopt.sopt_valsize = sizeof(struct cc_newreno_opts); sopt.sopt_dir = SOPT_GET;