From nobody Mon Dec 30 14:59:33 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YMK51694sz5k3JY; Mon, 30 Dec 2024 14:59:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YMK515NLmz4fnQ; Mon, 30 Dec 2024 14:59:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735570773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YbTT5K0dYJniKh/nuKpPks5klM3fPsAqBOBnktojVp8=; b=p8llVD6OFIj1BTmm81Eh8bJjYRP/n7PdfpDgvypcrK++vfyuCVPodQbVe0N/MqOhIWo9Qt EeiajO4DBFfWicwtRMYyLMNyenA8mNq0nnb/9ZaDi98DGdmUBE93VNrQrbHFa2ozgmAlPN pMn+jNG+iwanlPDZB6saQ5Wu5zhgounB40sRb+VNIvjVkRjX/XD6e8yZKKdBXSpdBCkKp9 JK4b9pkvknge/zF2Gu4WX4LXyP80G1jKdhC4eBAj8EVLySsh6BUlwXphrZOqFzzSmuUPU/ NWPHN1xwIGtKV1PSHhAj8umiKtnOI1zuyum4+z7YAS+pCSZxgBev1UQ0jFLTVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735570773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YbTT5K0dYJniKh/nuKpPks5klM3fPsAqBOBnktojVp8=; b=nNgUBOZEJaRapDbLeDeWQxPtJ1DqyRBrLvPst0KgjjBcvF0gkXHv/W1/iByfVPsbgADDOk A45OoFiCl9nQhaO2RtY6TYmzWlr6X9o99zutmqeQtdLoNAKKulkv5OFAvMorC82TLLVIaY 4AUU/zVLevZIHNzuR3PNg3mw6BdH2RXI3Q3mDOrydbqmwqpkpRnkeFxqzw6lCFk8zxOreS mytlWTaMabfe3BVJLae66F0F84GYBgOkDeNA8jDd1By7WtnOa4fVEzQANZA8NF1PC71XiJ ItSX9qJaQKmR2TzIy2JwFlvvhPfoSGXFagZWIzvCrzbx/ua4WgiLsouJAkqXZg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735570773; a=rsa-sha256; cv=none; b=kluLVKgPCfFxmUK/K8oVoDFRK4x3l7cwBAb9MYnJeqC8cBrHstgSrRkvqX0KaVnJqytX32 eTkm1NJJ+9T6ZILk5MInx8PQg4/aP8TkfNPI0B6TVvhGdOMREIZ3O6Ho1KZ9XcQIbDyOSX HkQ8YfQouCT+MoLyfv9fRED/zTrBUam7G/MuV7Nfa/bIifHlO3DkfQLaCEgOV+PlkZ/eBM 9dWWd5q5KapEqyuikqaxuQNSCxsn1QvatN96mY8z0cExn/nVMz72rUnDSaa/LsBIf3hbp6 ahilokrBanI9RZBZLLbBBieTtwCjswe6RSlheiQqPv4UtiJa/vgxYSWWFw+O4A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YMK514sCczyVL; Mon, 30 Dec 2024 14:59:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4BUExXfP066719; Mon, 30 Dec 2024 14:59:33 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4BUExXsb066715; Mon, 30 Dec 2024 14:59:33 GMT (envelope-from git) Date: Mon, 30 Dec 2024 14:59:33 GMT Message-Id: <202412301459.4BUExXsb066715@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 895347fc10c5 - main - TCP BBR: remove assignments without effect List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 895347fc10c5b06bddadcc2937fdcf298c7e1114 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=895347fc10c5b06bddadcc2937fdcf298c7e1114 commit 895347fc10c5b06bddadcc2937fdcf298c7e1114 Author: Michael Tuexen AuthorDate: 2024-12-30 14:57:11 +0000 Commit: Michael Tuexen CommitDate: 2024-12-30 14:57:11 +0000 TCP BBR: remove assignments without effect No functional change intended. Reviewed by: rrs CID: 1523772 CID: 1523777 MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48215 --- sys/netinet/tcp_stacks/bbr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/netinet/tcp_stacks/bbr.c b/sys/netinet/tcp_stacks/bbr.c index 01a864f59bbe..24c3685f139a 100644 --- a/sys/netinet/tcp_stacks/bbr.c +++ b/sys/netinet/tcp_stacks/bbr.c @@ -7324,11 +7324,9 @@ bbr_log_ack(struct tcpcb *tp, struct tcpopt *to, struct tcphdr *th, p_maxseg = min(bbr->r_ctl.rc_pace_max_segs, maxseg); th_ack = th->th_ack; if (SEQ_GT(th_ack, tp->snd_una)) { - acked = th_ack - tp->snd_una; bbr_log_progress_event(bbr, tp, ticks, PROGRESS_UPDATE, __LINE__); bbr->rc_tp->t_acktime = ticks; - } else - acked = 0; + } if (SEQ_LEQ(th_ack, tp->snd_una)) { /* Only sent here for sack processing */ goto proc_sack;