From nobody Sat Dec 28 19:47:47 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YLCb41Yfxz5j6XM; Sat, 28 Dec 2024 19:48:16 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Received: from corp.infotel.ru (corp.infotel.ru [195.170.219.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4YLCb30VWjz599Z; Sat, 28 Dec 2024 19:48:14 +0000 (UTC) (envelope-from vladimir@kondratyev.su) Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of vladimir@kondratyev.su has no SPF policy when checking 195.170.219.3) smtp.mailfrom=vladimir@kondratyev.su; dmarc=none Received: from corp (corp.infotel.ru [195.170.219.3]) by corp.infotel.ru (Postfix) with ESMTP id 08D587736; Sat, 28 Dec 2024 22:48:07 +0300 (MSK) X-Virus-Scanned: amavisd-new at corp.infotel.ru Received: from corp.infotel.ru ([195.170.219.3]) by corp (corp.infotel.ru [195.170.219.3]) (amavisd-new, port 10024) with ESMTP id 9O2U794IyksP; Sat, 28 Dec 2024 22:48:02 +0300 (MSK) Received: from mail.cicgroup.ru (unknown [195.170.219.74]) by corp.infotel.ru (Postfix) with ESMTP id 2B63B7A4B; Sat, 28 Dec 2024 22:48:02 +0300 (MSK) Received: from mail.cicgroup.ru (localhost [127.0.0.1]) by mail.cicgroup.ru (Postfix) with ESMTP id EF81142211F; Sat, 28 Dec 2024 22:47:54 +0300 (MSK) Received: from mail.cicgroup.ru ([127.0.0.1]) by mail.cicgroup.ru (mail.cicgroup.ru [127.0.0.1]) (amavisd-new, port 10024) with SMTP id Ry4LfLsAN6Ya; Sat, 28 Dec 2024 22:47:47 +0300 (MSK) Received: from kondratyev.su (localhost [127.0.0.1]) by mail.cicgroup.ru (Postfix) with ESMTPA id AECD442211C; Sat, 28 Dec 2024 22:47:47 +0300 (MSK) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 28 Dec 2024 22:47:47 +0300 From: Vladimir Kondratyev To: Andriy Gapon Cc: Vladimir Kondratyev , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 24ae172a5035 - main - ng_ubt(4): do not attach Realtek 87XX/88XX adaptors in bootloader mode. In-Reply-To: <14efd79e-75be-4f96-8a04-7ffc9ed1012c@FreeBSD.org> References: <202411062331.4A6NVuiE070018@gitrepo.freebsd.org> <14efd79e-75be-4f96-8a04-7ffc9ed1012c@FreeBSD.org> Message-ID: <9f9d01299249b41633a080052ee2da59@kondratyev.su> X-Sender: vladimir@kondratyev.su User-Agent: Roundcube Webmail/1.3.5 X-Spamd-Result: default: False [-1.99 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; NEURAL_HAM_LONG(-1.00)[-0.997]; NEURAL_HAM_SHORT(-0.99)[-0.990]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_NA(0.00)[no SPF record]; ARC_NA(0.00)[]; DMARC_NA(0.00)[kondratyev.su]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8299, ipnet:195.170.192.0/19, country:RU]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4YLCb30VWjz599Z X-Spamd-Bar: - On 2024-12-27 17:41, Andriy Gapon wrote: > On 07/11/2024 01:31, Vladimir Kondratyev wrote: >> The branch main has been updated by wulf: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=24ae172a50352ad4fd22989477f29ecca5aed6e3 >> >> commit 24ae172a50352ad4fd22989477f29ecca5aed6e3 >> Author: Vladimir Kondratyev >> AuthorDate: 2024-11-06 23:28:11 +0000 >> Commit: Vladimir Kondratyev >> CommitDate: 2024-11-06 23:28:11 +0000 >> >> ng_ubt(4): do not attach Realtek 87XX/88XX adaptors in bootloader >> mode. > > Perhaps this change deserves an UPDATING entry? > > Today I upgraded only to find out that my bluetooth related things > stopped working. It turned out that ng_ubt didn't attach to my USB > bluetooth adapter. Definitelly it deserves an UPDATING entry. I did not know that such an adaptors exist. I do have only couple of BT dongles and both of them requires external firmware to be loaded to operate. I think it will be good to print a hint to user if firmware file is missing too. I will add both after ruturning back from vacations in a month. > Only then I discovered this change, installed the firmware package, > etc. > > As strange as it may seem, previously my adapter worked without > uploading any extra firmware. > > Some data points, just in case: > idVendor = 0x0b05 > idProduct = 0x190e > bcdDevice = 0x0200 > iManufacturer = 0x0001 > iProduct = 0x0002 > > rtlbt_is_realtek: found USB Realtek > rtlbt_dump_version: hci_version 0x0a > rtlbt_dump_version: hci_revision 0x000b > rtlbt_dump_version: lmp_version 0x0a > rtlbt_dump_version: lmp_subversion 0x8761 > main: loading firmware /usr/local/share/rtlbt-firmware/rtl8761bu_fw.bin > main: loading config > /usr/local/share/rtlbt-firmware/rtl8761bu_config.bin > main: Firmware download complete > rtlbt_dump_version: hci_version 0x0a > rtlbt_dump_version: hci_revision 0xdfc6 > rtlbt_dump_version: lmp_version 0x0a > rtlbt_dump_version: lmp_subversion 0xd922 > main: Firmware download is successful! It is obviously that firmware has been upgraded but I do not know benefits of this action. Also May be some some values of hci_revision or lmp_subversion means "Firmware is in operationl state, not upgraded". May be no... > >> Attempt to initialize FreeBSD bluetooth stack while such a device >> is in >> bootloader mode locks the adapter hardly so it requires power >> on/off >> cycle to restore. >> This change blocks ng_ubt attachment unless operational >> firmware is >> loaded thus preventing the lock up. >> Sponsored by: Future Crew LLC >> MFC after: 1 month >> Differential Revision: https://reviews.freebsd.org/D46738 -- WBR Vladimir Kondratyev