From nobody Fri Dec 27 17:40:16 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YKXnw3SHHz5j5PV; Fri, 27 Dec 2024 17:40:20 +0000 (UTC) (envelope-from garga@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YKXnw2bDnz47RC; Fri, 27 Dec 2024 17:40:20 +0000 (UTC) (envelope-from garga@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735321220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4eX7TDliJeAGrADhFvRWsbgEHy9pKnHkimwdgQqw7vk=; b=jCjsteL1LqmKhNhrROl+QrT/+xocZZMWlplPqfq2ko5EumOREX70LfWC+y2smhWskVNgjD SSbzwK0obag/QdlqkHvTraxzmJrKc4rXPzg9tlvEbEXz7pzsxJ67Ju5UR/zYE7N9Q1NZpW JUOAfWa79rPZPSkJqyQMJXf02t9To+46KyLAJNaZqc2aQUOi04fk2Kha85xoFxq+Ag3v3s SkBnFFMGRS03JVdxbImGxSWlVi2MLnA1ItaX1cswwCcbbjpsenveWylxT4b/ea4InoA02H dfM1GJOUOGVrvTfxIPNlCJ6vIlr+yY8aHu7J3w7980rVzVGl2YEkQECgzSM35w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1735321220; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4eX7TDliJeAGrADhFvRWsbgEHy9pKnHkimwdgQqw7vk=; b=pObuOsEzViLRtVh3zDrCjdWNXVNT6wsXVGKP97SvNpzqCHKBDelBZwgJfSt+OvksOa0Ujr 3AZSf7f7WJTL8x1D22DSXnj1X603KipA5TlF0aqeVhZTqWlQPg1Ja+xc93A1oai4MLM5oK Q4tV7w9HZ82zjlJUrF8vFFmaCai1Wgi+kLC/qh0u7CL45PWiRA+N6ZsKp8VEvokJIuhk1N kh4+J7jJsKG9E8R9atp+LrKDcfLa4Sul/6mGSw2mxaCMiOUY34+mrRZqD+T3YpZmZDDUc/ vocvIEa+2P3wtR40VKVqUJFuRXTJW7RhaiVa0kvsW43q2fgRA/CI0ryaTHEs4Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1735321220; a=rsa-sha256; cv=none; b=GR9ir12OwpiMZCI2+teIvJbkv4zbXYvOO/RzLQDomkoUWB0b+0eMhIFUsBJU7G839wnm1T lnT1qd5SYBQ1+8UTj/NBwpiCcx9WwxxjyRHeHvfFWGWGu/9KjkWhaB0i3kZTnvQYRuA/oI V+15uHZhlXUGYAfe2gtvBU9gDxI4jBFbyrospNjI+eLLlMNRiVG4k18P2Yt6A42vhn7Mkn dsTHF+k47uIbq4bJ3GGEh+CLNw9Cn2HiXdvLDkIYdiOjj/JHLkDN3h/LtTNC4TNkAa8pzU EiGFjVkwYbG9LvwLlQYMWCBKK6bdL/sPoY+v3fQXjzBBWNOtcYLftwdlfSIkag== Received: from [IPV6:2804:f1c:31:cc00:f541:9717:f6fd:58ab] (unknown [IPv6:2804:f1c:31:cc00:f541:9717:f6fd:58ab]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: garga) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YKXnv1wH3z11yy; Fri, 27 Dec 2024 17:40:19 +0000 (UTC) (envelope-from garga@FreeBSD.org) Message-ID: <1aa3fd17-c566-4432-8d30-3b412970f237@FreeBSD.org> Date: Fri, 27 Dec 2024 14:40:16 -0300 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: git: ba1904937d9a - main - acpica: Extract _OSC parsing to a common file To: Kristof Provost Cc: Andrew Turner , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202412121819.4BCIJ1KW097190__8805.67587898753$1734027579$gmane$org@gitrepo.freebsd.org> <149116bc-677c-47b2-9ff7-f454418fec21@FreeBSD.org> Content-Language: en-US From: Renato Botelho Autocrypt: addr=garga@FreeBSD.org; keydata= xsBNBGStavwBCACjNlp/9+Y+VFe9ieR2h/WWbdvjz4Mb2z/f22bGoaskzCfvVNbo/v3i34I9 H6OdgZkGqheQEAD2jNfRbmPr4z40xDMUpYGLds+1Mvg7G3Hms3j5Ef8KaLSWUNWIfwKdfSVR Qs35ccSJxAdRW5YdI6J3xZgika+3Bc4eJ05YE/nWW+PNTYevt5rqD50N3zybVYIcLoqVPpBi AZE/sf5SLiLACIJb1t/s4x+pi8vgWevxVVT9u8V1f8zYErmHSLSqjxii0B3eRZphX9NCJOv9 +tfFZhnENInhn9gT7H4e2YumUltEy3jacONHJF3CC1pvvWEa6lEyypclMOkHQwNON7DLABEB AAHNLFJlbmF0byBCb3RlbGhvIChGcmVlQlNEKSA8Z2FyZ2FARnJlZUJTRC5vcmc+wsCXBBMB CgBBAhsDBQkFo5qABQsJCAcDBRUKCQgLBRYDAgEAAh4FAheAFiEERL7Dxegbnh7xTiQ5Ob6P xxJcZXoFAmSta78CGQEACgkQOb6PxxJcZXrYlggAgaZmr6c1yIWzN8VksHrHpwt/uxONEP+h ljy3yfrMsgfS5wx5Uzgfih1xYZUFC6jiI63CetqBqJpp3g1klRS1UWYKx2NeXphDMYZEdPm/ a6sXh4bKZbk6IE8Yn0/YiRT57d9DtbvswC7Gn7Igj/MSbhl49TvTGyvuB6juaffVoYZViomx 5zMoee8Ml2o2qj3MrCJ+/K8GU54RlpOGqGRsqdwVdr9XEWub6fF2YFwR46cjmbiU3P5urFHH nkJlBGPIwKxHimTW0lZsdx9aCKRDd/D80/WOEzXmk3k8B9lv/GsvOluHmveLhJG1R1tIJ31I f2q8dfTvqsQXnu8CcWRcgc7ATQRkrWr8AQgA1DufoxScA+CWQbUR6zExIu8wXQKrhuRt4DG2 BgynT7EMUvEBadcbQRZXsBpemNfncc9Axyut/+rWiyKJf9BLQuo/9QYmSRvW1U6+0LJUYmdg kMyBeYaPk+vnssv/u9jLuvV7FVgyE0yk1iaWIKOVDD+XrQCOvGw9uSceBrQyCyo3A/eRM/+p vnDCaywR63PKE+3axk6lfNdGK3TnaWmS30/ZDCZlNsXuqprqR4JdT5wXids5o36dsuJ5EZ20 s5hNMD34s4Yr1Y1R9elH6qBsFCpozs0+jwrArxq+UJJCR6hH5W8ZEwJtRC8tzR8mRE1WywzX BXYj0YhfGztQIxZckQARAQABwsB8BBgBCgAmFiEERL7Dxegbnh7xTiQ5Ob6PxxJcZXoFAmSt avwCGwwFCQWjmoAACgkQOb6PxxJcZXr1vgf/SKXhoZcUU5I7TqcbHg0lJz9tICTupCGHWr/s SQgjh9oEM5j1wqW7FlCGP90Tl9K0g3ow9YdbhU7VK470o6pymX9V9eLHzGgkZO/KMEtGBeK1 u+5ePjCJ/MK5B21KODLSU7WrIL1VN5ceXfQPLYt02LMLtPri+oduHD6RNBeA7US1DUzleq5F 9NHGbvV2U7BdDUezpiO8NaFjFZVB11I5d99FxUM5XGVstI3VhsRKZxjY0KnqJzaQgTFsPGmv AUfZVIN1pXgXiedhPXpr8+Y64jP+pHVwpVmh1zYWL6+q3kqFOUVP6c5iiMeoEXZvgJz7x/AC ek3X5gvu8Hpcv+MZIg== In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 27/12/24 14:26, Kristof Provost wrote: > On 26 Dec 2024, at 21:44, Renato Botelho wrote: > > On 12/12/24 15:19, Andrew Turner wrote: > > The branch main has been updated by andrew: > > URL: https://cgit.FreeBSD.org/src/commit/? > id=ba1904937d9ae0539e39001467a1519b17177118 cgit.FreeBSD.org/src/commit/? > id=ba1904937d9ae0539e39001467a1519b17177118> > > commit ba1904937d9ae0539e39001467a1519b17177118 > Author: Andrew Turner andrew@FreeBSD.org > AuthorDate: 2024-12-12 16:29:45 +0000 > Commit: Andrew Turner andrew@FreeBSD.org > CommitDate: 2024-12-12 18:00:22 +0000 > > |acpica: Extract _OSC parsing to a common file This will be used > by pci_host_generic_acpi.c so needs to be in a common location. > Reviewed by: imp, jhb Sponsored by: Arm Ltd Differential > Revision: https://reviews.freebsd.org/D48044 | > > My dev system was running CURRENT from Oct 31 and broke after I > upgrade to most recent version on Dec 20. After bisecting I found > this commit as the one that introduced the problem. > > It starts booting but can't found any disk. Pressing ? at mount > prompt shows nothing. This system is a VM running on KVM and I've > attached dmesg from successfully boot > > FreeBSD idaho.arrakis.com.br 15.0-CURRENT FreeBSD 15.0-CURRENT #22 > n274182-938e4b131c4: Thu Dec 26 18:10:12 -03 2024 > root@idaho.arrakis.com.br :/usr/ > obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG amd64 > > I’m seeing similar boot issues on VMWare aarch64 (i.e. freebsd in VMware > on a Mac). My bisect pointed to: > > |commit 1f5c50a8617355758510675cb9412f56fed12efc Author: Andrew Turner > Date: Thu Dec 12 16:30:39 2024 +0000 > pci_host_generic:Add pcib_request_feature on ACPI In the ACPI attachment > add support for the pcib_request_feature method. This uses the common > _OSC handling. Reviewed by: imp, jhb Sponsored by: Arm Ltd Differential > Revision: https://reviews.freebsd.org/D48048 | > > I’ve not yet been able to capture a dmesg, but it looks like the nvme > storage device just isn’t found, leading to the zpool failing to mount. > > I’m currently working around that with this patch: > > |diff --git a/sys/dev/pci/pci_host_generic_acpi.c b/sys/dev/pci/ > pci_host_generic_acpi.c index 1ff3a6bda707..c990edf26a3c 100644 --- a/ > sys/dev/pci/pci_host_generic_acpi.c +++ b/sys/dev/pci/ > pci_host_generic_acpi.c @@ -543,7 +543,7 @@ static device_method_t > generic_pcie_acpi_methods[] = { DEVMETHOD(pcib_release_msix, > generic_pcie_acpi_release_msix), DEVMETHOD(pcib_map_msi, > generic_pcie_acpi_map_msi), DEVMETHOD(pcib_get_id, > generic_pcie_acpi_get_id), - DEVMETHOD(pcib_request_feature, > generic_pcie_acpi_request_feature), + //DEVMETHOD(pcib_request_feature, > generic_pcie_acpi_request_feature), DEVMETHOD_END }; | I tried to apply your patch and got the same error on boot. The only way I found to make my system to boot properly is reverting ba1904937d9ae0539e39001467a1519b17177118 -- Renato Botelho