From nobody Fri Dec 20 07:18:09 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YDzKF5JMzz5hW5Z; Fri, 20 Dec 2024 07:18:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YDzKF4WZwz4DXC; Fri, 20 Dec 2024 07:18:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734679089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ciaBsfs8xjADtUYIUDGebnjJiFCChYvCJSCFn0OUIas=; b=o02DiKNSPOKQM4Dt/CJjM7jsPJSLwec2BDxg55yXhqb+oFzsvZaMeImwKSZFEBhtW/iTeb 66ZXypB9fub7Wv6gCeVN82GE4w5SA/seQCnTMPkIB1iPCFFV/ZfrmCl2jk+bhGw1MCMEdH GN2lBRplBp88HNI6Q6k/BJDypO7fbMDtPKmjgdVYNQbodA6my9v4saog5YIiKsFndOnquH sEO2x9TLTA5ha/v9lmB/t/oxZd7YAT6Fzd3C/mT9Ly8RN8/JckNsESpigiOnzIASubxJti //eSELwYOB3TTBXYRX++n1uxDIrYTrE0Gk/n6T6wtG2+CGetusGIXlOr8RSmYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734679089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ciaBsfs8xjADtUYIUDGebnjJiFCChYvCJSCFn0OUIas=; b=S4oFaZBpdYyOOJtG3v/9+gxdODSh2Jb/ePtFVUFPF/PZguxBox+8a1F8Zi3lh5/TQw1efb HxMUT9ieprG9R/QeC0czlxt4UOo3HRz0o5M4HECt9hMXpkzKoRTieKAojTYa2HkIszHUec PfvL2IZ01pMCDV2yZDztklGy2k49FQw2c8nbMf27Q4KWUVQy9zkcLo57K1EGsq1aLPXaw4 Thr56H+u7vODJgbkqSGmSwpIC/uERufVq8lTAAbenDHtrS6u48lQE3Mq80ACE2wnA1vZVJ yn7/nOo5L/0qq/xtkZBqhjdQMdoqlnJZRdO7mkut0z0ZbEEeYuPPgRD41kMQhQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1734679089; a=rsa-sha256; cv=none; b=hpUUO2XWB5rzLVb/L5O6O5tuOCzRxHv/AOOYsNn/lmWjMxL7T9+aYLFkzjgKxgrP9Ji/L+ QM6XqGPbNhbHn7fYgDQj2vwqK7XlzYCiChh2RSgMC4rQG5Zxruqa5kYqmPIORqojCgUbl2 cd79uDRZppDIN79C/QWbc4dZOgyrotW+G78yWl5VeVpdvnNOQ3IynNmJ/yz3kmnwxN6iX1 zQcUh0dWZp0q2oXKS4JinmW+i9ojEUgVPKRpf+Le9K5yggNpQaB8cLxQTeur3fShOHBykL C/nc0SLlWHpOmFjdxWWcEPA/oK7lixo0E86jUT/3Z3OghLnrghuv8DYbUh/vwg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YDzKF3vSPzTB4; Fri, 20 Dec 2024 07:18:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4BK7I9Aj073657; Fri, 20 Dec 2024 07:18:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4BK7I99K073654; Fri, 20 Dec 2024 07:18:09 GMT (envelope-from git) Date: Fri, 20 Dec 2024 07:18:09 GMT Message-Id: <202412200718.4BK7I99K073654@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 7030980bc9aa - main - bus: improve null_add_child() panic message List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7030980bc9aa62aaf25ffab44e24af854c57a9b1 Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=7030980bc9aa62aaf25ffab44e24af854c57a9b1 commit 7030980bc9aa62aaf25ffab44e24af854c57a9b1 Author: Bjoern A. Zeeb AuthorDate: 2024-12-18 21:29:10 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-12-20 07:16:04 +0000 bus: improve null_add_child() panic message When null_add_child() panics add the bus device name/unit and the new unit as this will immediately reveal the parent missing the DEVMETHOD(bus_add_child, ...) entry. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D48151 --- sys/kern/bus_if.m | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/kern/bus_if.m b/sys/kern/bus_if.m index e42dc6d31441..74114ff7baee 100644 --- a/sys/kern/bus_if.m +++ b/sys/kern/bus_if.m @@ -63,7 +63,8 @@ CODE { int unit) { - panic("bus_add_child is not implemented"); + panic("%s: bus_add_child is not implemented, name '%s', " + "unit %d", device_get_nameunit(bus), name, unit); } static int