From nobody Mon Dec 16 15:44:37 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YBklh5gMPz5hbGX; Mon, 16 Dec 2024 15:44:48 +0000 (UTC) (envelope-from olce@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YBklh575Kz4Jhq; Mon, 16 Dec 2024 15:44:48 +0000 (UTC) (envelope-from olce@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734363888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ju4q2fHW0/UzJUuPhQ4EW/lsYVXKYy2AMv/FzAwovtM=; b=NEXRCh6Sd28Qw6ik95GS6DNCPL/+Pu1m2aMmFpfUj6xuIdUubB08RzKYnm2ohqqMiSRlyo vkpknAU5HXXo4XMDkpnBNLqYPvumkA9pfMXAZllGybQbffq/biAN61pDQpu0t8GF4wrlwJ mVF5qW8yomLoU2rHlrCGikBz/n4IVCAaeYsnPZPWhz0dOy1lujFrmCN3DB42Q/4UO8Z4DL 5oIirxM6smVUEJhbZ2iYygXig3a8pb3EL1Hl2UQCJR5vaAZMiwQLkSG7oSSxgRiiA0a+DV dWzI0Y9deyps032j6/3NLcquRw0mMki/pnfdlatM/HPa7ng8Kdt3kdUyro7TLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734363888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ju4q2fHW0/UzJUuPhQ4EW/lsYVXKYy2AMv/FzAwovtM=; b=fs/TTLhNB/+Fmzy9Bz/qmE4D4vQDYPl62K8a4dVtereVQQoxgvuJuUPH0iPMwV6Eq0+4c9 iLvt6x9ZcaKBsOMgC2K7iFPzKhqcd4sDkXYXAcexDMQN3dDon6CmuFDXVK5Pu4+vwBInk9 geu3A44pg16StvQNkDD5ft0FZunBs1CXLfxtNlr0Ys1XGaSZlFhk3e5sgjNTgBansoUgZV qxE+ItGvN9g8akxtfhpu//fu/xnJUTxa+ZlV0aJejGVRdbija3hHeV5V5Am7n9nn4FGRc8 wLKzq3jxQdZ1LiyGgHSA+9mgF+FSXeReb2VPvbQH7TJnFagNfHvyqbtO4KQ9LQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1734363888; a=rsa-sha256; cv=none; b=jQR/oVdMCS6VVnHUi55hgR14wubNys2znqSuPv+i24Wvk+F2ZxK/4KuWxs7Xklne+iQBik 47+zmnwOxxHE93fJjGXUIk5Sn/zneqzPnemIY176YYHVjOxDC2GuCyifpfkbICfyAGpAIJ Ds7DTLsrYF3G7R3h5Bvn24OMWySDHZKVEUNuiE6UyQIiI1TYtrTIXE8F1ch+/wuGwWUcR+ ZLBi4R0XCq4HKUfkD3r6NtYGnx4n6ZkEQr0kYYNiHndN0rLzf8uaJlfs3tB39gWD1ls75/ hxmNvtQESmiZl0D9OVTFGrw2T34MKQOgYahzyIMnfYEkaW9Vvj9h1kgsQ6Xegw== Received: from ravel.localnet (aclermont-ferrand-653-1-222-123.w90-14.abo.wanadoo.fr [90.14.66.123]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: olce/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4YBklg62ynz1CSh; Mon, 16 Dec 2024 15:44:47 +0000 (UTC) (envelope-from olce@freebsd.org) From: Olivier Certner To: Cy Schubert , Baptiste Daroussin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d2be7ed63aff - main - cred: proc_set_cred(), proc_unset_cred(): Update user's process count Date: Mon, 16 Dec 2024 16:44:37 +0100 Message-ID: <2968186.slGk94SIus@ravel> In-Reply-To: <20241216152936.AC31A1AF@slippy.cwsent.com> References: <202412161445.4BGEjYvf052320@gitrepo.freebsd.org> <8184418.bYQgcRI8ro@ravel> <20241216152936.AC31A1AF@slippy.cwsent.com> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3019747.hHqAuc6tWs"; micalg="pgp-sha384"; protocol="application/pgp-signature" --nextPart3019747.hHqAuc6tWs Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8"; protected-headers="v1" From: Olivier Certner Date: Mon, 16 Dec 2024 16:44:37 +0100 Message-ID: <2968186.slGk94SIus@ravel> In-Reply-To: <20241216152936.AC31A1AF@slippy.cwsent.com> MIME-Version: 1.0 > I was just about to push this: Ah, didn't see your mail. Just pushed a fix. > proc_set_cred(struct proc *p, struct ucred *newcred) > { > - bool success = _proc_set_cred(p, newcred, false); > +#ifdef INVARIANTS > + bool success = > +#endif > + _proc_set_cred(p, newcred, false); > > MPASS(success); Apparently, the idiom for such a situation is to tag the variable with `__diagused`, but the change above would have worked the same in the end. Thanks for watching the build! (And I now have one more thing on my before-commit list, since I forgot GENERIC-NODEBUG). -- Olivier Certner --nextPart3019747.hHqAuc6tWs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmdgSuUACgkQjKEwQJce Jif96g/+LTFhLnCChMdqh+uIxuQIER1oWL0fSdSLpHx0wMAMvL0zkz2OyBLXB3ta caatuSsUpyzTe5jPCoWtWcgFzfSZZqdu9z+sYnbI5bxVi9GD3A76z6CjeYGuj4f/ +Dr7XT7xrIhye8GZLjGCLc0rZ+qpYAyOvtyL5kFzJrFfV0Lu35VyN/Bho05X7QMv Yn5zZlKD8PSFXZV302uMQhb4OmlFJG8aGHDyiyf8x5SEJhZtvoTdmAHngNiCYF97 31zRK8CuU7Yu30eG0RCxiBrjK6U9OOlRQGP/sBKna89tctsYJ17nYlNnKlz5PF0r q8QgaKd20ruPHmE10ZGn4ElX+sIAqs7IzyOotd19PVbg+JMMmL4ywTabAGNZqCgZ uETCunLMGje8BzjOVoO1rL25EscPwinQ+fxQvq5vbAUBqNbXeGziSCNbf09vStS/ M3NJoIWua37JsKbLP1sz9z8tAVwN4m9W0oKZIxJrThFYObqmHBM8gaboZzk+P8yo LSQ6YsxRO3bDh6m2492CC9QN//Szm5FVtH629wCzwUVtx8m9PFK38+i1NcHfPkB5 FIKRXKnnGVS8ubaJMG+7pasz255474aX+h0DtkyjK4B9GIPmuBS1JUp+UVrR+XIF 24QD9jk22TD2FdTKpXRMZdWp88Vn8xgxujhqq2qWtXZWOScH8xE= =Nk00 -----END PGP SIGNATURE----- --nextPart3019747.hHqAuc6tWs--