Re: git: d2be7ed63aff - main - cred: proc_set_cred(), proc_unset_cred(): Update user's process count

From: Baptiste Daroussin <bapt_at_freebsd.org>
Date: Mon, 16 Dec 2024 15:24:15 UTC 
On Mon 16 Dec 14:45, Olivier Certner wrote:
> The branch main has been updated by olce:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=d2be7ed63affd8af5fe6203002b7cc3cbe7f7891
> 
> commit d2be7ed63affd8af5fe6203002b7cc3cbe7f7891
> Author:     Olivier Certner <olce@FreeBSD.org>
> AuthorDate: 2024-08-02 15:57:51 +0000
> Commit:     Olivier Certner <olce@FreeBSD.org>
> CommitDate: 2024-12-16 14:42:32 +0000
> 
>     cred: proc_set_cred(), proc_unset_cred(): Update user's process count
>     

[snip]

> +
> +void
> +proc_set_cred(struct proc *p, struct ucred *newcred)
> +{
> +	bool success = _proc_set_cred(p, newcred, false);


This breaks build for GERNERIC-NODEBUG

--- kern_prot.o ---
/home/pkgbuild/worktrees/main/sys/kern/kern_prot.c:2697:7: error: unused
variable 'success' [-Werror,-Wunused-variable]
 2697 |         bool success = _proc_set_cred(p, newcred, false);
       |              ^~~~~~~

> +
> +	MPASS(success);
> +}
> +

Best regards,
Bapt