From nobody Mon Dec 16 14:45:32 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YBjRK6L82z5hWQd; Mon, 16 Dec 2024 14:45:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YBjRK0qDwz4d39; Mon, 16 Dec 2024 14:45:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734360333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xCcb1u6B1o4lT9114pOv5TcjwMxLVDkj7WFwdprStqE=; b=gZR0gsEkmb1Q2CqJ5yYSTefOJ6jtyoRqkbpuIemLmvHErHjGqKKvQv6n/YKf/xxiEu1oQO GBRzxOMaC+LcT7R7D/+LcsxrZ/eMeqW0pL/NPo6eQXxZLHfE6aAS3oH2w74PovWFTMi8Tv dYnKb2zpLhFU5VpXEukjEKGT7qES6J+wZNxSEfEV+rKLBjUP/0fda6MWrpjBhwsHlMXPHI +X+eHikETrS0O9wI8AbQnUc2tqgd3760hIoMCVhREOVdbqhsMnhZs+jfiL8U2Xt6sxEhaG aQfK5eDccnUtHDHcUIWVXPOpKwhEs9dRcJVAUmuok0sUqLjLI54bos5V1kIhzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734360333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xCcb1u6B1o4lT9114pOv5TcjwMxLVDkj7WFwdprStqE=; b=Og3ktgdzWB/Y8qriDvabnfupkRZHjRA0WOUjM2iMPxx9IrTh/UCpJ0/hWc7JWQ+jWsQEbv lBrGwYxSGaP7Ld8tpQGCe1ypOSYrE/WronSAdieCE0KGsRCxTR5aHxG50jB/KWoEiucBnY Xhj/npgrpXL3Y3GL34qxJtefsrMl8JP0W8U0REyRLXNLMwI3NWx93lQi94+ljXdBWZxEvx fmEiuB2Z7Y2VIQEtKd+22PTTbXrVjv0FtW+fzE+fcPs0R9jlRbQ1Chc4k81n6JbxgHdAdI XMEP1dBDOU8NAAAq6IMuRdKQ9WyLDn/tFyjkEG9BJQMdg+SLLyMKdtiXQ+jAiA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1734360333; a=rsa-sha256; cv=none; b=fa0c+Njg3pw4TyzK+FHinE+6QbjH/AOd2jfuVrtTBDq9+jbBAwIVzAXlffNUW9QlGk+Zs2 Ulf8b99eVre1zFIym+5vMNs8yy2mmY97jYaZJ+lvilHP+RRooiwCyfuz2h9jrFW3eEoBvl 5s9hd8oxBTC9FPUinNpw9XVkMxXH4vyj24NydZfgo0biqoXW1VwPYgCcAMUKKIuP9L6ugB Gel27Jb6kY4mTFrBYIVtvFGJ5o1qNhV8b0LiIybmwlxYD9hetbo46aX4NiZbNidgPzJLhv Pkm37HSQZ5+iQgxrw09dwnCji+dEN+RxNotPO5rVo3l8mnU88dkN9HTKUycGSA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4YBjRK0NHSzy0B; Mon, 16 Dec 2024 14:45:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4BGEjWUi052273; Mon, 16 Dec 2024 14:45:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4BGEjWcX052270; Mon, 16 Dec 2024 14:45:32 GMT (envelope-from git) Date: Mon, 16 Dec 2024 14:45:32 GMT Message-Id: <202412161445.4BGEjWcX052270@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 07c9edac7bcd - main - cred: proc_set_cred(): Remove obsolete comments List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 07c9edac7bcd75095724ff3c91d0aeec792a4f26 Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=07c9edac7bcd75095724ff3c91d0aeec792a4f26 commit 07c9edac7bcd75095724ff3c91d0aeec792a4f26 Author: Olivier Certner AuthorDate: 2024-08-01 10:19:52 +0000 Commit: Olivier Certner CommitDate: 2024-12-16 14:42:31 +0000 cred: proc_set_cred(): Remove obsolete comments These have been obsoleted since they were first written (in commit "cred: add proc_set_cred helper", daf63fd2f9a8d040, r280130) by some subsequent commits ("proc: refactor clearing credentials into proc_unset_cred", 5a90435ccfed8e1e, r361448; "cred: distribute reference count per thread", 1724c563e62fa800, r361993). No functional change. Approved by: markj (mentor) MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D46922 --- sys/kern/kern_prot.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/kern/kern_prot.c b/sys/kern/kern_prot.c index 0b15937d13f3..17917d2c3360 100644 --- a/sys/kern/kern_prot.c +++ b/sys/kern/kern_prot.c @@ -2281,11 +2281,6 @@ cru2xt(struct thread *td, struct xucred *xcr) * Change process credentials. * Callers are responsible for providing the reference for passed credentials * and for freeing old ones. - * - * Process has to be locked except when it does not have credentials (as it - * should not be visible just yet) or when newcred is NULL (as this can be - * only used when the process is about to be freed, at which point it should - * not be visible anymore). */ void proc_set_cred(struct proc *p, struct ucred *newcred)