From nobody Fri Dec 13 20:30:27 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y91Dh1nRCz5g5Bp; Fri, 13 Dec 2024 20:30:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y91Dg6V71z4TZy; Fri, 13 Dec 2024 20:30:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734121827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WmNY70qGu7pKm/3H6HKQAcSx2G3CNYt21DApPXQ5v+U=; b=HcaSGzXiuaTKa/3KRfH1Sb4jgwKQNLuvA5igxGTGkDlfKYq8yb6+g7XhoO9PFj/0Z851iE uab7EkGaX1Jj6Ryz8HxVTre6bBzj3eoz1MgMC/rARaZQrcxVHEbfxWXIfS2mJ5HUIjWYVZ RVM1Lxou+ZEUrfGfRrv89pKmoxGdWPHoo01OZXBv+TiI21GgapJ0GpFoNLREZC+FWmJekM 4Z2oGvgIs95h1R1YEkh1epwuClFjpJK50rNAAj/iK/phEkmKFOk6JfAhKK7EwvOBMHs3qC LG6OuogrkcZiNDS3zinDMwGoyJYWFLAVqTzr23McZI/0cCVuvnDXxhDTwIoB3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734121827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WmNY70qGu7pKm/3H6HKQAcSx2G3CNYt21DApPXQ5v+U=; b=b7u+qZU8D596nj9kYbmS4hS/E07a7y/8JUqDIf6jUMADwADxnFKhzd1DLxnyVbq510KNl5 B+tyJOrTYF9mMd81b+7IvPifnY0n99Ag5zTDItOUs9bzsx/uVVTodO+9SbX3/kjhzxw4Sr KdCNxKHv43vH7HEleT8p7HUVj7rEU/5cQoPmMb6f4/oN+CnOdFM9m503eTHW1DEV0ks/jj tzx691sQX3gB4rcIKeS8mrPw60BOER0cqjpWg6B4mOAE0VaJmUBjaN5074sT7N34csM8bu uptI7YmyqSqnBhhYBernRyi7nvL5Zc1QoGFjb0bfNTjH9aCfZc0MshGyySlhRg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1734121827; a=rsa-sha256; cv=none; b=JsEhLLWL/esosbOMtEfkDGGsWps2NQZvSSzlOjnkNZ3rPgbFYty1crJK66mfzv+CdPZ5wk yjDU0HtJ/rWiKcJMJbsQSxK12j0mYBTs0eMIAyt4IhjajVskXDaze7xuUT0MPSUNNqoYV5 7Y+V+csKEAPxZZ6LY6C1JMSAipR/mkMPoFrjzEcz3WI/koSjWQnHgPdkTaXIYm7cR9A8hg pLvK+giP7atzya5BxR9tLuL3DU+Dr8w3V9UDapQ9TTnly3L8OTS5V31BHeQ4qqLFsk/TOx 2+c2da2rRGfAuzkVgjbCl7UNOyGPdTVBhAwfVB4q+dIKRtFsLoUuO8VxtSxtHA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Y91Dg5zfdzsMc; Fri, 13 Dec 2024 20:30:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4BDKURsP041344; Fri, 13 Dec 2024 20:30:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4BDKURIE041341; Fri, 13 Dec 2024 20:30:27 GMT (envelope-from git) Date: Fri, 13 Dec 2024 20:30:27 GMT Message-Id: <202412132030.4BDKURIE041341@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 926905796749 - main - linuxkpi: Fix a lock leak in lkpi_sta_scan_to_auth() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 926905796749750da6464b97ec4f8eec0882cc0e Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=926905796749750da6464b97ec4f8eec0882cc0e commit 926905796749750da6464b97ec4f8eec0882cc0e Author: Mark Johnston AuthorDate: 2024-12-13 20:28:13 +0000 Commit: Mark Johnston CommitDate: 2024-12-13 20:28:13 +0000 linuxkpi: Fix a lock leak in lkpi_sta_scan_to_auth() PR: 283015 Reviewed by: bz MFC after: 1 week Fixes: 0936c648ad0e ("LinuxKPI: 802.11: update the ni/lsta reference cycle") Differential Revision: https://reviews.freebsd.org/D47949 --- sys/compat/linuxkpi/common/src/linux_80211.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c index 44c96909a002..edc3131286f5 100644 --- a/sys/compat/linuxkpi/common/src/linux_80211.c +++ b/sys/compat/linuxkpi/common/src/linux_80211.c @@ -1181,6 +1181,8 @@ lkpi_sta_scan_to_auth(struct ieee80211vap *vap, enum ieee80211_state nstate, int lvif, vap, vap->iv_bss, lvif->lvif_bss, (lvif->lvif_bss != NULL) ? lvif->lvif_bss->ni : NULL, lvif->lvif_bss_synched); + LKPI_80211_LVIF_UNLOCK(lvif); + ieee80211_free_node(ni); /* Error handling for the local ni. */ return (EBUSY); } LKPI_80211_LVIF_UNLOCK(lvif);