From nobody Fri Dec 13 16:53:19 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y8wQ8018mz5gpXB; Fri, 13 Dec 2024 16:53:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y8wQ75w6lz44GC; Fri, 13 Dec 2024 16:53:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734108799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xari2lipuzLqUx0jVo8jAcMFefgmJjnPLZ5j+Auu2Os=; b=UlwbIH3xVMiTfR7QE1ZnRX5jXlTXeTwpvyxTMvlbOKWl/9DuWXAa7bdlFPmLvvazABzZz/ Wd8AEPsrjoRZUiH2tpNgAHj6Knl6BAYq32QoHoh8znXF5+7vJtUgSz+zaoLitzuaTFBq/8 6nzoIpbuPFxLvJY9E4bjmtiozmZyPdd1BmuAzxHNXbAI3pHOfV8BJZC8hiG9nfSw3qu7Il Tl7ATUwx1lIclx/y0LF90odSLsNgdL/TwprFRnbmFsrI6wzdvAA4O03UE6WHlTnmuCcZ9C xFVtP8hhMoELk+Sdnzhq1O/s5HLz6aEFNFteIfAx4hIxVn1uZz63nDy6mIezfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734108799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xari2lipuzLqUx0jVo8jAcMFefgmJjnPLZ5j+Auu2Os=; b=nmbCvr3tqb54y35iIvVpTl0HY95FyjMuo9UdQnmDwWx+rO4x0zUXfW81AgfKzGyqnzFw+9 6bFfi1G+wJGm1j8+WP4ntbZofM3Q+g39S9reRcjGH12ap04nE376nW3OSYXbU1iMCiTM8/ P6BfIYYsC3/XLC07LInt+iSMtBGgXOUuka1W+52s1sPYt0Mur7eJ1zqLnlFC+H1uKokP0C 8ftrD/ej6+pI43IontjQtDmlJiEgcDCIJIJP8ZlNRZp7QwEV2W7zB0eBWvtj11S7FzC5h7 J2JtXNOJPG4CrEOfngiZEKs+VXLvz5WhCYL0t/ig/UIYDwKNWpR6lqyRS/2xfQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1734108799; a=rsa-sha256; cv=none; b=qRXWAO7JyJ4RL2W9ASD1C9M33nL//sCD/9Nt5ge7j2OL8l2T8yzHggdyOSbHVkuilmWWvi KhnjIvLtt6X3ES7a4ShR6i5cvpf6JxjnbNjQhOVYMj7camvNOADCj1vb3OUTBSm/YwllUF 4xUzQaUnPTC/LtQi6Cu/00rzEkel6O4JIwIreunUHxjAawuZ/RqIn46toPwR3vQ2XJDb7N 3skyxB0Qx7ZalGXOV718eW0qWJc9ft7QOjuLXcbV3RUl72LktoooXQeFz++QMnZiK/0Kvh Nr7mJNmYgO9cJMqqwoQdNqoEki3jpXjYslrzhuJNys2wHT3MdZVA57weSIheaA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Y8wQ75QpCzlgk; Fri, 13 Dec 2024 16:53:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4BDGrJVv038612; Fri, 13 Dec 2024 16:53:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4BDGrJlk038609; Fri, 13 Dec 2024 16:53:19 GMT (envelope-from git) Date: Fri, 13 Dec 2024 16:53:19 GMT Message-Id: <202412131653.4BDGrJlk038609@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 7c89253bda3e - main - vmm: Initialize error in vmmdev_rw List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7c89253bda3ea32a9c44104c2d09f86b70195cad Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=7c89253bda3ea32a9c44104c2d09f86b70195cad commit 7c89253bda3ea32a9c44104c2d09f86b70195cad Author: John Baldwin AuthorDate: 2024-12-13 16:52:31 +0000 Commit: John Baldwin CommitDate: 2024-12-13 16:52:31 +0000 vmm: Initialize error in vmmdev_rw CID: 1568045 Reported by: Coverity Scan Reviewed by: markj Fixes: 4008758105a6 vmm: Validate credentials when opening a vmmdev Differential Revision: https://reviews.freebsd.org/D48073 --- sys/dev/vmm/vmm_dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/dev/vmm/vmm_dev.c b/sys/dev/vmm/vmm_dev.c index 4bea4360a51c..4ab99f92f72a 100644 --- a/sys/dev/vmm/vmm_dev.c +++ b/sys/dev/vmm/vmm_dev.c @@ -195,6 +195,7 @@ vmmdev_rw(struct cdev *cdev, struct uio *uio, int flags) */ vm_slock_memsegs(sc->vm); + error = 0; prot = (uio->uio_rw == UIO_WRITE ? VM_PROT_WRITE : VM_PROT_READ); maxaddr = vmm_sysmem_maxaddr(sc->vm); while (uio->uio_resid > 0 && error == 0) {