From nobody Fri Dec 13 14:53:36 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y8sm143jwz5ggt5; Fri, 13 Dec 2024 14:53:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y8sm139NGz4nqT; Fri, 13 Dec 2024 14:53:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734101617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yXSeU/Wtu9rJ/jtnkvTk1qGO46Lsm6MnsdwZIciwAAo=; b=A+S0XjB8c5VvuMsY8OrIlsjxwT3wvWHvamuSVY8KvxWseXueitzRqOgGQawPbdHmFwLSys mlq7PWtbqFbhrYh2mp4raynO37Y+PLJYck2tB1dOkFSM80bsy1BK5KhTzL9QLT+mCm75lb Kgy3kUGFegBCPRNttNpMRCb9ughKmlB3ryshD8zqn9FOCeSxhhiUMO6Q06r+EB9tudGsgu pKwFm/YOyfhK04TDYq1kIJYvJaD6SloQyfpPG6r1khaOSwhywk4jeyFePVuabSV6Xwm4Wp U72AZ8lW6MqTSMW8MG3yibGSzjgEW57tKOs65frBBOAAvQZZl5ujfbNl7UpRIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734101617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yXSeU/Wtu9rJ/jtnkvTk1qGO46Lsm6MnsdwZIciwAAo=; b=GAMaz0xPo+ug/qEX1jiaHAz9srFi+es6QEONR+aVf8xAlEuF/udqc2hBqtDCgJ2BvmERD/ nuZS4Cpp8EjroqxWtxULt6AJWfGqws5lhwROQyCw6pI5CzRqjvmsdWC0cS+qzXVrNl4mHN FTvRESmJ0HuOojUVXSQWUGGrmGb4WKa0848E34lQKDnxHp59LpqtTgxks3nwClsJpSiBy7 YvV7Z+GYxFONYqOsKf3OKeVcjkhcCBOcDVmy0dXw6O+Zdm4Boeb6C4RnjC1fkQunB3J2OG VDRleaD60h9zOplVaPg1vTK61UYExjiB4q6gqUS7OZ6T+hZ9OeDgB0WJQ29fzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1734101617; a=rsa-sha256; cv=none; b=buIiAFoEH71DwqZpb/Wu8BQYmk7SxCswYIKgVib0t/AA2HJMbFxKCzA43jGV7PuZzh0s20 EksCxIV4EGbnFQmgy/RATaiiMyzDUGwqcf1VRM71+Te1b7u7UiE0Z3fvsNHtoCAOQZuRqb Fqmgq4BGdS3YQxdnGcfzw0+7NWmeWjgJmlMv6/mw1jPY3dDlVX3nUw1khNMSM3PhI5hAjo 6lAt8RG8UP7D5FBhwRDVZytC4TqaavKX9sZDGvOBvmLzuRyLHH/EU1+rYD0g1wZ7sP9n9T 0pqP0zKEID2R9cMVRmqDjfZ69JI+WR5s1AgyLwM1fkzCyrHpmn51Hz7gZyQtsQ== Received: from [IPV6:2601:5c0:4200:b830:1582:acc4:74b1:890e] (unknown [IPv6:2601:5c0:4200:b830:1582:acc4:74b1:890e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Y8sm11NP5zb2N; Fri, 13 Dec 2024 14:53:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Fri, 13 Dec 2024 09:53:36 -0500 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: a1097094c4c5 - main - newvers: Set explicit git revision length Content-Language: en-US To: Ed Maste , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202412131306.4BDD6bxu011253@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202412131306.4BDD6bxu011253@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/13/24 08:06, Ed Maste wrote: > The branch main has been updated by emaste: > > URL: https://cgit.FreeBSD.org/src/commit/?id=a1097094c4c5d810287aca092f4ab5f9f86a426a > > commit a1097094c4c5d810287aca092f4ab5f9f86a426a > Author: Pat Maddox > AuthorDate: 2024-12-13 05:28:18 +0000 > Commit: Ed Maste > CommitDate: 2024-12-13 13:06:10 +0000 > > newvers: Set explicit git revision length > > The --short flag is configurable. Setting an explicit length supports > reproducible builds. > > Signed-off-by: Pat Maddox > Reviewed by: emaste, imp > Differential revision: https://github.com/freebsd/freebsd-src/pull/1547 Hmm, this seems to defeat the purpose of the --short flag. I think if you want this to be reproducible you just need to use the full hash. If we get enough commits that git thinks we need a longer short hash, then truncating the hash to a shorter length here is a bug. -- John Baldwin