From nobody Thu Dec 12 18:19:02 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y8LMW2Q0Bz5gZnH; Thu, 12 Dec 2024 18:19:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y8LMW0LmWz3xDw; Thu, 12 Dec 2024 18:19:03 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734027543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ewKvno5+GgvbJSABk+ZgLfX73wIeha7cYJU79GKLRgI=; b=f0YfZQCtEVAActndtQXYAUB5Cop8fHDnjvPqzw3BAlfQcvkHy6esGGbabarCVoWIJzsQCt NU3zcsIE0zoQ01fu8UtgdvykRWw0wDJTLTv7ojlEvgU7cCAnHqZCPlO95thmTzdK0+pu2M AFq4iIV1OExMxvCegtIvRT7HzFl+WJCdHFmtbSH82phSKYDqpX+8HHsUZ5L27aJYdKXY92 FKgnA6sv7vatcaWgOn9k7Qxt6hU3Oy7SFCqwIDe/DQ3nXtJmt2995X0JLF9Vcae9IaREv9 FxATbRZVXTD9krFwCGT7cbUNz/qx4D19C0qOrAlZX6u9fjBfCT6iMiddjB6aiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1734027543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ewKvno5+GgvbJSABk+ZgLfX73wIeha7cYJU79GKLRgI=; b=J1t48lem97GhXpnq1ngJWLv5ehAits67McuNRn9/SlcJ7ZIhFrisJuxf402axE7ava915U G2F/aWxjhpu/RjcRzJCII4B1zTVnflWBODv1tMupCsk4ojOLbTK6atcKqJdQlWict0hBdn u7M0w5zPRElSO6svBMMeEyen5tMuZFG7rvjeAklm2848JoQJjrBcY6DYxpr/7LbUrzYHAX cKvxMhNJPOqr6UpTzsm4x89qCvmW/eEWWSq0ZSY9FrmTD9UbKAZAs13PWcMKod7HktK3HF w7ltYD9Xj1QlBOKtlLmEeABAolz/MsOhSspkIZLzu6WhAQtFe+b6QL3aEyHXtw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1734027543; a=rsa-sha256; cv=none; b=WeSmFkx9jlI/638cm1OJQ9kIZbYuECgs3C4QGnD1wrzttuAkVLXWlleByw0dyIaQr6DTVW nNMViCYbFdgcYC4nj9/ilSyb/x7/V9IWJfxYb2MTh8290ZLuiggjfR25K9fqnPQjLDruSt fozAfUXCaidTZ9e/pC20UUJGMszCuQlJKHFrIBeZzHs/+BArfF82q7W0Su1MtG8NiyqrtN xXjs96mNsjPsyqO5HxvbvJ//ozFHbj8jNgT1YSAlrBZK2hFq4Qt9q69Zj3fD2XJ0XDbHFA 7Bf66r9Uuq2HRsv+4w8Uk2hi9CmFLJlpkPACXCHewDFR3ipX50NhXMbR9rogVA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Y8LMV6zY3z13Z4; Thu, 12 Dec 2024 18:19:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4BCIJ2LB097244; Thu, 12 Dec 2024 18:19:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4BCIJ2fN097241; Thu, 12 Dec 2024 18:19:02 GMT (envelope-from git) Date: Thu, 12 Dec 2024 18:19:02 GMT Message-Id: <202412121819.4BCIJ2fN097241@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Turner Subject: git: fafb43abd0dc - main - pci: Use a switch statement when reading ivars List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: fafb43abd0dcaf2d36ec7344f46e7e19c42be888 Auto-Submitted: auto-generated The branch main has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=fafb43abd0dcaf2d36ec7344f46e7e19c42be888 commit fafb43abd0dcaf2d36ec7344f46e7e19c42be888 Author: Andrew Turner AuthorDate: 2024-12-12 16:30:02 +0000 Commit: Andrew Turner CommitDate: 2024-12-12 18:00:23 +0000 pci: Use a switch statement when reading ivars In pci_host_generic.c use a switch statement rather than a series of if statements. Reviewed by: imp Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D48045 --- sys/dev/pci/pci_host_generic.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sys/dev/pci/pci_host_generic.c b/sys/dev/pci/pci_host_generic.c index b47a90348388..e9a9e99b4b17 100644 --- a/sys/dev/pci/pci_host_generic.c +++ b/sys/dev/pci/pci_host_generic.c @@ -369,13 +369,11 @@ generic_pcie_read_ivar(device_t dev, device_t child, int index, struct generic_pcie_core_softc *sc; sc = device_get_softc(dev); - - if (index == PCIB_IVAR_BUS) { + switch (index) { + case PCIB_IVAR_BUS: *result = sc->bus_start; return (0); - } - - if (index == PCIB_IVAR_DOMAIN) { + case PCIB_IVAR_DOMAIN: *result = sc->ecam; return (0); }