From nobody Fri Dec 06 13:48:23 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y4Xdz6rypz5gHwX; Fri, 06 Dec 2024 13:48:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y4Xdz6LdZz45P3; Fri, 6 Dec 2024 13:48:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733492903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TZvkq1YkKo2RMmfpmxeQivc3YL2gYR+Cd5iUiZu0wy4=; b=Z67cfQ/+/HfOGS4FimnnQbjFBf2qmmX55//Mmdrxf3EmU9+vjdl/+QZBozfazkr1KzdpKM Fy90TknvadbJ9DIsWZdedeT1943RpmkmLvNDR8sB3wC+Sq0cDHePUgGUMKYCB3UzGmj5Ko V7C6PZ6Dps8W15wYQAQfJ75NP+nRI3qQ2winESDSAmRawpHlbqf0FD7E3N7es/R9oMtok/ l1sUza022hUBJmW+6wtA6UM3ZKXo/jlalHjtiThxlmRbLO2+ZAW698gdXos07tvPBtjzcY 57ad9ejvt2TJFp842DtMwXFiNePEGaqY0gKcYnBCIrgdvKmejVJmQDdJcEZdAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733492903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TZvkq1YkKo2RMmfpmxeQivc3YL2gYR+Cd5iUiZu0wy4=; b=tb9pQixrvNvy1eNzi17oaoOGW0j2omx5hSt+gnAS2g6v+5Mes5IDLXoRxQwO5ZJiKQLKaC lCtKPnsNXT1PUBpYY3f/dYv8utR9sNciz0kPrBjRlzNN4UKt2CLpIo2D2/DyNcrerAfE1b 9iwLeCYsMqHbP6xat2YWJq455iAvHjXh8IBHJYeuHqnpL7lF6QVQHDIIGjDsu5kH7Lw44S z78eBc9e7OaaSu0yWPkvTmrgcYPYTItLDMKDhIiEkDanJ/VPBvQ0dzYqpQQ5OMBWrdU5bc 7Qe9+y23sOsSI/9REQvwnVZXcxqEwk4HVJFH0l7ROEcnL79on30pthuyOU1dUA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1733492903; a=rsa-sha256; cv=none; b=CWcezajnsk7Gsq5tObKqLpVYUH0lebN4uo6ZrpRhmukuw6mp8eWh+Bm+uaiiw+5gZMoR+R VwNXx2WhmvgOtOzFvNzCa0oTHM0sNdgI4DmWfGkC4fIwYumXag3yUduPxiVD61lRDnfj8t gviknpcvPnzqxH3AjD/GtOmeW8txeQYfHlR6rIl4xsk8yPw9liw9/jHSCblUGze+s1bTic AEoGvGd0dJrpKkTiuGR+ceI7HuTSMAfI1GbiJPBlSkdVn1nm28EfAjWviQkLIm/1mbZeuD GqpKhEGWAIomQNtHI2SzFuFtyXZLNKn4ARDYZJQeT/Z7oKrGjIcuzvgqj4HkBw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Y4Xdz5rF8zfts; Fri, 6 Dec 2024 13:48:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4B6DmNEP002182; Fri, 6 Dec 2024 13:48:23 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4B6DmNYG002179; Fri, 6 Dec 2024 13:48:23 GMT (envelope-from git) Date: Fri, 6 Dec 2024 13:48:23 GMT Message-Id: <202412061348.4B6DmNYG002179@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Zhenlei Huang Subject: git: a7cfcb264512 - main - init_main: Use TUNABLE_INT_FETCH to initialize verbose_sysinit List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a7cfcb26451219d6f4e60c486c855adeea288397 Auto-Submitted: auto-generated The branch main has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=a7cfcb26451219d6f4e60c486c855adeea288397 commit a7cfcb26451219d6f4e60c486c855adeea288397 Author: Zhenlei Huang AuthorDate: 2024-12-06 13:46:55 +0000 Commit: Zhenlei Huang CommitDate: 2024-12-06 13:46:55 +0000 init_main: Use TUNABLE_INT_FETCH to initialize verbose_sysinit It is too late to initialize verbose_sysinit via TUNABLE_INT, as TUNABLE_INT runs at the order of SI_SUB_TUNABLES, thus any subsystems those have order prior or equal to SI_SUB_TUNABLES are not logged. Reviewed by: kevans Fixes: c7962400c9a7 Add debug.verbose_sysinit tunable for VERBOSE_SYSINIT MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D47907 --- sys/kern/init_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/kern/init_main.c b/sys/kern/init_main.c index fed5340695cf..d6056d863b77 100644 --- a/sys/kern/init_main.c +++ b/sys/kern/init_main.c @@ -138,7 +138,6 @@ SYSCTL_INT(_debug, OID_AUTO, bootverbose, CTLFLAG_RW, &bootverbose, 0, * - 1, 'compiled in but verbose by default' (default) */ int verbose_sysinit = VERBOSE_SYSINIT; -TUNABLE_INT("debug.verbose_sysinit", &verbose_sysinit); #endif #ifdef INVARIANTS @@ -270,8 +269,9 @@ mi_startup(void) /* Construct and sort sysinit list. */ sysinit_mklist(&sysinit_list, SET_BEGIN(sysinit_set), SET_LIMIT(sysinit_set)); - last = SI_SUB_COPYRIGHT; + last = SI_SUB_DUMMY; #if defined(VERBOSE_SYSINIT) + TUNABLE_INT_FETCH("debug.verbose_sysinit", &verbose_sysinit); verbose = 0; #if !defined(DDB) printf("VERBOSE_SYSINIT: DDB not enabled, symbol lookups disabled.\n");