From nobody Sun Dec 01 04:58:09 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y1F6T2wDlz5gDHy; Sun, 01 Dec 2024 04:58:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y1F6T1hNzz4D8b; Sun, 1 Dec 2024 04:58:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733029089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EWP79V7FH30BLy/pWTOzTiHRyM/3SgySLo8oo31vP8k=; b=JQF36hNDRwaePPhsNAkTJULu3niTl5+8WYSKuDL9KGJGpghpnZ2SCSUsCch46g2moqA7sP 0wobHhZvHsjwnO7UYvnVeCwY26FuCttO0aYyv+MIxKXo5077naSWFfvS9jDBncUENbAkOy lL6CGjdbQi1FrgCqwuReDk3zcP+tCheNVvtU/YzD8mih+BKP/IPkABv1iWrH47gHosSa/g B3Mu92L7A4GEfo+gQmFAdR5tve5FpGTbkD++M/Qn8zx7IfD808BGQGt1WiqIoH1xV5x4Jc Uzj6+neeZ6byFV4eszY44OrAeR/s2VWs2HKvF8WUqmQOFWWIMpiWBaBjnVh0WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733029089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EWP79V7FH30BLy/pWTOzTiHRyM/3SgySLo8oo31vP8k=; b=KpdhgjQbXe0w430RDrfOA1Q9Zl6w9r0GF4OGdjDSvQRwJ2RcCWt6dXHapHCg/3GtXpP5l4 WtbBxoZGkxX/IGxft8cn+Jwaa77P0jKOrn+UJMLbcoDorHp2bdj4EGKgDCYLeSVjXWbOIA mmp/nflVnP1yq/1jrFKsvZfxCe647ECT8IwW3ttPpyVzPBfyTJMZAxcMw7VytKPSUZzgX8 ddU/lq4Q/kj+lLQsNiGDSb85WtKIdewXBi2Rl2CAluab7gwxDAUrOdTeoCxEX4YuDuZ4d/ Loi0r+LitlayZ22I4myhsvU6w8w215/rQw5RwfdrGRX114S/op75/J43qxiIFg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1733029089; a=rsa-sha256; cv=none; b=pV3TPYyPnjI9B5vUlTO2DkH83YHtgBKzhibKP/wb9+xBg2/T/+QVAqo0SVbl4PmSEFR7gP UygKi7HEfZWhwx0efH+yJDb71PrKl7ShvughAAaSwkm+oTgR3YtrI+akEnmFrPEySKdgr7 Pm/hLyTfa4KUCYRL9FiQSz7PUGMkucCPGA9Kp9L7W+XU0gA5t5vr74c/zHY1R1DJw5rP0m 6Sy0J2tnaKHlsTCLC/8g9kUBcs8nW9N5pW2enAcANOYF0+suz9Euumwrtc5Hl8oM/EUsu0 OC1xPuQdLy++82wkFy1+KgcFRMHu076m2CwBamIxswIKO93utsNKsD0M8t+Dmg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Y1F6T1JtSzdn8; Sun, 1 Dec 2024 04:58:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4B14w9s3098051; Sun, 1 Dec 2024 04:58:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4B14w9ds098048; Sun, 1 Dec 2024 04:58:09 GMT (envelope-from git) Date: Sun, 1 Dec 2024 04:58:09 GMT Message-Id: <202412010458.4B14w9ds098048@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: fba4ef71b71e - stable/13 - Remove bogus detach routines List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: fba4ef71b71e5f3808680f22401d3eab15dd6a4f Auto-Submitted: auto-generated The branch stable/13 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=fba4ef71b71e5f3808680f22401d3eab15dd6a4f commit fba4ef71b71e5f3808680f22401d3eab15dd6a4f Author: John Baldwin AuthorDate: 2024-11-05 01:31:16 +0000 Commit: John Baldwin CommitDate: 2024-11-30 21:48:00 +0000 Remove bogus detach routines These drivers are not bus drivers, and would need proper detach routines that tore down state stored in the softc. Better to just fail detach outright instead of an incorrect success. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D47389 (cherry picked from commit 7ebc7d1ab76b9d06be9400d6c9fc74fcc43603a1) --- sys/dev/gpio/gpiomdio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/dev/gpio/gpiomdio.c b/sys/dev/gpio/gpiomdio.c index 4e835e2c9ccd..1faf8b7e7a04 100644 --- a/sys/dev/gpio/gpiomdio.c +++ b/sys/dev/gpio/gpiomdio.c @@ -215,7 +215,6 @@ static device_method_t gpiomdio_methods[] = { /* Device interface */ DEVMETHOD(device_probe, gpiomdio_probe), DEVMETHOD(device_attach, gpiomdio_attach), - DEVMETHOD(device_detach, bus_generic_detach), /* MDIO interface */ DEVMETHOD(miibus_readreg, gpiomdio_readreg),