From nobody Sun Dec 01 04:57:55 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y1F6C5BXpz5gDLk; Sun, 01 Dec 2024 04:57:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y1F6C3WvVz4Clj; Sun, 1 Dec 2024 04:57:55 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733029075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GPd35OHO24oTSetY4UKFzy8M0m2SG3wZXm0oDmFP6To=; b=aUvTmBi/2yFozotL+bsao7j8Dp4ydlGPwJC+ENd2xkgfHJHhqjxCSkbeB+KLrWu/5beICn ltgQ1tFFDBm/PadAvii2e5vTy0PeavuQMHNjq8htc/knubWkEgZN6iiNrTFyeNX1/mak8Z GDDjEaFBqxM/QrhU6GulbepgLOp5+krCvn39vBl6xOkgp785y06FhJOVInkAs0FqIX1ZiQ eiYNA2pg58y3FBLondurfeiayRFFw5fcbJIpI5fhL5n/5XDx//wPfExuHS3k4Q9gJzIQD1 GbnngeQYa9qC+EMcoX6EeRLxx3+7TiSFSfgarsVNToIMnronGGS4y2Rj2utxmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733029075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GPd35OHO24oTSetY4UKFzy8M0m2SG3wZXm0oDmFP6To=; b=ggfX+G3DyyXAMmLuWx+2az32DRZG9w4Rsp6uAZiU+BUlbNhv7PykLfmA6wtYBtG9BhMemL s/JKDPSG4bxM7J5OMUE7rLqAtWYBP0r3CRhCA99Vm8+o4xPZBPnaHioNkJh84QD6d5obaA yGh91SiY6sdyrUqzbeKQlCG669gb0WbMelnFEv1/jdq4hiQdImEnQRhr3lZMPbpIy1foph NKfCuRTBphS0DBlhX1d6zHlTzOfq34XiWX9SITmgecf0TuvpkppVanE3jtSRo1TymkBdh2 G4NRwVeoJm6JBiA8CQ3d/0sIAOnurGaKklRy+7aOV/c3Q+Lj6PzNO9/+lstLVg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1733029075; a=rsa-sha256; cv=none; b=v4qNW0FRTtmP+NdMzhvkP+28M8IQHEPsfqUn0H32pq6uixL9msYYHGhsFLghIwf+IYLKor q/8oBSTehB9EpsquRMOmPXDpNjzXKCP5bwljr7TEH92B/X97lv1oOJo0LF4thVTc89irJ1 CTg0Y5jRcT92VEKQ/e/ajAOl5YkM1yeVuvNAnW1TDIPwUfVTMepfXuXoBJ9rg/T9s0r9y2 aAqOlA1Awdr8iRfdQAKcZYHvwt3nw67QckYBeBoT2nHdwzW1FhTfJMhXicYgEJhaKMFmo5 xmto3sClBc6NUH4vMNjfwORd65O5N1WQlnuc0sS9/jUNpRxxPvYssRsnwPibNA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Y1F6C37PYzfNk; Sun, 1 Dec 2024 04:57:55 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4B14vtDe097313; Sun, 1 Dec 2024 04:57:55 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4B14vt7t097310; Sun, 1 Dec 2024 04:57:55 GMT (envelope-from git) Date: Sun, 1 Dec 2024 04:57:55 GMT Message-Id: <202412010457.4B14vt7t097310@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 3cc3bfe4ea98 - stable/13 - fixup_pci: Remove unused attach DEVMETHOD List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 3cc3bfe4ea98d5063a907743ca26d1bd5a7339e2 Auto-Submitted: auto-generated The branch stable/13 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=3cc3bfe4ea98d5063a907743ca26d1bd5a7339e2 commit 3cc3bfe4ea98d5063a907743ca26d1bd5a7339e2 Author: John Baldwin AuthorDate: 2024-10-31 19:49:05 +0000 Commit: John Baldwin CommitDate: 2024-11-30 21:39:08 +0000 fixup_pci: Remove unused attach DEVMETHOD The probe routine always fails, so the attach routine is unused. However, this weird driver is really a quirk system for PCI and should be turned into PCI quirks instead. The Natoma quirk is also broken as it should be doing a runtime check either on mp_ncpus (or more likely to see if it is using APIC) instead of #ifdef. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D47219 (cherry picked from commit 1cddce89ce30570d554120af864d23c554cd5d18) --- sys/dev/pci/fixup_pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/dev/pci/fixup_pci.c b/sys/dev/pci/fixup_pci.c index dc1ad448fd36..5bbf293c7c32 100644 --- a/sys/dev/pci/fixup_pci.c +++ b/sys/dev/pci/fixup_pci.c @@ -56,7 +56,6 @@ static void fixc1_nforce2(device_t dev); static device_method_t fixup_pci_methods[] = { /* Device interface */ DEVMETHOD(device_probe, fixup_pci_probe), - DEVMETHOD(device_attach, bus_generic_attach), { 0, 0 } };