From nobody Sun Dec 01 04:57:05 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y1F5G1jbyz5gDBM; Sun, 01 Dec 2024 04:57:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y1F5F3rfgz480v; Sun, 1 Dec 2024 04:57:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733029025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UaHNgcHJmTH8cH7qPzzu/tct+UIOWrcWKd+uWO4CtZU=; b=RIc+dfAwTtjJ3szxUqdDiK+4QrMum6VmG55q3tZzG44PaIhtc7xj35lat0iWwECdse9kUC /ZhgKW7sLXD2CkXjjbrIa2RgZjfb0G4bwsLXToym5oc7gyViqssGc/Nr+Qkcdv0YlOb8B1 DS8xpP1KxOsmwLTmD9HnzLXXXADPIAAJdqlrSBWjmhjHL3Is0kLigIs8aRwEVFaXQCOULA S2kIz9PASKCyHyEjWsP27wQ90L7qc7xuIvrJ+vI/y88LvRUJczxK/nImWKfMM1QUPt2U1C y/D4FDO3OgNECa93+ytO39ND6Cgv2+hPYKvGmOM0bAs6iiMspUZWFSfG32tivw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1733029025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UaHNgcHJmTH8cH7qPzzu/tct+UIOWrcWKd+uWO4CtZU=; b=HhzcJPJ8ihlXXUqz2zXO7/cFtwOCBhQ5Iod9ZbVENaMGbwcR4HNlI1+lYgLk0EV7chC1uM egSIZoep8v2Rf+aFdfPHQddiiEtQKrrexTaerswLeCC4KrsiaHw7GniubAXAKiD5rH9PQf f8CLtrO9MGt/9QRn2mX+NV6atA1mDelJvlZloy90C/aH0PrnyOLeQvshTPXcnooASEv0Ok UJ4q2J3Enalo0QpKuCplMgXvLkOnYEA+/YqvIpQjezh0PlflPEUlLHA2n6Z2gkRGNIN3AQ XylKf/kH9D0EViq1frq1joX5U2CfBn14tRgvEoxjlSZlbCCBTyOP4D9yREBd+w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1733029025; a=rsa-sha256; cv=none; b=rnCTCvIR6fDaWxWR85MWEirxNwbxHe3U4/tGz78K29F+pgDRQQk/hGvxJIyfjzK54bOZFB LZri5AD+QdMNO8tLH9Tvd2Okx7j4FKy5m8BPSabzhWKtxbQlHyIK/cSluhR5GE+2HfeYjj czcjLrrRSECspYEZweFgKtqItQnZu5eu9v2883PWQ4WIxItL7mM3hKAFBkrXTZ/F6/tqyg rP2DaBa7R8J/ew7YJVRMYHTxyQT/+YedtK1Dqjb2DhZbSIwr+hCILXgBQPL1lGDi0WksA9 E9CF5OWTeZPAAtFUo4XidzgTqm1kzSN1IkLb0vxAct30W4uWmtdrLOnZFlfoYA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Y1F5F3SylzfNf; Sun, 1 Dec 2024 04:57:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4B14v5w3094889; Sun, 1 Dec 2024 04:57:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4B14v5Vp094886; Sun, 1 Dec 2024 04:57:05 GMT (envelope-from git) Date: Sun, 1 Dec 2024 04:57:05 GMT Message-Id: <202412010457.4B14v5Vp094886@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: John Baldwin Subject: git: 1f398acbc991 - stable/14 - fixup_pci: Remove unused attach DEVMETHOD List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 1f398acbc9917c2671fdcd128cce7b49b86e6e01 Auto-Submitted: auto-generated The branch stable/14 has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=1f398acbc9917c2671fdcd128cce7b49b86e6e01 commit 1f398acbc9917c2671fdcd128cce7b49b86e6e01 Author: John Baldwin AuthorDate: 2024-10-31 19:49:05 +0000 Commit: John Baldwin CommitDate: 2024-12-01 02:46:05 +0000 fixup_pci: Remove unused attach DEVMETHOD The probe routine always fails, so the attach routine is unused. However, this weird driver is really a quirk system for PCI and should be turned into PCI quirks instead. The Natoma quirk is also broken as it should be doing a runtime check either on mp_ncpus (or more likely to see if it is using APIC) instead of #ifdef. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D47219 (cherry picked from commit 1cddce89ce30570d554120af864d23c554cd5d18) --- sys/dev/pci/fixup_pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/dev/pci/fixup_pci.c b/sys/dev/pci/fixup_pci.c index 5f4e881d5c76..56ee1e93cbe2 100644 --- a/sys/dev/pci/fixup_pci.c +++ b/sys/dev/pci/fixup_pci.c @@ -56,7 +56,6 @@ static void fixc1_nforce2(device_t dev); static device_method_t fixup_pci_methods[] = { /* Device interface */ DEVMETHOD(device_probe, fixup_pci_probe), - DEVMETHOD(device_attach, bus_generic_attach), { 0, 0 } };