From nobody Fri Aug 30 07:30:45 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ww8vT5mwDz5TG2s; Fri, 30 Aug 2024 07:30:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ww8vT5Hj5z4Lwr; Fri, 30 Aug 2024 07:30:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725003045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/q1dC5AweX4CWbp5MYOKaG/GQ28fSh4/nnknoKHVFzg=; b=IWBSqdY8hibYe94Jm7Nw5IW7UtPosP5tND06+fSzP0pi0+mOKr5Xd0cJOJiHCY3nCnOWYd I9Ls3k5yERgXHmL6O0+iMouApHzGYSa4qnAaKnlEwFZ0XUGU+Mvo9yKstndgobuQdfWjIL +g8s1zvKcWAun2wgX3DlhsiFRWdXT0bYxjvXo3v20LkZ86filUL/fAnorgaOEUCYp/FRtr 8u1qcFWWfDCVA9ps6z3JWSUXzu38b2sf2VQj0cJCPxmIEUf/5fpZrhfIF/sbAUVOV4UFp9 oHV+ClE/nlXDYEvJrNkQwih3WwpQQTOWdGzZwGxbw5HFeCz2rZACB0Ha3JpLUQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725003045; a=rsa-sha256; cv=none; b=fBpALQJEz/MksIQsJ5g5iIadkDINPGH00uMiTN9iPNfZVkCuGMNprp85Xy8OxCLNr7BRWA 4+nQMlXRuQcOVuAMatnlXhX+WMAnc+PORks3ZpM9ioRJY7YNrK/CvMJM6RxNRf5WqwFTb9 yIQkPc/JjNRkrQrh0K8bsznQqKtkVFc6DPI9O5YUW0xBl2/6Ny4nKv0n+Or89/mpmLU5/k pk67lVC/Tu0SyQnFuF9S/olEXT3BflbeBqVNhtCpwFaeVRP/BM7LwXmXtP0/zBuGTpe9H/ VMgR6fXY0n9rSE2SteSWRSFccrjbwKiJ0FjWyDu5JquQXNqfx/COpRk6ecg+pw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725003045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/q1dC5AweX4CWbp5MYOKaG/GQ28fSh4/nnknoKHVFzg=; b=BP+W0TR5i7P2jHWPXz4SCUizugV8YCUIRRpgERUxa5RhdJoH8rYZLuR+TqRsOWjHM0ab9C ORV3LUvzPWECvcPxFI3+nkpcKIYGJsB2uPQc2FN+r7Yk90Kv9Q+qOKPn8DKu2fptitZdz/ vv0iFjSeJxaRK5U9KUqPmSb/hr0px81FYsgCbCn8sYUvf0m2sfUzmBsdqr4y2kGKIXwErv Vuv6J0/ZfXBftQEr59d7do1CSZ8AWHaeCELW4jBpCa1M2Q6TI52+ihO/bLVTME6t47RGOd j0S+Be0kb9dwK9o+CdNFwPDSuHhgyBCmqHVyc+DRnapI4Djb1NSZw7kGq8NYEg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ww8vT4rTbzrbw; Fri, 30 Aug 2024 07:30:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47U7UjT9054271; Fri, 30 Aug 2024 07:30:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47U7UjtS054268; Fri, 30 Aug 2024 07:30:45 GMT (envelope-from git) Date: Fri, 30 Aug 2024 07:30:45 GMT Message-Id: <202408300730.47U7UjtS054268@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: b2044c455744 - main - tcp rack, bbr: improve handling of soft errors List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b2044c4557443bbce974101f04e2b465d1bbe769 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=b2044c4557443bbce974101f04e2b465d1bbe769 commit b2044c4557443bbce974101f04e2b465d1bbe769 Author: Michael Tuexen AuthorDate: 2024-08-30 07:26:41 +0000 Commit: Michael Tuexen CommitDate: 2024-08-30 07:26:41 +0000 tcp rack, bbr: improve handling of soft errors Do not report an error, if it is stored as a soft error. This avoids, for example, the dropping of TCP connections using an interface, while enabling or disabling LRO on that interface. Reviewed by: cc MFC after: 1 week Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D46427 --- sys/netinet/tcp_stacks/bbr.c | 1 + sys/netinet/tcp_stacks/rack.c | 1 + 2 files changed, 2 insertions(+) diff --git a/sys/netinet/tcp_stacks/bbr.c b/sys/netinet/tcp_stacks/bbr.c index cf64451f0c87..3f8c749583b4 100644 --- a/sys/netinet/tcp_stacks/bbr.c +++ b/sys/netinet/tcp_stacks/bbr.c @@ -13867,6 +13867,7 @@ nomore: case ENETUNREACH: if (TCPS_HAVERCVDSYN(tp->t_state)) { tp->t_softerror = error; + error = 0; } /* FALLTHROUGH */ default: diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index da28fd25d195..e77604820b63 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -22450,6 +22450,7 @@ nomore: case ENETDOWN: if (TCPS_HAVERCVDSYN(tp->t_state)) { tp->t_softerror = error; + error = 0; } /* FALLTHROUGH */ default: