From nobody Sat Aug 24 01:54:03 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WrKk04kCYz5Ttf6 for ; Sat, 24 Aug 2024 01:54:16 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WrKjz670sz43Lr for ; Sat, 24 Aug 2024 01:54:15 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ot1-x32a.google.com with SMTP id 46e09a7af769-7093ba310b0so1611911a34.2 for ; Fri, 23 Aug 2024 18:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1724464454; x=1725069254; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vBaYW/V9y60UYRAJpmMyhygakvLdafJlMok3ZG+9BKM=; b=WGnaJOMoqK+EX5PFvm3Y8jdBoQUGj1y8afL88TFTth3lG+4WOS236781amiN3OLXA6 NZP2kpvpvGFd7nRym7DDh42/mz89wdEjkV4EeVGg8nijCfje1V03PEb11XB4lx1PIZPZ PH0EjiGS0GO//f/LVNoMne44HTNhej7MkLnbswkpbCidLsVqqIHYNM26TP+ZshW5yBxE XJybiJQy1/jk7Hi9o/lw291GrbXkjwtjh4c81NQ8+a27Ecv/qt9ja2tVDGTTtgf2f3NZ dJqNUvVM117SCxi98az6kFzYNMjWYNf6l8PLL4Qk8ZVYZ749zrE6tZloiUmOVOg3Ma3H TNwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724464454; x=1725069254; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vBaYW/V9y60UYRAJpmMyhygakvLdafJlMok3ZG+9BKM=; b=uJtmyoWmOJRZ0mTIjNvoBzMfBQOqqIIBUEV/LJXcJli6IJwAvfW29XSaNjYNCP34Tx qbydLYzrCuE3FMGMGUgoNjTZWglgmoNbf+tfdULmmUbJSOD0MwMqbVdQXO236K2cjPJW voMxiaIjFHMoGycE+uJaKVl3p5D5t6vEr7jvMoezgQFl5mzGSJJAsMDZfje+XVYOkKUN cQcqkMKFtx6h9OuUqmy4EbrWB5uLfnaYbh6m52YjhzlF7QTX+vwMJEyyJ3tSBxA8AJxH OLHUrj96G6cQ6Ui8yU1CNZFxCFVuwshOo3pY57ECtf/YSS4JNZs5zy5E9zZDtiSvGhc4 dXwQ== X-Forwarded-Encrypted: i=1; AJvYcCUK2rEjNl9AoqZgiIMlJ8oXA5ALJ78HEUpVUmA6ecvlEsE/zzEgjWEYfHrvJfmBTQUb5tRkRta5HXdSoAjsZcT5q9ue@freebsd.org X-Gm-Message-State: AOJu0YwetFriL6xzt8h1WO9McnIeqkt6UtJUewkQWd1VPInzmohkbM71 gWSR0GbsjkrpnEHTO7aWf3j1Q8h0b4awSB4fDLtpmdDt5INShBK7PmAeD0vAjmpp92fRMnp0WDg n9pMqbJvW4uxXk/bsf/v/HNemkex4kRQfcrr6Qg== X-Google-Smtp-Source: AGHT+IFKUfYua5nKyKqPcUeLrlurpxzlPAHDChzwROjS5KaexSpr4CKzWuCCj+YGJHnWsle+OCfK5aBC3qdH6IhkqVQ= X-Received: by 2002:a05:6830:211b:b0:703:67f8:9b3b with SMTP id 46e09a7af769-70e0ec21766mr4184561a34.30.1724464454391; Fri, 23 Aug 2024 18:54:14 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202408222337.47MNbMeJ041064@gitrepo.freebsd.org> <895EA850-1C39-40F6-9710-524C4B7342CA@freebsd.org> <98A87469-0F47-4D0C-8F17-382E664C96AB@panasas.com> In-Reply-To: <98A87469-0F47-4D0C-8F17-382E664C96AB@panasas.com> From: Warner Losh Date: Fri, 23 Aug 2024 19:54:03 -0600 Message-ID: Subject: Re: 101afbc6ee2f - main - loader/menu: tweak for added line To: "Pokala, Ravi" Cc: Jessica Clarke , Warner Losh , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: multipart/alternative; boundary="0000000000003b74e30620642bb4" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4WrKjz670sz43Lr --0000000000003b74e30620642bb4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Aug 23, 2024 at 12:37=E2=80=AFAM Pokala, Ravi w= rote: > > 80x24 used to be very relevant for Serial, first as the typical termina= l > in the 70s and 80s, then in the default for xterm in the 90s and 2000s. B= ut > in 2024, I'm not sure there's many people still confining themselves to > that, but maybe I'm ignorant of why my breaking it might be relevant. > > There's still lots of gear out there which uses RS-232 serial over DB9, > which uses 80x24. > That needs the FreeBSD boot loader to run in menu mode on it? How many 80x24 terminals are there connected to FreeBSD machines as consoles? Or is this some other connection? And can I get a rough idea where they might be deployed? I still need to see if this is an actual problem in 80x24 or not... Warner > -Ravi (rpokala@) > > > From: on behalf of Warner Losh < > imp@bsdimp.com> > Date: Thursday, August 22, 2024 at 19:03 > To: Jessica Clarke > Cc: Warner Losh , "src-committers@freebsd.org" < > src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" < > dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" < > dev-commits-src-main@freebsd.org> > Subject: Re: git: 101afbc6ee2f - main - loader/menu: tweak for added line > > > > On Thu, Aug 22, 2024 at 5:52=E2=80=AFPM Jessica Clarke > wrote: > On 23 Aug 2024, at 00:37, Warner Losh wrote: > > > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D101afbc6ee2f06f77e6886f1f3ffe11= 5c579967c > > > > commit 101afbc6ee2f06f77e6886f1f3ffe115c579967c > > Author: Warner Losh > > AuthorDate: 2024-08-22 23:28:51 +0000 > > Commit: Warner Losh > > CommitDate: 2024-08-22 23:28:51 +0000 > > > > loader/menu: tweak for added line > > > > I added a line to the menu, but didn't adjust so things were a > > line off. Make the necessary adjustments. > > > > Fixes: 7cb65be96d47 > > Sponsored by: Netflix > > MFC After: 3 days > > --- > > stand/lua/drawer.lua | 2 +- > > stand/lua/menu.lua | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/stand/lua/drawer.lua b/stand/lua/drawer.lua > > index a009b78164df..3a462930b86b 100644 > > --- a/stand/lua/drawer.lua > > +++ b/stand/lua/drawer.lua > > @@ -472,7 +472,7 @@ logodefs =3D { > > brand_position =3D {x =3D 2, y =3D 1} > > logo_position =3D {x =3D 46, y =3D 4} > > menu_position =3D {x =3D 5, y =3D 10} > > -frame_size =3D {w =3D 42, h =3D 13} > > +frame_size =3D {w =3D 42, h =3D 14} > > default_shift =3D {x =3D 0, y =3D 0} > > shift =3D default_shift > > > > diff --git a/stand/lua/menu.lua b/stand/lua/menu.lua > > index 0587e5ae6586..ed84360d93b0 100644 > > --- a/stand/lua/menu.lua > > +++ b/stand/lua/menu.lua > > @@ -535,7 +535,7 @@ end > > > > function menu.autoboot(delay) > > local x =3D loader.getenv("loader_menu_timeout_x") or 4 > > - local y =3D loader.getenv("loader_menu_timeout_y") or 23 > > + local y =3D loader.getenv("loader_menu_timeout_y") or 24 > > local endtime =3D loader.time() + delay > > local time > > local last > > Does this mean we no longer fit a standard 80x24 terminal, or does this > place it on the 24th row so just fits? > > I've not tested that configuration, so I don't know. It's my guess it wil= l > be fine. > > I wonder if this configuration is relevant, though. 80x25 is the smallest > text > console in common use in FreeBSD these days. 80x24 used to be very releva= nt > for Serial, first as the typical terminal in the 70s and 80s, then in the > default > for xterm in the 90s and 2000s. But in 2024, I'm not sure there's many > people > still confining themselves to that, but maybe I'm ignorant of why my > breaking > it might be relevant. > > I'll test it this weekend... > > Warner > > --0000000000003b74e30620642bb4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Aug 23, 2024 at 12:37=E2=80= =AFAM Pokala, Ravi <rpokala@vdura.c= om> wrote:
-Ravi (rpokala@)


From: <owner-src-committers@freebsd.org> on behalf of Warner Losh <= imp@bsdimp.com><= br> Date: Thursday, August 22, 2024 at 19:03
To: Jessica Clarke <jrtc27@freebsd.org>
Cc: Warner Losh <im= p@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org<= /a>>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebs= d.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-m= ain@freebsd.org>
Subject: Re: git: 101afbc6ee2f - main - loader/menu: tweak for added line


On Thu, Aug 22, 2024 at 5:52=E2=80=AFPM Jessica Clarke <mailto:jrtc27@freebsd.org>= wrote:
On 23 Aug 2024, at 00:37, Warner Losh <imp@FreeBSD.org> wrote:
>
> The branch main has been updated by imp:
>
> URL: https://= cgit.FreeBSD.org/src/commit/?id=3D101afbc6ee2f06f77e6886f1f3ffe115c579967c<= /a>
>
> commit 101afbc6ee2f06f77e6886f1f3ffe115c579967c
> Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> AuthorDate: 2024-08-22 23:28:51 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> CommitDate: 2024-08-22 23:28:51 +0000
>
>=C2=A0 =C2=A0 loader/menu: tweak for added line
>
>=C2=A0 =C2=A0 I added a line to the menu, but didn't adjust so thin= gs were a
>=C2=A0 =C2=A0 line off. Make the necessary adjustments.
>
>=C2=A0 =C2=A0 Fixes: 7cb65be96d47
>=C2=A0 =C2=A0 Sponsored by: Netflix
>=C2=A0 =C2=A0 MFC After: 3 days
> ---
> stand/lua/drawer.lua | 2 +-
> stand/lua/menu.lua=C2=A0 =C2=A0| 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/stand/lua/drawer.lua b/stand/lua/drawer.lua
> index a009b78164df..3a462930b86b 100644
> --- a/stand/lua/drawer.lua
> +++ b/stand/lua/drawer.lua
> @@ -472,7 +472,7 @@ logodefs =3D {
> brand_position =3D {x =3D 2, y =3D 1}
> logo_position =3D {x =3D 46, y =3D 4}
> menu_position =3D {x =3D 5, y =3D 10}
> -frame_size =3D {w =3D 42, h =3D 13}
> +frame_size =3D {w =3D 42, h =3D 14}
> default_shift =3D {x =3D 0, y =3D 0}
> shift =3D default_shift
>
> diff --git a/stand/lua/menu.lua b/stand/lua/menu.lua
> index 0587e5ae6586..ed84360d93b0 100644
> --- a/stand/lua/menu.lua
> +++ b/stand/lua/menu.lua
> @@ -535,7 +535,7 @@ end
>
> function menu.autoboot(delay)
> local x =3D loader.getenv("loader_menu_timeout_x") or 4
> - local y =3D loader.getenv("loader_menu_timeout_y") or 23 > + local y =3D loader.getenv("loader_menu_timeout_y") or 24 > local endtime =3D loader.time() + delay
> local time
> local last

Does this mean we no longer fit a standard 80x24 terminal, or does this
place it on the 24th row so just fits?

I've not tested that configuration,=C2=A0so I don't know. It's = my guess it will be fine.

I wonder if this configuration is relevant, though. 80x25 is the smallest t= ext
console in common use in FreeBSD these days. 80x24 used to be very relevant=
for Serial, first as the typical terminal in the 70s and 80s, then in the d= efault
for xterm in the 90s and 2000s. But in 2024, I'm not sure there's m= any people
still confining themselves to that, but maybe I'm ignorant of why my br= eaking
it might be relevant.

I'll test it this weekend...

Warner

--0000000000003b74e30620642bb4--