From nobody Mon Aug 12 21:53:23 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WjSv81bHNz5TF61; Mon, 12 Aug 2024 21:53:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WjSv818dsz4YPQ; Mon, 12 Aug 2024 21:53:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723499604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IYXapbmRSQ3HN50WkL9zeBmqhzG5GEPF75+uwPvEfFk=; b=LpXZlsB+qwA1UmK/ILooAQW6xQzmK2dfAiZaSPFnkzftOHwbIq08YpI0hzQ1cLShxs7HPw gIqlB77z6vLvRnEDxPGDhbB68QgbXm+aGYwmTAUOA/TVzy6ZeDlVodw0EQIm4Su6fL8jBB 077sN1BtZoOX03iS4CxQBWKAfrVelx3lBSVlmV/2/SLAt/xbS9VS+d/CGHGLCmy3u3Ap5l PBcFCz6wuH7eaj6G4J9k2W3nqa/CKAwCqZTop1TgNeD6LRosEec5PnI/8N+2QCE/GZWi+o Nbwa97pGd5EXbue68YmNovNXFJvOA5GKi0XhcgDySQHypCh8jXfnh4pzqImGEQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1723499604; a=rsa-sha256; cv=none; b=DaJ3O7VoFSWgUvJyt3xG0arUinHu49Pfx8/ND7sJyZxjjLRyWEROmOeWbn/XmO8H2ANNu6 XBcQNCMZ4vwxKbVxNHXJuiY+DdKw2eSx/WlOVhBY/osXJvin1X5qbkC54zMKcO2gApfXsf WUS0rGBMZV409iaM6/TNSPBKp4542YC5KPJBJWY/hZ9LThwFIM6wU3CBBdk/elv9yJEawf kX92Z6vABey9vqhmtDWZv67CB7nQe643Q3ux2hiVO2oTjTiHXnC3s0JAoLuLBTlF7amd7e oEX9fgVxZCELtuFj1BOA+6QJXgHBGaTd+M/N8RSBeXJSa45OrqYGiN0W4wxA9w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723499604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IYXapbmRSQ3HN50WkL9zeBmqhzG5GEPF75+uwPvEfFk=; b=jNqs+9hvEybWeVTkMwiRvGGYm7+iaWe6nmc5hoHXaZGKgSM6trXC4tcZypEy313GdpXM0p HKyKodqw1QSmrDIuX4kO2EY6X8/RPiZ2DCox+sSemDos2+74tN71UY5cEn//RApy5ilbin fg5eO/0JbK2Tuz3VfWpzreofLYAgMMpPK57049S2GlK1Yh4+Nky9Z2/YhNt7C7MeEFe6xv ibh4eRH85CRxW99UpqkeqkBvfOIQUxxL7w1ppSG9f44T18k4hrNjsy4Hv4wocOXzASMHpr kNuEEN98KQg4t2HLj75CkTZYXWPuKKkdaFKI6zA6hziWmp3FsjoGQrYUfhabHA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WjSv80lGQzkdT; Mon, 12 Aug 2024 21:53:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47CLrOUL052619; Mon, 12 Aug 2024 21:53:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47CLrNuW052616; Mon, 12 Aug 2024 21:53:23 GMT (envelope-from git) Date: Mon, 12 Aug 2024 21:53:23 GMT Message-Id: <202408122153.47CLrNuW052616@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Jessica Clarke Subject: git: 97c31cc80098 - main - kldxref: Clarify ambiguous comment List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jrtc27 X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 97c31cc80098956688a36a173a42b54549350d40 Auto-Submitted: auto-generated The branch main has been updated by jrtc27: URL: https://cgit.FreeBSD.org/src/commit/?id=97c31cc80098956688a36a173a42b54549350d40 commit 97c31cc80098956688a36a173a42b54549350d40 Author: Jessica Clarke AuthorDate: 2024-08-12 21:53:13 +0000 Commit: Jessica Clarke CommitDate: 2024-08-12 21:53:13 +0000 kldxref: Clarify ambiguous comment This previously read, to me at least, as if the not only applied to ending with ".ko", not to the entire rest of the sentence, and thus the implementation looked wrong. The history of D43507 however shows that the behaviour is as intended. --- usr.sbin/kldxref/kldxref.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/kldxref/kldxref.c b/usr.sbin/kldxref/kldxref.c index 122551940ac7..6bb0469a9ff5 100644 --- a/usr.sbin/kldxref/kldxref.c +++ b/usr.sbin/kldxref/kldxref.c @@ -839,8 +839,8 @@ main(int argc, char *argv[]) continue; /* * Skip files that generate errors like .debug, .symbol and .pkgsave - * by generally skipping all files not ending with ".ko" or that have - * no dots in the name (like kernel). + * by generally skipping all files which neither end with ".ko" + * nor have no dots in the name (like kernel). */ dot = strrchr(p->fts_name, '.'); if (dot != NULL && strcmp(dot, ".ko") != 0)