From nobody Sat Aug 10 00:00:31 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WggsD1NlBz5SpTy; Sat, 10 Aug 2024 00:00:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WggsC69xqz54Ft; Sat, 10 Aug 2024 00:00:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723248031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Sqq5HEbjPK/7LxFPBnO1uh89Lr5LpPsrYAmGC+CjqTQ=; b=ZjGpGDuDffQqLFIUkk6ElNRWnfqJMqm2jsEVykMLoP5XN/l+1edn2zyB/KgcqxQsaip5D2 CFLPF6ACwAtrSe4Z9HC6sDh0FNuOVjZNbtsJtONeP2uoKepa+x6yiehTdXe053h8775hN2 QsUxBHVa4IIWY183uokgEmrQkZcE4uamIgFSfIyJhSfxc3yPo40wPk3YrdEQr6Hq1LmPhu 0HqY3QtB+qoFQUVJ6Ot/3ax8tXEIsbFvHzpNFEMhPOo48YmVhaYYUkWz1oLBtATOHNhmYV qB2+1SKR5YdIXaBgDKfuCCNsgPsi56wXihfW1ESv5I2CbK+nD+tGZmx5FjdmqQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1723248031; a=rsa-sha256; cv=none; b=E7dHbht2O5Pi6OG1aUUNOnS1AvB2itbwwqtCLSqH5nrVmdGdT4RbY1NO3s2y+HS2eSZDYB sbdDtxwJmxjHXN1EKnRtMfh4lQuftN134EadtSJiPfT+5C3B3Rb4xEnyw14Z7MriR2r3Sx bMp1YRKAIaM9picnmWYTijkzxyl251E8uIAnq06YsgfO82a2WPyqs1U7QvEjgM3d48CwFh ZM39a7szYICIjPNAdo+C8WPzUPe888qO61PbeGFVuu1hJ4vfvig0lZjul9dt6FOtaJ1GHE YlSB7q4oLO7+iOMaZO2IH1sAQeRWXN8s+O4O8uiaLGVmq1kf271dggmubZHmdg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723248031; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Sqq5HEbjPK/7LxFPBnO1uh89Lr5LpPsrYAmGC+CjqTQ=; b=kGgt2Sn1F72qYVuMA2AtYMiSxiFQ69nLo0f72QhzywdroJIR4X3UE7M8G6tKlf9c4uL/g/ 2WgpT1YD1Q+9h7d433bgOUqLAEBsyHlPIT59AryCMuQK2Q5JPK3xPB2/j8XYuwmbOnMF9A n5VxhsrNGyGw05e/qb17FmTG+zMBCmNS9Rvon8hrp3vymbBnnRInDH3iKv8AMkVwZ04w8k ZeJi5bMK9p6dgsDllUJzVAcH5NqcU7ZcGvRx8bpS5e5DYnpbBWMCJBipdnhzflKLebQgxj 1uW0lrpwhC9jaiItSVvVywUji981GuefUyTzaW4qU9LQOe1wCawfK81x7WxP2w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WggsC5n9mzcJv; Sat, 10 Aug 2024 00:00:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47A00V8C054453; Sat, 10 Aug 2024 00:00:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47A00VGC054450; Sat, 10 Aug 2024 00:00:31 GMT (envelope-from git) Date: Sat, 10 Aug 2024 00:00:31 GMT Message-Id: <202408100000.47A00VGC054450@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Colin Percival Subject: git: 76e0ffd9f8fd - main - dhclient: Timeouts for entering state_selecting List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 76e0ffd9f8fd09f8790a4d96581782225d9019ea Auto-Submitted: auto-generated The branch main has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=76e0ffd9f8fd09f8790a4d96581782225d9019ea commit 76e0ffd9f8fd09f8790a4d96581782225d9019ea Author: Isaac Cilia Attard AuthorDate: 2024-07-08 06:11:08 +0000 Commit: Colin Percival CommitDate: 2024-08-09 21:49:11 +0000 dhclient: Timeouts for entering state_selecting Use the new add_timeout_timespec() API to handle timeouts for state_selecting within dhclient.c. No functional change intended. Sponsored by: Google LLC (GSoC 2024) Signed-off-by: Isaac Cilia Attard MFC after: 10 days Reviwed by: cperciva, brooks, Tom Hukins, Alexander Ziaee Pull Request: https://github.com/freebsd/freebsd-src/pull/1368 --- sbin/dhclient/dhclient.c | 38 ++++++++++++++++++++++++++++---------- sbin/dhclient/dhcpd.h | 1 + sbin/dhclient/dispatch.c | 3 ++- 3 files changed, 31 insertions(+), 11 deletions(-) diff --git a/sbin/dhclient/dhclient.c b/sbin/dhclient/dhclient.c index 62e55eb4d01f..b53a6f6c892f 100644 --- a/sbin/dhclient/dhclient.c +++ b/sbin/dhclient/dhclient.c @@ -91,6 +91,7 @@ cap_channel_t *capsyslog; time_t cur_time; +struct timespec time_now; static time_t default_lease_time = 43200; /* 12 hours... */ const char *path_dhclient_conf = _PATH_DHCLIENT_CONF; @@ -120,6 +121,8 @@ struct pidfh *pidfile; */ #define TIME_MAX ((((time_t) 1 << (sizeof(time_t) * CHAR_BIT - 2)) - 1) * 2 + 1) +static struct timespec arp_timeout = { .tv_sec = 2, .tv_nsec = 0 }; +static const struct timespec zero_timespec = { .tv_sec = 0, .tv_nsec = 0 }; int log_priority; static int no_daemon; static int unknown_ok = 1; @@ -1022,7 +1025,11 @@ dhcpoffer(struct packet *packet) struct interface_info *ip = packet->interface; struct client_lease *lease, *lp; int i; - int arp_timeout_needed, stop_selecting; + struct timespec arp_timeout_needed; + struct timespec stop_selecting = { .tv_sec = 0, .tv_nsec = 0 }; + time_now.tv_sec = cur_time; + time_now.tv_nsec = 0; + const char *name = packet->options[DHO_DHCP_MESSAGE_TYPE].len ? "DHCPOFFER" : "BOOTREPLY"; @@ -1078,12 +1085,13 @@ dhcpoffer(struct packet *packet) /* If the script can't send an ARP request without waiting, we'll be waiting when we do the ARPCHECK, so don't wait now. */ if (script_go()) - arp_timeout_needed = 0; + arp_timeout_needed = zero_timespec; + else - arp_timeout_needed = 2; + arp_timeout_needed = arp_timeout; /* Figure out when we're supposed to stop selecting. */ - stop_selecting = + stop_selecting.tv_sec = ip->client->first_sending + ip->client->config->select_interval; /* If this is the lease we asked for, put it at the head of the @@ -1099,9 +1107,13 @@ dhcpoffer(struct packet *packet) offer would take us past the selection timeout, then don't extend the timeout - just hope for the best. */ + + struct timespec interm_struct; + timespecadd(&time_now, &arp_timeout_needed, &interm_struct); + if (ip->client->offered_leases && - (cur_time + arp_timeout_needed) > stop_selecting) - arp_timeout_needed = 0; + timespeccmp(&interm_struct, &stop_selecting, >)) + arp_timeout_needed = zero_timespec; /* Put the lease at the end of the list. */ lease->next = NULL; @@ -1118,16 +1130,22 @@ dhcpoffer(struct packet *packet) /* If we're supposed to stop selecting before we've had time to wait for the ARPREPLY, add some delay to wait for the ARPREPLY. */ - if (stop_selecting - cur_time < arp_timeout_needed) - stop_selecting = cur_time + arp_timeout_needed; + struct timespec time_left; + timespecsub(&stop_selecting, &time_now, &time_left); + + if (timespeccmp(&time_left, &arp_timeout_needed, <)) { + timespecadd(&time_now, &arp_timeout_needed, &stop_selecting); + } /* If the selecting interval has expired, go immediately to state_selecting(). Otherwise, time out into state_selecting at the select interval. */ - if (stop_selecting <= 0) + + + if (timespeccmp(&stop_selecting, &zero_timespec, <=)) state_selecting(ip); else { - add_timeout(stop_selecting, state_selecting, ip); + add_timeout_timespec(stop_selecting, state_selecting, ip); cancel_timeout(send_discover, ip); } } diff --git a/sbin/dhclient/dhcpd.h b/sbin/dhclient/dhcpd.h index 5d3c6aa6c990..6f1f6679875c 100644 --- a/sbin/dhclient/dhcpd.h +++ b/sbin/dhclient/dhcpd.h @@ -361,6 +361,7 @@ char *piaddr(struct iaddr); extern cap_channel_t *capsyslog; extern const char *path_dhclient_conf; extern char *path_dhclient_db; +extern struct timespec time_now; extern time_t cur_time; extern int log_priority; extern int log_perror; diff --git a/sbin/dhclient/dispatch.c b/sbin/dhclient/dispatch.c index 8a0f1406afc7..55c495179e24 100644 --- a/sbin/dhclient/dispatch.c +++ b/sbin/dhclient/dispatch.c @@ -155,7 +155,8 @@ dispatch(void) struct protocol *l; struct pollfd *fds; struct timespec howlong; - struct timespec time_now = { .tv_sec = cur_time, .tv_nsec = 0 }; + time_now.tv_sec = cur_time; + time_now.tv_nsec = 0; for (l = protocols; l; l = l->next) nfds++;