From nobody Wed Aug 07 13:42:10 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WfBDf1xVTz5S9KX; Wed, 07 Aug 2024 13:42:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WfBDf1TwKz4hQ7; Wed, 7 Aug 2024 13:42:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723038130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Tata4MkNvVXgPfLPelJSchqBwD3pVkeRszcXdu1bBVI=; b=ABW6TKC5Ej+qQCdLdNcvBEzHNTwtvzEB/g/HSAr/rvToc899e0j13ZyapcbCZxHzoW1Xg1 v8zUWbdQpNtu7KQRr9E49k0WIZRuHBBCZ4zSETXf0WQtzKpzOn4VrQxJ5xfStzkQNGXIaM XgH58wMEURihu+ZOjaBEBjbw5+4z6+0fZy0jjJwSYIzRSOyaF1Kknt2Vq5EMZ+U/AR64VR eFxXMWjc6/dc3z4hwlqs4uVWV0cvY/RM5SWypz3gjyns/dfw6VLvbLvfh1BDtwZ/WWC7c/ kR4yfNpN0K4yk/vRaoSrd8liSoYvmd2XD543fAe8azU1B1LfeuXYZ5Sv3SkysQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1723038130; a=rsa-sha256; cv=none; b=oKV61M7yzCnMbFiT7VTuhwZnjIxNAQQLovX2Gr3TrXr2pv7nmlm3kuZDp2PGJlOdHvhlBI tEzHQnZ02uAaIpiFMn0JTuvk0sc3nMTajR60IXVUq2zsa0ofbg13gXihuNVlFh6wm+zgqF j0+zeuD+fF/0kMbLDMLAGtlQ/JtyjgVkRlhRyNRc7D8K+woMvJH0dz4nyrpDhcKTT2tLnA LJLh1ip8p0LSzLV/R1LxYjWGfRjmXFNPWas4OGEL10ca9AqSpsM1sQfpm6KNzCls1lYsM1 ie6LL8vfgzfd5Ze0PCkRwgVl5YPPhbxgCgVriaaMWy0xpGqkmNVjjqTFbprMDQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723038130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Tata4MkNvVXgPfLPelJSchqBwD3pVkeRszcXdu1bBVI=; b=c+ym7wU1HbEa+rOWNmNx2WaRZxn9Rhw2hvPEIf013JSQAwGUk/KXX/9WYb81WSEJ9tCt91 VkJkiyWxpFD3Bt7obLmhbImkhEIQXI2rMqKBKxy7JKmTieXp0O8VtJLO4LqZw3bstK+q8h /as2JFgUy53bYXtJWU9pYj46XlH4kYGF088TRdCv8Kkw9XkJVbZSJ6Q+X0Qr5UsLxL0Gss YLRk0P8D08DpFpMWzuNoyL/mmrRgD8G8bvp/OwSIieh9qxvjA6XODcKQyU5750zO25DJZP 0ywwdWd0X7COExhdwVi/NiwW7IBe4Y/afZf/16+lTF5Evkm2sGImLN+h7ufjxg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WfBDf14jRzsmG; Wed, 7 Aug 2024 13:42:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 477DgAgY032866; Wed, 7 Aug 2024 13:42:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 477DgAJT032863; Wed, 7 Aug 2024 13:42:10 GMT (envelope-from git) Date: Wed, 7 Aug 2024 13:42:10 GMT Message-Id: <202408071342.477DgAJT032863@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: f702110bc4bc - stable/13 - ktrace: Fix an inverted privilege check List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: f702110bc4bcc593b38674ec6e4fadf6c4626432 Auto-Submitted: auto-generated The branch stable/13 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=f702110bc4bcc593b38674ec6e4fadf6c4626432 commit f702110bc4bcc593b38674ec6e4fadf6c4626432 Author: Mark Johnston AuthorDate: 2024-08-07 13:38:54 +0000 Commit: Mark Johnston CommitDate: 2024-08-07 13:42:02 +0000 ktrace: Fix an inverted privilege check Approved by: so Security: FreeBSD-24:06.ktrace Security: CVE-2024-6760 Fixes: 1762f674ccb5 ("ktrace: pack all ktrace parameters into allocated structure ktr_io_params") (cherry picked from commit 166b7573b5220aadf8b02a85933c9651b909b309) --- sys/kern/kern_ktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/kern_ktrace.c b/sys/kern/kern_ktrace.c index 2729d0880b31..cc51dbae46f7 100644 --- a/sys/kern/kern_ktrace.c +++ b/sys/kern/kern_ktrace.c @@ -585,7 +585,7 @@ ktrprocexec(struct proc *p) PROC_LOCK_ASSERT(p, MA_OWNED); kiop = p->p_ktrioparms; - if (kiop == NULL || priv_check_cred(kiop->cr, PRIV_DEBUG_DIFFCRED)) + if (kiop == NULL || priv_check_cred(kiop->cr, PRIV_DEBUG_DIFFCRED) == 0) return (NULL); mtx_lock(&ktrace_mtx);