From nobody Tue Aug 06 04:06:37 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WdKW23ltRz5Sbbr; Tue, 06 Aug 2024 04:06:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WdKW20y4Bz4kW3; Tue, 6 Aug 2024 04:06:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722917198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XRLGexf4rNdB+XjYu++3tYIvFwELAaLEog24bsn9g5E=; b=ikutxVe8zDzdbPKzrFTIrrJUVb7zoCF6mQGdhdD4aUuyu985ykU1ULUJJg9LgJaePmyiBQ W41BA5g5G444UZWrnwtXRY+7Uan0p3IiUMhle0qG/rZXiqRPasbnVpEiio3cOfbm49l/d8 THJ9td8a+f2arKs666JPweETSS4ocWKHhy3ndMfWo+P1mGi8k0EEB8N9ffvKEwo7l2pCf5 1SuDFjZl5ZgaOq72pTt8vo8cSXX6TJLO/1L89JDRAYQosEGa3EfqMJ/JE1zfSJg4vAM8K8 sdxotpj2uErC7Oiz/zntFmBVY4E/nCQgKWENh620VekNPnSLy1tdiSqPJoCLTA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1722917198; a=rsa-sha256; cv=none; b=GB3AD58rNQFq+hNdVg4EeLO6Ysb6B4qQ/5YW2iO0CScmawgtv7vsJh22d26TKkp8fHDxCa f/aQvmDS/8r7KMJDRrvoENs1yp0oUAfTp9yR/C6Eye0cKviOgnwLxxbquXX5LfSa0d9o00 STCMhVLA8mPMMEK8eAc9rFU57Tz814BX6HUGUbg1yBQr/DrDbBUyJZJmjIPkmFfHWIiiG9 6zB/TjzbSsfeCe9435M3VSrKVtjdtOZfbyTr25zBQqsZka6fcvfKSscdpFcklawJVt366T LV7bonoTmdVXI6120nlfbxOpGm8/6EPV/YsytyMF6pwcB6CYSr7/NJIirBaIAQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1722917198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=XRLGexf4rNdB+XjYu++3tYIvFwELAaLEog24bsn9g5E=; b=xw4PAZmA2A7h+OJ08XFyUWds0TxBq2Aq9J/VuEJDkOW3bFtDhiUjZ03FC/Ef8a1F9tRPuF zEPkESe8qRZOK2dGFi+YscZZnKsws5q51LEoOOfvO4Za3JByMjZjy2RKaJl3n/5dYVjOPf rP0/TC0neZCJbQQhqydSrt4df/nM3n167i8DSvNioiy8E6mGUwepr+42jtsW2qvgdw5PAj kpR73k33Mj3W0aYMDrCHH5HXiC5BeL56FqLaeBjP4DXRa0IeXYsmZZsCwCnyeP2OMthj5F +HDS2CAvBA/uTXqSsb4IDAQ8DI9vZaAos6HNeDTqJhIzvO+MQ7SIYtV8JgSbYw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WdKW20MZrzs7S; Tue, 6 Aug 2024 04:06:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 47646bbG004643; Tue, 6 Aug 2024 04:06:37 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 47646btU004640; Tue, 6 Aug 2024 04:06:37 GMT (envelope-from git) Date: Tue, 6 Aug 2024 04:06:37 GMT Message-Id: <202408060406.47646btU004640@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: c31580080e05 - main - Microoptimize rangelock_unlock_int() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c31580080e055573a32d886b1ea83bebd9ef4e77 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=c31580080e055573a32d886b1ea83bebd9ef4e77 commit c31580080e055573a32d886b1ea83bebd9ef4e77 Author: Konstantin Belousov AuthorDate: 2023-10-04 18:55:49 +0000 Commit: Konstantin Belousov CommitDate: 2024-08-06 04:05:58 +0000 Microoptimize rangelock_unlock_int() Only broadcast if there are sleepers. Suggested by: markj Reviewed by: markj, Olivier Certner Tested by: pho Sponsored by: The FreeBSD Foundation Differential revision: https://reviews.freebsd.org/D41787 --- sys/kern/kern_rangelock.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sys/kern/kern_rangelock.c b/sys/kern/kern_rangelock.c index 9c6b7fb871f9..355b2125dd9b 100644 --- a/sys/kern/kern_rangelock.c +++ b/sys/kern/kern_rangelock.c @@ -160,13 +160,17 @@ rl_e_is_rlock(const struct rl_q_entry *e) static void rangelock_unlock_int(struct rangelock *lock, struct rl_q_entry *e) { + bool sleepers; + MPASS(lock != NULL && e != NULL); MPASS(!rl_e_is_marked(rl_q_load(&e->rl_q_next))); MPASS(e->rl_q_owner == curthread); rl_e_mark(e); + sleepers = lock->sleepers; lock->sleepers = false; - sleepq_broadcast(&lock->sleepers, SLEEPQ_SLEEP, 0, 0); + if (sleepers) + sleepq_broadcast(&lock->sleepers, SLEEPQ_SLEEP, 0, 0); } void