Re: git: 5626f9e79090 - main - style.9: Document the existence of tools/build/checkstyle9.pl
Date: Sun, 28 Apr 2024 12:37:48 UTC
Hey Warner, Thanks for taking a look at the patch! > On 26. Apr 2024, at 15:30, Warner Losh <imp@bsdimp.com> wrote: > On Fri, Apr 26, 2024, 3:38 AM Mateusz Piotrowski <0mp@freebsd.org <mailto:0mp@freebsd.org>> wrote: >> The branch main has been updated by 0mp: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=5626f9e790901999def12040a60746b0ceeb9b95 <https://cgit.freebsd.org/src/commit/?id=5626f9e790901999def12040a60746b0ceeb9b95> [...] >> >> style.9: Document the existence of tools/build/checkstyle9.pl <http://checkstyle9.pl/> [...] >> share/man/man9/style.9 | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) [...] >> @@ -904,6 +904,10 @@ instead of the older >> .Fn CTASSERT . >> .Sh FILES >> .Bl -tag -width indent >> +.It Pa /usr/src/tools/build/checkstyle9.pl <http://checkstyle9.pl/> >> +A script to check for violations of > > > Egregious violations and there are some false positives still. checkstyle9 is already warning against those imperfections. I assumed that there is no need to warn against those in the manual page as well. I can add additional disclaimers if you think they are desired :) Best, Mateusz Piotrowski