From nobody Thu Apr 25 22:19:44 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VQVf84h0zz5JgCx; Thu, 25 Apr 2024 22:20:00 +0000 (UTC) (envelope-from maciphone2@googlemail.com) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VQVf827dkz45gB; Thu, 25 Apr 2024 22:20:00 +0000 (UTC) (envelope-from maciphone2@googlemail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-56e6a1edecfso2347469a12.1; Thu, 25 Apr 2024 15:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20230601; t=1714083598; x=1714688398; darn=freebsd.org; h=message-id:in-reply-to:to:references:date:subject:mime-version:from :from:to:cc:subject:date:message-id:reply-to; bh=ascjDHG1rTRggjeZijNFPSN/XY9vjTOU8Ld2NP8MnpE=; b=SaXhkFDsJyy9s0zS63sDg3Mvco6ksFDbYj3eogNWptdOirLWp7QDeVLAbK3dHE/673 xhF47P5pWudXMSBX/TUEoQQMY+yMMyC9AxJjEGkeCQ94reB7CkSQSa82sLQ+E6mAVqJD I7VV+J4dMQybbx9iOcT+RTtkOZCbpu9c/lygBuRgjAFPMjqzpL89zJdNi3rAT5KytIy4 rVDU+qkKKzlHQTo56/wjbPIEyNSNkyWxsquzkUCIfXQ3n9fS6M2T+ivc3rqF35NWnAmt i3Pk4jNErFjOLxnFu5QnCZUx5VH0pn/NS4L2oOaMA7+ZVJ+aYVxY1Pwcz0fs2zIs+NWe //qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714083598; x=1714688398; h=message-id:in-reply-to:to:references:date:subject:mime-version:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ascjDHG1rTRggjeZijNFPSN/XY9vjTOU8Ld2NP8MnpE=; b=wRb8CNqaJyr159hPjiFDZkTVMvcUJS4EH7r3iBVnya/ncBBub/uZcrdH134DTPkEq6 FpTiUwAUA/F5hcZMZ7Hmk3HkIxIui3tAujKU1Ft6J0e2QKUR+loucsF7QwO5QqtnvmAZ y9bi1rDbVxA0bbVRyNBrhsD2POlioz+m/Z490fnH1cQv3V4qG1Yte018uQVankszs0P8 5zoIwv5oRUIIX5OFAoWCS59CZWwHhiwNO/HW05L6+OOaOn+6Pw2YEkeuiiaTt90DgCUf lgeVt7CXPLAKfbG07UBtFu39fe0AXYfZJXd046AhmSx3TAVNOUicr2vVpTPUxPYrsM6U wX+g== X-Forwarded-Encrypted: i=1; AJvYcCX2fPp4dYpY0wQRRHWTBXJhsJu3H+6r/DWH0VbfH7dOoTGzL0reC2UV0cR7k45H5CT0byVPCDwlCPH5c8/eLX4lFSqJqw2esvOwUw4/vM76CKZr44Prj4gqZccvnEe75/xrlNs/0byT+r4cGqzbog4f2DEyuYy2LozG3v4c4FwCEpFIQhuLU89BqQC6238= X-Gm-Message-State: AOJu0YyUdmshhUkgEfEgGIU45ib4C/pktq0kLoMbG2lZ8i7WYVsYXBtz WDX5hkeeactXNCzbg+iVMVv/2bebMXb8BUuK2eZvAJlhk2f9bJ//YbTexw== X-Google-Smtp-Source: AGHT+IF7DuU1xWOafxN9q3DhR0xEBYKfGjWWHxp9dYY8G04wLrwAqGHi0UmYKSUIUlKO4NI/Z966dQ== X-Received: by 2002:a05:6402:26c1:b0:572:5285:6dc2 with SMTP id x1-20020a05640226c100b0057252856dc2mr492736edd.12.1714083597800; Thu, 25 Apr 2024 15:19:57 -0700 (PDT) Received: from smtpclient.apple (dynamic-046-115-021-017.46.115.pool.telefonica.de. [46.115.21.17]) by smtp.googlemail.com with ESMTPSA id l11-20020a50cbcb000000b0057030326144sm9335245edi.47.2024.04.25.15.19.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Apr 2024 15:19:56 -0700 (PDT) From: =?utf-8?Q?Klaus_K=C3=BCchemann?= Content-Type: multipart/alternative; boundary="Apple-Mail=_1E6194A7-523A-4EAA-80C9-840CB6271984" List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Subject: Re: git: 1bd4f769caf8 - main - add dtb support for RPI CM4, CM4s, CM4_ioBoard Date: Fri, 26 Apr 2024 00:19:44 +0200 References: <202404192311.43JNBiVS059729@gitrepo.freebsd.org> <0100018f169ec80a-47d419c2-2cd6-4ee1-89da-3f4782429089-000000@email.amazonses.com> <0100018f16c8f23a-eacbe781-3f6e-4f02-9b4d-d26468364b1f-000000@email.amazonses.com> <7473b5ed-433b-4d51-8a23-cf6464eb4416@FreeBSD.org> <7FA67865-F391-4773-86BA-9998B3EC855E@googlemail.com> <142362e6-8a88-43f5-bff6-6ff90a12802e@FreeBSD.org> To: Kyle Evans , Warner Losh , cperciva@tarsnap.com, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, hp@tmm.cx In-Reply-To: <142362e6-8a88-43f5-bff6-6ff90a12802e@FreeBSD.org> Message-Id: X-Mailer: Apple Mail (2.3774.500.171.1.1) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4VQVf827dkz45gB --Apple-Mail=_1E6194A7-523A-4EAA-80C9-840CB6271984 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > Am 26.04.2024 um 00:09 schrieb Kyle Evans : >=20 > On 4/25/24 16:44, Klaus K=C3=BCchemann wrote: >>> Am 25.04.2024 um 22:01 schrieb Kyle Evans : >>>=20 >>> On 4/25/24 14:43, Colin Percival wrote: >>>> On 4/25/24 12:24, Warner Losh wrote: >>>>> On Thu, Apr 25, 2024, 12:57=E2=80=AFPM Colin Percival = > wrote: >>>>> On 4/19/24 16:11, Warner Losh wrote: >>>>> > add dtb support for RPI CM4, CM4s, CM4_ioBoard >>>>> > >>>>> > Signed-off-by: Klaus K=C3=BCchemann = >>>> > >>>>> > Reviewed by: imp >>>>> > Pull Request: = https://github.com/freebsd/freebsd-src/pull/1182 >>>>> >>>>> > --- >>>>> > --- a/release/arm64/RPI.conf >>>>> > +++ b/release/arm64/RPI.conf >>>>> > -DTB=3D"bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb = bcm2710-rpi-3-b-plus.dtb >>>>> bcm2710-rpi-cm3.dtb bcm2711-rpi-4-b.dtb" >>>>> > +DTB=3D"bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb = bcm2710-rpi-3-b-plus.dtb >>>>> bcm2710-rpi-cm3.dtb \ >>>>> > + bcm2711-rpi-4-b.dtb bcm2711-rpi-cm4-io.dtb = bcm2711-rpi-cm4.dtb >>>>> bcm2711-rpi-cm4s.dtb" >>>>>=20 >>>>> This broke the RPI release build, since bcm2711-rpi-cm4s.dtb = doesn't exist. >>>>> Is it provided by a port which we should add to the RPI build? >>>>>=20 >>>>> I thought it was in tree. I'll look into this and report back. >>>> Entirely possible. The release-building code is trying to copy it = from >>>> /usr/local/share/rpi-firmware/bcm2711-rpi-cm4s.dtb >>>> so if it's somewhere else we need to adjust that code. >>>=20 >>> The rpi-firmware port is supposed to provide all .dtb used here, but = we've never installed that one. It really shouldn't have been included = in the list to begin with, but I guess if there's demand we should fix = the port to include it. >>>=20 >>> Thanks, >>>=20 >>> Kyle Evans >> we only have tested/fixed the CM4-model, not forceably need the = cm4s.dtb , so no objections to remove cm4s.dtb from the dtb-list at = least temporarily. >> But please hold cm4.dtb and the cm4_io_.dtb, which will then = hopefully not break the rpi-release anymore. >=20 > I'm going to go ahead and remove just the rpi-cm4s.dtb, feel free to = update the port (sysutils/rpi-firmware) to grab it then try again once = new packages are available with it so that we don't break the snapshot = again from the same file. >=20 > Thanks, >=20 > Kyle Evans Yes, better at the moment , because Updating the port would require to test every rpi-model again because = the provided dtb-files can sometimes be very =E2=80=9Esensitive=E2=80=9C or critical in = behavior .=20 thank you and sorry for the breakage. Klaus --Apple-Mail=_1E6194A7-523A-4EAA-80C9-840CB6271984 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

Am 26.04.2024 um 00:09 schrieb Kyle Evans = <kevans@FreeBSD.org>:

On 4/25/24 16:44, Klaus K=C3=BCchemann = wrote:
Am 25.04.2024 um 22:01 = schrieb Kyle Evans <kevans@FreeBSD.org>:

On 4/25/24 14:43, = Colin Percival wrote:
On 4/25/24 12:24, = Warner Losh wrote:
On Thu, Apr 25, 2024, = 12:57=E2=80=AFPM Colin Percival <cperciva@tarsnap.com = <mailto:cperciva@tarsnap.com>> = wrote:
    On 4/19/24 16:11, Warner = Losh wrote:
     >      = add dtb support for RPI CM4, CM4s, = CM4_ioBoard
     >
   &nb= sp; >    =   Signed-off-by: Klaus K=C3=BCchemann = <maciphone2@googlemail.com
    <mailto:maciphone2@googlem= ail.com>>
     >      = Reviewed by: imp
     >      = Pull Request: = https://github.com/freebsd/freebsd-src/pull/1182
    <https://github.com/freebs= d/freebsd-src/pull/1182>
     > = ---
     > --- = a/release/arm64/RPI.conf
     > +++ = b/release/arm64/RPI.conf
     > = -DTB=3D"bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb = bcm2710-rpi-3-b-plus.dtb
    bcm2710-rpi-cm3.dtb = bcm2711-rpi-4-b.dtb"
     > = +DTB=3D"bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb = bcm2710-rpi-3-b-plus.dtb
    bcm2710-rpi-cm3.dtb = \
     > +    =  bcm2711-rpi-4-b.dtb bcm2711-rpi-cm4-io.dtb = bcm2711-rpi-cm4.dtb
    bcm2711-rpi-cm4s.dtb"

=     This = broke the RPI release build, since bcm2711-rpi-cm4s.dtb doesn't = exist.
    Is it provided by a port = which we should add to the RPI build?

I thought it was in tree. = I'll look into this and report back.
Entirely = possible.  The release-building code is trying to copy it = from
/usr/local/share/rpi-firmware/bcm2711-rpi-cm4s.dtb
so if it's = somewhere else we need to adjust that code.

The = rpi-firmware port is supposed to provide all .dtb used here, but we've = never installed that one.  It really shouldn't have been included = in the list to begin with, but I guess if there's demand we should fix = the port to include it.

Thanks,

Kyle = Evans
we only have tested/fixed the CM4-model,  not = forceably need the cm4s.dtb , so no objections to remove cm4s.dtb from = the dtb-list at least temporarily.
But please hold cm4.dtb and the = cm4_io_.dtb, which will then hopefully not break the rpi-release = anymore.

I'm = going to go ahead and remove just the rpi-cm4s.dtb, feel free to update = the port (sysutils/rpi-firmware) to grab it then try again once new = packages are available with it so that we don't break the snapshot again = from the same file.

Thanks,

Kyle = Evans

Yes, better at the moment = , because
Updating the port would require to test every = rpi-model again because the provided dtb-files
 can = sometimes be very =E2=80=9Esensitive=E2=80=9C or critical in behavior =  . 

 thank you and sorry for the = breakage.
Klaus

= --Apple-Mail=_1E6194A7-523A-4EAA-80C9-840CB6271984--