From nobody Thu Apr 25 22:09:24 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VQVPz4xmsz5JfC4; Thu, 25 Apr 2024 22:09:27 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VQVPz4Mtmz44MN; Thu, 25 Apr 2024 22:09:27 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714082967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cGQBksAFiITXqYzbNTyM4+flUys8SnQ9ywnjHuD198I=; b=kkIDrnZgqrAQFdHgQpOlhie3wZbfzjEar4z0a3qGumL3Iio6VKBsoXUjZQmOJVZ7YPcjUL EPoVZqaQcKXkiKlZLb+MF9/I2pmiUHQW5m54R/3Kw24vE/Fjx+igdzgcqSxp97NDGUpDkw rdKbJ2lr7R37wVo2gmiHDCNTvWQTyiGJAetugRa2BrbSj+VlFDD/mcupeCjXjALd/0LUxu NFwZmA5CarzHERfz/iJciYW01LNeA8yZrd3An+wZmqwm5kYVrqO9fJLcwqwj8ierGYPc9A ZLyRtePzlrumNX04J6ImKc6/xfBZ/VUA9uBUBFxmYf8MwLDAmAoEauiCwEVgmA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714082967; a=rsa-sha256; cv=none; b=WswAgzLmsS/h4VMdu0stTqxBjtvBZ+BJIBuHqWEPZApA72vc68KynoHe/5boL9QDqOdJff vYKlDUv9Lq0JgJiW/qkn802X7LFBbhv79ADz7FbIu+pTkg4zfH8gB+8wyJ0BFKFhU3mJ5t J6rOTd4QAr9v3wD9Kh7RrT/6vD7UD9x7Sae0OYH40kJoNKSs5rc149flugV+mkokbAspwQ w79+c0dCwctOhORWNpi5fTENfmzMe8Izdz0Aakn1F9NO4r9Sdk4vpVdUeFlin3jp7AWMw1 ZTD296pgpzNMmWwOJrGcIgKeekrTIjCItaDTcJgdU0ugYoaPPNW3MITLtEVgRg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714082967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cGQBksAFiITXqYzbNTyM4+flUys8SnQ9ywnjHuD198I=; b=FgdxFa2nDaZX8kTieoVOhm+WELjqlKB4JqNuSn1O2ciMv4GmFyPeqvVVVm4yHxZIBiqjBj CzjcO+WlpX+jC7oCzv7i4B5LSSu1L8nbasFhaPXwc+9B9WhpiNNNSiHHrmphiEVWBYt5Tx P3Zhvsbz+8+L6Ka6GNSpM5IfvhZcGyJDDf+wR7W8xCwzDJyXPKmY+qK/xgh3Pgd5MHi5mY Br8PcR94k3ueL1wXeS3KI14d5Fv++aZL8wXDqfbNGSXaVOQNtvCJetAxfDmXL8r6hPptvP fnRl/CRZo4AZhjl7PuIfJEG8xnjEZY28rwzH6m5AkeGyxu2aq8e6jbN7mtpbrg== Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VQVPy0t8tz11xH; Thu, 25 Apr 2024 22:09:25 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: <142362e6-8a88-43f5-bff6-6ff90a12802e@FreeBSD.org> Date: Thu, 25 Apr 2024 17:09:24 -0500 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 1bd4f769caf8 - main - add dtb support for RPI CM4, CM4s, CM4_ioBoard Content-Language: en-US To: =?UTF-8?Q?Klaus_K=C3=BCchemann?= , cperciva@tarsnap.com, Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202404192311.43JNBiVS059729@gitrepo.freebsd.org> <0100018f169ec80a-47d419c2-2cd6-4ee1-89da-3f4782429089-000000@email.amazonses.com> <0100018f16c8f23a-eacbe781-3f6e-4f02-9b4d-d26468364b1f-000000@email.amazonses.com> <7473b5ed-433b-4d51-8a23-cf6464eb4416@FreeBSD.org> <7FA67865-F391-4773-86BA-9998B3EC855E@googlemail.com> From: Kyle Evans In-Reply-To: <7FA67865-F391-4773-86BA-9998B3EC855E@googlemail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/25/24 16:44, Klaus Küchemann wrote: > > >> Am 25.04.2024 um 22:01 schrieb Kyle Evans : >> >> On 4/25/24 14:43, Colin Percival wrote: >>> On 4/25/24 12:24, Warner Losh wrote: >>>> On Thu, Apr 25, 2024, 12:57 PM Colin Percival >>> > wrote: >>>>     On 4/19/24 16:11, Warner Losh wrote: >>>>      >      add dtb support for RPI CM4, CM4s, CM4_ioBoard >>>>      > >>>>      >      Signed-off-by: Klaus Küchemann >>>     > >>>>      >      Reviewed by: imp >>>>      >      Pull Request: >>>> https://github.com/freebsd/freebsd-src/pull/1182 >>>>     >>>>      > --- >>>>      > --- a/release/arm64/RPI.conf >>>>      > +++ b/release/arm64/RPI.conf >>>>      > -DTB="bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb >>>> bcm2710-rpi-3-b-plus.dtb >>>>     bcm2710-rpi-cm3.dtb bcm2711-rpi-4-b.dtb" >>>>      > +DTB="bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb >>>> bcm2710-rpi-3-b-plus.dtb >>>>     bcm2710-rpi-cm3.dtb \ >>>>      > +     bcm2711-rpi-4-b.dtb bcm2711-rpi-cm4-io.dtb >>>> bcm2711-rpi-cm4.dtb >>>>     bcm2711-rpi-cm4s.dtb" >>>> >>>>     This broke the RPI release build, since bcm2711-rpi-cm4s.dtb >>>> doesn't exist. >>>>     Is it provided by a port which we should add to the RPI build? >>>> >>>> I thought it was in tree. I'll look into this and report back. >>> Entirely possible.  The release-building code is trying to copy it from >>> /usr/local/share/rpi-firmware/bcm2711-rpi-cm4s.dtb >>> so if it's somewhere else we need to adjust that code. >> >> The rpi-firmware port is supposed to provide all .dtb used here, but >> we've never installed that one.  It really shouldn't have been >> included in the list to begin with, but I guess if there's demand we >> should fix the port to include it. >> >> Thanks, >> >> Kyle Evans > > we only have tested/fixed the CM4-model,  not forceably need the > cm4s.dtb , so no objections to remove cm4s.dtb from the dtb-list at > least temporarily. > > But please hold cm4.dtb and the cm4_io_.dtb, which will then hopefully > not break the rpi-release anymore. > I'm going to go ahead and remove just the rpi-cm4s.dtb, feel free to update the port (sysutils/rpi-firmware) to grab it then try again once new packages are available with it so that we don't break the snapshot again from the same file. Thanks, Kyle Evans