From nobody Thu Apr 25 20:01:20 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VQRZG09lXz5JRJ2; Thu, 25 Apr 2024 20:01:26 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VQRZF6lrDz4nZc; Thu, 25 Apr 2024 20:01:25 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714075285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WWnYOS+akd2uFpC9goFDk3FEjozeo4UPZkYhmPnPIHQ=; b=aoVjvkybx/qBid2luY98nYUeKpaaH5AvV+WWiaXaLOsPZW7dYxkVd0U85zFbzskwNODfsc GJyRwDHzVbl7ek2UqsGkeSmf+eCyJWmDKJo3CP5XKx3WdEkCG8VjkEv79+4vsLTsGUjV4l zdM/kKkXIWO+hf9MEKKrlfyUojxAinpVNWAyBNUMPnxSXhfGlIoB3gfh7XLdtUK3uFkbVD xfjay0cwY+yOnTXWrQV1+zDZV3yvBtHWVX1gaDq0+H5HOFIXnJO5pXT64BDSRBH4fuA/Td 4OEDTDyNQwfqPNwFflchQLQEzWe32WFTZaSAXSTbjKm6SKKh22BI1T/Psry1Kw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714075285; a=rsa-sha256; cv=none; b=BH7C38uiGu6XLyL/SOvYZtqF6YPpkeJKNkOL5G6YW6NdUbi00rhrjEgvkqicR9DfgjaEPw npoLJo9ahI3A+0OCBVoQAIhU4bpbcuQhzHF8Oo8KdjBUg1nlun5yb1AIDzJ8+DI1MDqbch lbNv/RHe6IY9YrhX/vlroIOd5aPtlYdLL5Fylw332G6kFgvhTZOctr49mgTCsERhXEXjXn wVC2v84HfgMLyQjNnpz7d/p3tdJRm6mtRicdea2dDr720R4MfjaVq7eVHToZqfBQOTAITU EaUnKVxdIoNqx2nMLfKGTNtbwyJA9foxcMdgdshG8JxDM2F/+4cORA+Xo1dhzA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714075285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WWnYOS+akd2uFpC9goFDk3FEjozeo4UPZkYhmPnPIHQ=; b=O/qB+uQLwIoh1ruYWsIWa+DARpDo1WnNEk6dyFAgaQ9no51JQGVdIp22miagqZ/qcIAfcy UEo9iiT1f1TBRn5TDagTejgf9xlU3814z8x8Hdx07KzC3Agth/C63atEhcNQ0ziFXPLaP/ M1wv6LbvsTPKzoZ4fmf6dvZs4NaK9s7NryVFze0GPKVnbwIgSQL6YiRgYrlNWFpsZLgtds aX6urNNf/Qv9ZV1xeRZGxrzCKd/8fuEkneA5IOWHbKrafm4VFMyobJfVHV2n87hygqVydN n5g6fJsmU42kCGOWAuOKKaBgAi5FALGBvylTmx35bGTspknyGFinYzhCbUBrMg== Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VQRZC6kQSzh0s; Thu, 25 Apr 2024 20:01:23 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: <7473b5ed-433b-4d51-8a23-cf6464eb4416@FreeBSD.org> Date: Thu, 25 Apr 2024 15:01:20 -0500 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 1bd4f769caf8 - main - add dtb support for RPI CM4, CM4s, CM4_ioBoard To: Colin Percival , Warner Losh Cc: Warner Losh , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, =?UTF-8?Q?Klaus_K=C3=BCchemann?= References: <202404192311.43JNBiVS059729@gitrepo.freebsd.org> <0100018f169ec80a-47d419c2-2cd6-4ee1-89da-3f4782429089-000000@email.amazonses.com> <0100018f16c8f23a-eacbe781-3f6e-4f02-9b4d-d26468364b1f-000000@email.amazonses.com> Content-Language: en-US From: Kyle Evans In-Reply-To: <0100018f16c8f23a-eacbe781-3f6e-4f02-9b4d-d26468364b1f-000000@email.amazonses.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/25/24 14:43, Colin Percival wrote: > On 4/25/24 12:24, Warner Losh wrote: >> On Thu, Apr 25, 2024, 12:57 PM Colin Percival > > wrote: >>     On 4/19/24 16:11, Warner Losh wrote: >>      >      add dtb support for RPI CM4, CM4s, CM4_ioBoard >>      > >>      >      Signed-off-by: Klaus Küchemann >     > >>      >      Reviewed by: imp >>      >      Pull Request: >> https://github.com/freebsd/freebsd-src/pull/1182 >>     >>      > --- >>      > --- a/release/arm64/RPI.conf >>      > +++ b/release/arm64/RPI.conf >>      > -DTB="bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb >> bcm2710-rpi-3-b-plus.dtb >>     bcm2710-rpi-cm3.dtb bcm2711-rpi-4-b.dtb" >>      > +DTB="bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb >> bcm2710-rpi-3-b-plus.dtb >>     bcm2710-rpi-cm3.dtb \ >>      > +     bcm2711-rpi-4-b.dtb bcm2711-rpi-cm4-io.dtb >> bcm2711-rpi-cm4.dtb >>     bcm2711-rpi-cm4s.dtb" >> >>     This broke the RPI release build, since bcm2711-rpi-cm4s.dtb >> doesn't exist. >>     Is it provided by a port which we should add to the RPI build? >> >> I thought it was in tree. I'll look into this and report back. > > Entirely possible.  The release-building code is trying to copy it from > /usr/local/share/rpi-firmware/bcm2711-rpi-cm4s.dtb > so if it's somewhere else we need to adjust that code. > The rpi-firmware port is supposed to provide all .dtb used here, but we've never installed that one. It really shouldn't have been included in the list to begin with, but I guess if there's demand we should fix the port to include it. Thanks, Kyle Evans