From nobody Sun Apr 21 14:10:19 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VMqz01vP8z5H3NL; Sun, 21 Apr 2024 14:10:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VMqz01R6xz47Zy; Sun, 21 Apr 2024 14:10:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713708620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0VdKgSgX6Lm2e23Zen4zEfRktZDsJXnz5j3EUz9V0Uc=; b=OAytH+TD/BuR5tPaT/u7VL/m5UzuJI/TphHONZtwCon4P/y8RAh5fS71Wt7KH1cyzlp7v2 VykPg1o0w9VZHWRaMai70NpriMLxIvGN5J5oehOljAumiztXskF89H2qIEmMguYjsjG024 M0I9AqoB8U9Cs02ql4Uh3pL/IiwR8ajcd5rtrUml9cK8JQr01n1ypGikgpzvR3v5EiVwxM xSFvi1DzSfJyyTnBOFRFIuIGgve2JQJzKDqu3eN8vzK4WQTR7/zYBFVbfg3t+plAFRf+5w L7BO4DbJ9Xk70v8jde2PwIuYOnXBMvs5C3VATsTZ26un7gCNwVpyHTvCajn6/g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713708620; a=rsa-sha256; cv=none; b=mZWS8Zqw+CNKKmAChC/9vCpoOWSZMRLe/nFI1UAnivUAftjC9g+Wmb/OhUyZH+txUkoUEI I2CYFXz/tVtFeFxLV9ieM6D1Z5Dy8EpfP+C6foqa3/Lq3KvfYHqmW9XFStP/rzJf+2OCVf zZwya9wmC7PgNv6ZAKiUeQXRYiYG467uCDWK4tkDonLc17uPl3AW/rhhc/mYEBlPaRH24K rMhM0VHfFefnCp4ksoVtQmGQrQVBGTulTV5XuzDyiYf4LNlXMZREZ6avbhpZWSzzWzMslG FKseffsKQDk/PRZ96qqSCK1g+rdjiQq/f3PYW5Krw1qL6qOaVveSY2sWlrtqaw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713708620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0VdKgSgX6Lm2e23Zen4zEfRktZDsJXnz5j3EUz9V0Uc=; b=ox7i02foSTB3Je+fQRiOjTk+fZfOHMMewjWMAWHmDnoI02Vj4foZsbfErDbSe/JWdB/Zcs BYsvFDd6wURrTR0M7Dy7Z+LN0OIPW+TVxbDy9m32QN7XMFlodO19fICA1kGZOaN2fgU7e1 9cq3V/JJlPLYhz6Y0Q/90A36uS0oeUdlhkJ1eh8Q8HM5XPgw/T8AooCP8nAJq76SNfZGvD MsqopeAt71EvHyQoU0R9GZypG2l+3P8RdMIXPh1NrW4BIbIPQhVJQfq1yLcfxETjOQPPYE 9XRcbadkvv9EVfU4t85P6qA65a8IPfMwrh6szb6pQerw9S3eDZ3mvdN3VjVoYw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VMqz00wPkz1Mb9; Sun, 21 Apr 2024 14:10:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43LEAJVp029075; Sun, 21 Apr 2024 14:10:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43LEAJrn029072; Sun, 21 Apr 2024 14:10:19 GMT (envelope-from git) Date: Sun, 21 Apr 2024 14:10:19 GMT Message-Id: <202404211410.43LEAJrn029072@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Alan Somers Subject: git: 61ddfc0e55b4 - stable/14 - fusefs: only test for incoherency if FN_SIZECHANGE is set List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 61ddfc0e55b4fcdf4fd07a9764404760eecf2419 Auto-Submitted: auto-generated The branch stable/14 has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=61ddfc0e55b4fcdf4fd07a9764404760eecf2419 commit 61ddfc0e55b4fcdf4fd07a9764404760eecf2419 Author: Emil Tsalapatis AuthorDate: 2024-02-08 01:13:43 +0000 Commit: Alan Somers CommitDate: 2024-04-21 14:09:43 +0000 fusefs: only test for incoherency if FN_SIZECHANGE is set FUSE emits spurious incoherency warnings in writethrough mode. The warnings are triggered by setattr calls generated by vnode truncation turning the cached va_size vattr stale, causing comparisons with the fresh version provided by the server to fail. Only validate the vnode's va_size vattr if the FN_SIZECHANGE flag is set. This is a part of the research work at RCSLab, University of Waterloo. Reviewed by: asomers Pull Request: https://github.com/freebsd/freebsd-src/pull/1110 (cherry picked from commit 8758bf0aaec1d4b2ebcb429e8cabc691c2c95461) --- sys/fs/fuse/fuse_internal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/fs/fuse/fuse_internal.c b/sys/fs/fuse/fuse_internal.c index 2d1c729a395a..30e3cebfa500 100644 --- a/sys/fs/fuse/fuse_internal.c +++ b/sys/fs/fuse/fuse_internal.c @@ -270,10 +270,10 @@ fuse_internal_cache_attrs(struct vnode *vp, struct fuse_attr *attr, if (vnode_isreg(vp) && fvdat->cached_attrs.va_size != VNOVAL && + fvdat->flag & FN_SIZECHANGE && attr->size != fvdat->cached_attrs.va_size) { - if ( data->cache_mode == FUSE_CACHE_WB && - fvdat->flag & FN_SIZECHANGE) + if (data->cache_mode == FUSE_CACHE_WB) { const char *msg;