From nobody Sat Apr 20 10:34:42 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VM7Dg14r3z5HWXK; Sat, 20 Apr 2024 10:34:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VM7Dg01PXz4T4m; Sat, 20 Apr 2024 10:34:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713609283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hhKpvD7gDtDjuMbZ/Pr7SWtE+fnRFJ+Wk/hpvVCDq5c=; b=qheAwbyGOPTyOnMnrPd9+Inh38/1CJFhKPifm5tLyI3OmSz6qzJBt9y7tmBfVv2TqCFr8T /9ap/YaEz9AW2FA3E9CMd1rVkEgxe5mw4Ss0muX4JSmCiBrG08Vw3ngVzKgYdt/wq62XkN mUQ7MgSBFJnz0Xtk6y9YCNvDnD2G55NKAErtXaWS5WCRrCigF89g1GIPJfQalQu3mC9HJ7 6SPZRANjRUK9aAbBgsri22Y2yTpottMkZ0AUX6ZD0vhlOp5YEyR2M4v44g6GUPVSZo3sbo yC1V/YMgUr5qIKLjtvSRvudK3HOfy52XrkzS+K965s3YqH2OTMhj0rGg7jI91Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713609283; a=rsa-sha256; cv=none; b=IFDUL0nRDQzdJUQjq/GRxkRuYkhVV2Uh282PR6bZ47NaqJoMDup4OpOxKOt+hHRpLXAYmN 1WHZonhCHRVmsuLb9QUKyKuqEr1U2YP3oIkNo84JCRCTcOifcOZqHyK2ly70x28SQJdTKH VAVF/IuIjWZ3B8FrE75YnlpJlvPUSxMqmdThuj/aztLGX6VF1t0wZu4J3btFFwxti5aspK kChY8aAtArSlLjyFkFSOqU/uQLYTyLpnEMyOeC9DZOUPTr0e1yRVo1q+x6Mu55YKaYVkpx KXoxynORIc7rQXO6ZkB5KF7yPwXwREpOLRzMDW5KioqeYv2eIYH/t2MaZnS7LQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713609283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hhKpvD7gDtDjuMbZ/Pr7SWtE+fnRFJ+Wk/hpvVCDq5c=; b=d649eRSYjtp6MwNLToD3Q1KLy5djs5kE/ZbLCw1c1dbXHxtF80zRmffUbnUk4VZbTxXD0d agWMZz6jSiFwMoBym/Bx+cbemWNIQn4WexJcexWec3JGqVOKdMi6LRGzeZ1T8CH3DWVIqb tZy/KaKbSybakGI3corKI9fop2Wb5zGqcJavbWTmFhBPvrH6ROnlY7NuCoqEoffKgHd8cq O5dNGIDw/sb+6S+SDuJVRf/CYC94tuWroKie8vt0sVycqwu8C28D4ZlB+Sp+UYnJQfDPfT /0uwNvvhMCw2nQcw6bo+RVn10QBdvlbNgXYPbi8ybbNUWN9Vd1oNYTJ7Jv/ZGw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VM7Df6SkPzYr8; Sat, 20 Apr 2024 10:34:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43KAYgW0014087; Sat, 20 Apr 2024 10:34:42 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43KAYg9p014084; Sat, 20 Apr 2024 10:34:42 GMT (envelope-from git) Date: Sat, 20 Apr 2024 10:34:42 GMT Message-Id: <202404201034.43KAYg9p014084@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: 64816cf50d5e - stable/13 - Revert commit 6255157d24e2 from llvm-project (by Dimitry Andric): List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 64816cf50d5e571e64f5d8a4143f05192788d09b Auto-Submitted: auto-generated The branch stable/13 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=64816cf50d5e571e64f5d8a4143f05192788d09b commit 64816cf50d5e571e64f5d8a4143f05192788d09b Author: Dimitry Andric AuthorDate: 2024-03-19 13:07:27 +0000 Commit: Dimitry Andric CommitDate: 2024-04-19 21:24:48 +0000 Revert commit 6255157d24e2 from llvm-project (by Dimitry Andric): [libc++] Re-enable std::pair trivial copy constructor for FreeBSD >= 14 After many years of using the really old std::pair ABI which did not yet have a trivial copy constructor, FreeBSD 14 and later will finally get rid of it. Only use the old ABI for FreeBSD 13 and earlier. Note: on the FreeBSD side, we will bump our libc++.so version for this, and keep an old compatibility library in a separate package. Differential Revision: https://reviews.llvm.org/D126462 This ABI change can cause crashes when binaries compiled against older libc++ versions are run against binaries compiled against this libc++ version. For example, lang/ldc uses a precompiled bootstrap ldc2 binary that was compiled against the old libc++, but also links against libLLVM-15.so. If libLLVM-15.so is compiled against the new libc++ version, the ABI mismatch results in segfaults or even stack overflows. Note: we can only re-enable the std::pair trivial copy constructors again when the official libc++ ABI version is bumped to 2. PR: 276104 MFC after: 1 month (cherry picked from commit ce4f1f49e036fd806b534decfe38020dae32a384) --- contrib/llvm-project/libcxx/include/__config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/llvm-project/libcxx/include/__config b/contrib/llvm-project/libcxx/include/__config index fa5535facb14..a5981984d37e 100644 --- a/contrib/llvm-project/libcxx/include/__config +++ b/contrib/llvm-project/libcxx/include/__config @@ -190,7 +190,7 @@ # endif // Feature macros for disabling pre ABI v1 features. All of these options // are deprecated. -# if defined(__FreeBSD__) && __FreeBSD__ < 14 +# if defined(__FreeBSD__) # define _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR # endif // For XCOFF linkers, we have problems if we see a weak hidden version of a symbol