From nobody Sat Apr 20 10:32:36 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VM7BF1SP6z5HWKG; Sat, 20 Apr 2024 10:32:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VM7BD5CYmz4PtJ; Sat, 20 Apr 2024 10:32:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713609156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MtcqtU1GZ0VcC/79Dwfly28k2eHpaSq/IIRVcCCf3yU=; b=xfXa/j2QGIqqLZ6o5Pv6u5WTb3cW3aFseoYlYSDl0zuFZoJFIC9rQFtZmz9Q6tl/pJhKPG pISMZPVDrJqWa59q/j0EOoPnKlj18r+CrJjYvVm4q5h+e3WdU5OaXkr5PmSmAOHnmiYJmb TYPXmTRROH0cvz/vz3tkDpYT6NSH6d8OAnAW9ROCQTNq7XiDUVDIUaX+KKbrRtih03XFrw o2nX4FCjOrZLEqwhAZ1NCrCE5NovoAxtg/lHjU6Ow39BddY6x+rlfla79KwD9gmVwGg841 GAW3M3CS0LVxTQzu/Lhjb1xiqfuRIjMq9SizNKHJ1JDiN6IlN6sYV9K15dKJwQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713609156; a=rsa-sha256; cv=none; b=kyllmlfQwJItkl4e7qWFr1tFDHpwrVeIEfh9zOdO2uLrRl/LFXaAfcTv0E+iIi/op1LIcr ZuWP9e7kl6+Ns7XUc/hmHzLg1LODbE9ES0CQrlpqX7IKKeQbSfPz/szsWlGiojiwLi396V eDPkTmXAUgOOSVnBeshyMGBFFNfK2NWz1N/Wk5R8QzJBZ1uFQqvjrnWES9eQP5k5vBfKaD wDT5zLY639+J0zpssfhT7C3Kgk86m7u1pKcsbp7SU88C4e9BehGzXX1FXRGKJwR0ybHqmr 9w3PotTG3iztpm9YUVMAfgzwXSe0guUmnlPJeE0Xxfis3h6j1owKmi/Q9e+Wzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713609156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MtcqtU1GZ0VcC/79Dwfly28k2eHpaSq/IIRVcCCf3yU=; b=oAfsubT6eP9geA1cWvkdQbSzIRCCS0icT6WuylKgX0rlnNKxHNNTVFlFibvaSQIl1j7SaE Q/L5ll1RJxffvteN1JGO6Lr7lRv/8TkZ9YLgk3KYMG5CnG5NApa9VPROHeN1s7CRREH3I/ Uu9iA0/vI3l7cTxcrrBl+HrQKPOKRSrejUdFwJLFe72x0kggVjw3XFD20iCq4uqkT4jI2e 8zie8BWiGP/V4Q4k9GweoJ9GNP9w6TkkqCT90X8uIrKYqgRrGyrqAidQiDZdW/QLgMOuyx EGxzSXdRjTG0eCPrnDHzGxxpneqFSWbueNhOk+VBNmZme1GhE3PIU5LiWUvbzQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VM7BD4fBqzZ2r; Sat, 20 Apr 2024 10:32:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43KAWafd011431; Sat, 20 Apr 2024 10:32:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43KAWaFM011428; Sat, 20 Apr 2024 10:32:36 GMT (envelope-from git) Date: Sat, 20 Apr 2024 10:32:36 GMT Message-Id: <202404201032.43KAWaFM011428@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: ab1bf989a944 - stable/14 - Revert commit 6255157d24e2 from llvm-project (by Dimitry Andric): List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: ab1bf989a94495472d91845e83b725d7c20aef5e Auto-Submitted: auto-generated The branch stable/14 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=ab1bf989a94495472d91845e83b725d7c20aef5e commit ab1bf989a94495472d91845e83b725d7c20aef5e Author: Dimitry Andric AuthorDate: 2024-03-19 13:07:27 +0000 Commit: Dimitry Andric CommitDate: 2024-04-19 21:14:17 +0000 Revert commit 6255157d24e2 from llvm-project (by Dimitry Andric): [libc++] Re-enable std::pair trivial copy constructor for FreeBSD >= 14 After many years of using the really old std::pair ABI which did not yet have a trivial copy constructor, FreeBSD 14 and later will finally get rid of it. Only use the old ABI for FreeBSD 13 and earlier. Note: on the FreeBSD side, we will bump our libc++.so version for this, and keep an old compatibility library in a separate package. Differential Revision: https://reviews.llvm.org/D126462 This ABI change can cause crashes when binaries compiled against older libc++ versions are run against binaries compiled against this libc++ version. For example, lang/ldc uses a precompiled bootstrap ldc2 binary that was compiled against the old libc++, but also links against libLLVM-15.so. If libLLVM-15.so is compiled against the new libc++ version, the ABI mismatch results in segfaults or even stack overflows. Note: we can only re-enable the std::pair trivial copy constructors again when the official libc++ ABI version is bumped to 2. PR: 276104 MFC after: 1 month (cherry picked from commit ce4f1f49e036fd806b534decfe38020dae32a384) --- contrib/llvm-project/libcxx/include/__config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/llvm-project/libcxx/include/__config b/contrib/llvm-project/libcxx/include/__config index fa5535facb14..a5981984d37e 100644 --- a/contrib/llvm-project/libcxx/include/__config +++ b/contrib/llvm-project/libcxx/include/__config @@ -190,7 +190,7 @@ # endif // Feature macros for disabling pre ABI v1 features. All of these options // are deprecated. -# if defined(__FreeBSD__) && __FreeBSD__ < 14 +# if defined(__FreeBSD__) # define _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR # endif // For XCOFF linkers, we have problems if we see a weak hidden version of a symbol