From nobody Fri Apr 19 22:48:58 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VLqZM0lJDz5HtrS; Fri, 19 Apr 2024 22:48:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VLqZL5r53z4Nkh; Fri, 19 Apr 2024 22:48:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713566938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=O1TjI1xoK+RUyb5LWVyVR9VGvnpYwbufW87Y2PkTmiU=; b=QGs+QWlJV0TkPwBjpLiqaW/GY/X04TdBwkT/yrbS0AswLKBSpsoOGhbgse0MP+1L6O7L/h NMeydHxZ/PQIMvtWd7tUGKeuxzQOQcqS4Z064iYDnZGXWpJkF93DI5LWMWR7nTAEEXuy6C 2SlGDLz0Y4kcGWOtp5hzzgMQarkwn8obdoDhBCdQu7+l+qijKbwxeBLp158XoBt+9QWkTf ygtIOzTnUIx1NcdxKM4V4bURfjK4ofw2U9CdFmGnV75+DhAsMDoN/q81pRYfLCQWud6ORR ISFRTWCTCP/SetEH07Jxkmd0dlRojC8xiDbsHSVxwqi4uPCmPTjB2sPspUsyag== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713566938; a=rsa-sha256; cv=none; b=xxImiEu/uzq5VKD3FERqYDSxiFCpU4VrpqlaEgtxIT/ygs81ISq+TGuWyKvPuMKjZjZdQu A1kuW8fCUDkDipY+10j14nGkmlHdoOz66ZMMpM8mNebPdNFSgmb1Agey3wcz+4g6dkxkCP 5Bv9mB5F/rgKBuLrc5uV72Gzw0eCyjNYMVyPvad07EtrqPPl94ez+ymgrBFb09SAPUyes3 DInuY3WgefrTxQSMEXqBzV6SjcV04osU5K9BT5lDr3ttxgm+O0Y6MIDBae6XW0CNq47MRh jPhBj+yc8fd5Z2b7u8FfwZ1cDO6IZ1XpH4HlpSIU0QO/00qUC/C4plNYnujf2w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713566938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=O1TjI1xoK+RUyb5LWVyVR9VGvnpYwbufW87Y2PkTmiU=; b=w7THfJKOmGBF5p/9Vgi3ikng1LalAOKL9fV5AOjyAnGpkONHBTRiRtRS90kUJYyh6stz8m 5+QZLpBV/k0vWuKMNhQCNm3WkyPNv6ntgDP6Rw5V3TohBAiMcUgwdp6xEZ2BZrBXbfkUs5 kawrRp+0Av4OsUTYii74wVeu2Are4GGuMxF6Wz6mKJhOgozY9riJ5eW1NiU6JCeaY0xa/Z 3KCNi99LesYU2yiwFLw6SgvLOOevkW6+jYScNDaeAuk548jawftXnSUWnleRyNlvbTdpBK YyQwQ3n0oFP6DxxX9hk9VgAzsE1GzqZewX8uMfpVHF4+B2mwtAVpO8Kyg9ze2Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VLqZL5Pz8z1BS1; Fri, 19 Apr 2024 22:48:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43JMmwDP010942; Fri, 19 Apr 2024 22:48:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43JMmwe7010939; Fri, 19 Apr 2024 22:48:58 GMT (envelope-from git) Date: Fri, 19 Apr 2024 22:48:58 GMT Message-Id: <202404192248.43JMmwe7010939@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 493715f9b817 - main - ig4_iic: Warn on NACK List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 493715f9b8173da8a1ca8af12a22eb1ded79d4eb Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=493715f9b8173da8a1ca8af12a22eb1ded79d4eb commit 493715f9b8173da8a1ca8af12a22eb1ded79d4eb Author: Ahmad Khalifa AuthorDate: 2024-04-19 22:43:19 +0000 Commit: Warner Losh CommitDate: 2024-04-19 22:44:57 +0000 ig4_iic: Warn on NACK Some DSDTs define non-existent devices, warn the user when an access is attempted on one of these devices. Reviewed by: imp, markj, Elliott Mitchell Pull Request: https://github.com/freebsd/freebsd-src/pull/1125 --- sys/dev/ichiic/ig4_iic.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/dev/ichiic/ig4_iic.c b/sys/dev/ichiic/ig4_iic.c index 98c160ec9fd2..652d5a084f8b 100644 --- a/sys/dev/ichiic/ig4_iic.c +++ b/sys/dev/ichiic/ig4_iic.c @@ -675,6 +675,10 @@ ig4iic_transfer(device_t dev, struct iic_msg *msgs, uint32_t nmsgs) rpstart = !stop; } + if (error == IIC_ENOACK && bootverbose) + device_printf(dev, "Warning: NACK for slave address 0x%x\n", + msgs[i].slave >> 1); + if (!allocated) sx_unlock(&sc->call_lock); return (error);