Re: git: ede456359e55 - main - CONTRIBUTING: mention sys/crypto as another "contrib" directory
Date: Thu, 18 Apr 2024 19:10:24 UTC
On 4/18/24 11:57 AM, Ed Maste wrote: > The branch main has been updated by emaste: > > URL: https://cgit.FreeBSD.org/src/commit/?id=ede456359e55958ab17ac665e5867674a0c0e81b > > commit ede456359e55958ab17ac665e5867674a0c0e81b > Author: Ed Maste <emaste@FreeBSD.org> > AuthorDate: 2024-04-18 18:44:30 +0000 > Commit: Ed Maste <emaste@FreeBSD.org> > CommitDate: 2024-04-18 18:57:19 +0000 > > CONTRIBUTING: mention sys/crypto as another "contrib" directory > > Reviewed by: imp > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D44857 Hmm, sys/crypto is a bit of a mixed bag there. openssl is a mix of upstream and local bits. libsodium is an upstream. chacha20 and blake2 I think are upstreams. rijndael did come from an upstream but I don't think it's alive. I'd actually prefer if we moved a lot of sys/crypto over to sys/dev, e.g. actual device drivers (as opposed to software crypto implementations) like aesni, armv8, via, should definitely move to sys/dev. For sys/openssl it might be nicer then to have the home-grown bits of ossl(4) that aren't from upstream in a sys/dev/ossl leaving the stock openssl bits in sys/crypto/openssl. -- John Baldwin