From nobody Wed Apr 17 14:00:40 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VKMxh6vkGz5GxYL; Wed, 17 Apr 2024 14:00:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VKMxh6Tyqz4sc2; Wed, 17 Apr 2024 14:00:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713362440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gF9duBArZQFQWJn/l5oS8mW3Zr3YjFWsSTk/18cslUc=; b=LZWHfYb6LCn79b54xbOVrZLQSOgEWy5avEgVBRaGwVl1UZcvTu6g0XKzBfuayeDq1SLEIV 13yYk2gOKA39j35KuTtDybj7ebD/KxB04uar90RFfLBdN96mcjx3mjpglHmikzKBWQuXcd o6vCNeHX5baA4K5IUyR8A0pKciA6bGKeeerBrZoXcVsXQDhOqduo0JKtEIMwHBimdyhWq8 +OpXfbunKsEOdmWDWzh0FJeTHWjO6lbGp9uKXBuOMbvs7kMCKE/MVGYA8Ddz5lKiUHtkYM +nC/RDkqqrdydFMnEjIdQtbK/R+HXWl3jEpPMlBIdmXI8xy2plCvAeBzShKWeg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713362440; a=rsa-sha256; cv=none; b=G+3bQcnPjAjUqRDAhpJX4PSKlWSsndk3+rpf0b80xun901bHmqnmMV9MmcJr/2SjgJR60+ CULGRF6buhUg/2W1tpAP9igkVuD0IEj8Nrl7Mxn7PE45YLNduwkYgOcJ/Hlb1VpAAVEiEm sneazupPf9B2LmOz5iP8yv3pc/K7uWXKjT7qeeYjC2ab6ad7rbvuRfDDR2ze5fi3g6KUy8 tIo2ruwPBaEr1CqROQwaTuwxOEH0sfoenZqpXYQLwywmbW0iOtDoXxPfQBNUJF3b+G7FjT YtH0gqH90FHiCm9quDv66o5pfZwicrJoNhrNyX2eW3+PBGHZRdY/9Ws8/Wf0xw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713362440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gF9duBArZQFQWJn/l5oS8mW3Zr3YjFWsSTk/18cslUc=; b=IDAJ/STVZs3gH5QHYk0uzYxqKC0rn9zXBL0yRJfYlTxzUVm2k8PyR1GEXfT2RjzwiR+6Jv HIEDkZQYEWRJjR6eE4QKFkNu1CvBERp09MVetaZJpeMmS9Tsra+0dIXWJLLpAq7G4GnrBS CLRzGqDgsJAi83tyIFzlbl5EXMBIktq3Z+/0KQyv1eTL+r1To31iOBAXnBwtCqlXYKLnjQ QJZRBD2GHb1ozHpRMISfemx4QkECvRRxJcUAOywk6FcevLa0VBX8bagkMhAH7rRByv3Rfs IST4W0Z1V/+KqNbnf2/0xfFIr6d59L7qJWz83EybjB7xOgiv4XOddbsTdGeWhA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VKMxh63MJzTcQ; Wed, 17 Apr 2024 14:00:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43HE0eCs048274; Wed, 17 Apr 2024 14:00:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43HE0eqc048271; Wed, 17 Apr 2024 14:00:40 GMT (envelope-from git) Date: Wed, 17 Apr 2024 14:00:40 GMT Message-Id: <202404171400.43HE0eqc048271@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 90cde57af8c6 - stable/14 - tcp: improve consistency List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 90cde57af8c6f14c9a898027646b8e5c6fdd1cfb Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=90cde57af8c6f14c9a898027646b8e5c6fdd1cfb commit 90cde57af8c6f14c9a898027646b8e5c6fdd1cfb Author: Michael Tuexen AuthorDate: 2024-04-06 08:02:06 +0000 Commit: Michael Tuexen CommitDate: 2024-04-17 14:00:09 +0000 tcp: improve consistency No functional change intended. Reported by: Coverity Scan CID: 1523781 Reviewed by: rscheff Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D44645 (cherry picked from commit 3e1c8a35f741a5d114d0ba670b15191355711fe9) --- sys/netinet/tcp_input.c | 2 +- sys/netinet/tcp_timewait.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c index 2a4f3875d1b9..53fa5913311a 100644 --- a/sys/netinet/tcp_input.c +++ b/sys/netinet/tcp_input.c @@ -1941,7 +1941,7 @@ tcp_do_segment(struct tcpcb *tp, struct mbuf *m, struct tcphdr *th, tp->t_flags |= TF_DELACK; } else { tp->t_flags |= TF_ACKNOW; - tcp_output(tp); + (void) tcp_output(tp); } goto check_delack; } diff --git a/sys/netinet/tcp_timewait.c b/sys/netinet/tcp_timewait.c index 1de6a2bfec0e..6fb12ce5380e 100644 --- a/sys/netinet/tcp_timewait.c +++ b/sys/netinet/tcp_timewait.c @@ -124,7 +124,7 @@ tcp_twstart(struct tcpcb *tp) soisdisconnected(inp->inp_socket); if (tp->t_flags & TF_ACKNOW) - tcp_output(tp); + (void) tcp_output(tp); if (V_nolocaltimewait && ( #ifdef INET6