From nobody Wed Apr 17 13:59:36 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VKMwS5x6cz5Gxf2; Wed, 17 Apr 2024 13:59:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VKMwS5B5Gz4sBb; Wed, 17 Apr 2024 13:59:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713362376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ddM1JBLhhLHp+zJbJJzzd5r5m2TNbfVAMpy/BuNETM8=; b=bYt6ai79wIs8x5TDfnCybZK5Um3iEd06hAJSVGpeF+90kqLufFQPk4CRSVruJBu8lzI/f+ flKmaAHOI3JJ4k3hvXE0F5Vg9m4ESMvBkhDmxIebLnQP4KfG1/vWiTkCc54qILF4JU+KFk OtgAt3yLRuaGbB1NBCJnvNI4dPXIYF+/ujgl1m/OHqvW+ldQ/IfQFy97z4gZ3VKO7ulb9u Wp0i94tS+HYJ9C3mHRbl5FKK5l1nrQ6AGzwmlGE5iLgBpDcMgkJ3kg3PX4bHhlUGKV+RL8 z9G2zI30uC30ugof45AL/+2PSez3ffL/oV2P9mrdJAExvyMNivw92PNzKBemRg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713362376; a=rsa-sha256; cv=none; b=tQbfCDtqFxDHI3+y6sKQi7WUkXSvFatnTDe7cm0t37idzSeP6AkqrqRvnfK4cvy29d9DF8 N/y28jW3tA0R2zBoMmJx1lrIRCKwLM474Aq1ATeBaEXIrIsWVokCElzlyUuxK9oSbRzw4l PX+E7+wmwm6QYhj6rmBAz+08SM586s8B1sBc9k+SoYgNO84nH5GPY2Qfzn+v7oiHuKpN5s Yh5g9gAfpcJHD6aQu+AvoQxqY3LlTrDuTuYt8w6TqQ7hA8Yy1bbKDIw/th2h7oTCrc2IsV Leva3Rsfe8XlX+j0GgWB7gspbYinWdD2cKl+VbcHn02YDQXt2HUGg+33Y7U+1A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713362376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ddM1JBLhhLHp+zJbJJzzd5r5m2TNbfVAMpy/BuNETM8=; b=XnovEWNFLNjlGb6c0wLqw2xdOC+xVwna9HnaGyogbpIGEZk5vxEyuUIeYMGG98XKm5osOc H8eqpBOcPxpURN/Pjusu92zGj6gWmCl5LegP6XPhMdM+AvbWxGfhHsNlChoDRlJL+/5tvB X+EaB2sHDtgFb+rm34AfcIYX+8yua468KKubDnYD5SR4uKoLQQmiOyoOoWeNvrhrf4mlFs jo2i5vDI6lslxLGnxkuMPLsSg4WnF+F0gAFNdAtOKBbcyI6qC6u/9Fn3AfiDK14e++fH1b ojIpOV7fgihI1dltuVND+3zul9JUkT2VlVOZo3yXhtxp22iGgc2vp5OgTUY5Bw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VKMwS4kNXzTrF; Wed, 17 Apr 2024 13:59:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43HDxaCB038376; Wed, 17 Apr 2024 13:59:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43HDxa0m038373; Wed, 17 Apr 2024 13:59:36 GMT (envelope-from git) Date: Wed, 17 Apr 2024 13:59:36 GMT Message-Id: <202404171359.43HDxa0m038373@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: c6770e8c99ab - stable/14 - tcp rack: fix memory corruption List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: c6770e8c99abade057bee6ef25f3c2e076ebdce1 Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=c6770e8c99abade057bee6ef25f3c2e076ebdce1 commit c6770e8c99abade057bee6ef25f3c2e076ebdce1 Author: Michael Tuexen AuthorDate: 2024-04-06 07:55:46 +0000 Commit: Michael Tuexen CommitDate: 2024-04-17 13:59:05 +0000 tcp rack: fix memory corruption When in rack_output() jumping to the label out, don't write errno into the log buffer, since the pointer is not initialized. Reported by: Coverity Scan CID: 1523773 Reviewed by: rscheff Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D44647 (cherry picked from commit d902c8f55b8da6902ab45e67ed756cc99f5a9d5a) --- sys/netinet/tcp_stacks/rack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index c3460e48329f..fa3cd2f4f698 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -22151,12 +22151,12 @@ send: mtu = inp->inp_route.ro_nh->nh_mtu; } #endif /* INET */ - -out: if (lgb) { lgb->tlb_errno = error; lgb = NULL; } + +out: /* * In transmit state, time the transmission and arrange for the * retransmit. In persist state, just set snd_max.