From nobody Wed Apr 17 13:54:36 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VKMpj05YGz5GxGK; Wed, 17 Apr 2024 13:54:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VKMph6h79z4r4P; Wed, 17 Apr 2024 13:54:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713362076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VHcLa4B+Uy2ihS76+d3hpR/ZLuF/swTM5MpHzthld4k=; b=LvtjZ6D/7OzSVvpI+UnKuTZ1hsF2mkonGLlH5tuUKS/FFASdOGHR0cKYufYKyYu52w/aXu mph/ouBBrFRWwoRhLk5jLpAWUPv/HWEL1UI2dNpGHIVvhd63mr6i33CRN7E9OQv5e6PsP/ eXgP/P1uh8y33XFK+YIBDJvGyBGYpP9Zt9qqWVjiq24wlezQJB6VJyZXXTDzUyQBftXOp2 GnGknPyNCfOq+Lv/9OHatu4ZaQxjtecld2bHG6oCggZkk0m8zGzfMUgb+FKBvtF+O9ZWGl XDUgXyaqEzVvXK8vjpQkSuX7NVbisWrxeJoYYX/vGs2pq8lmMB2vYzkPoIGTdA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713362076; a=rsa-sha256; cv=none; b=CeNGc73dteobd9uIrE8uoFPlWubvdBD7hF6FK9nGwQXVG8sc8Q33rOa5L9nPRrdNRWZYjV kUwtzIe2DeReZQS8zyQO2lfUlYGbv/Hp1UQop77fHNUI6XLyzGzMTioAAB60PSSV/1TQTr 0V1L3+OP5JLuo0yxBe3g22w5HQC7BlaDYwo5NfWbnnoUT0+AEI1nUW/JVPlov7riOJTyHl 23sHgPrEh248Hb1UDCR98O+Q9+lf+iWQTyY2HJR9zeBHXSLGC6tnEGCjCZypMvxWayV2AK GTt5WnpzUftR0dxYCra9t4QMUXxIEDA2QWmHAxtPYqD5kMCfGM6sTMj2PRNETA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713362076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VHcLa4B+Uy2ihS76+d3hpR/ZLuF/swTM5MpHzthld4k=; b=kcj0XNLabr1IYjtPt4mWjtJs2hKiohpy88FTZlP+x4teqmh66N2EsK34Kkv4nv9RDOS3L9 fxES+I/SvRXvmIRIGba8UqWBq9D2hz/7+EPDPt58IseXAgpkiVDYT4YeGdfMGUwytl4u8+ u4EQB4Ra75XFM/AoWGRpz+vck77G4r1Qrylj61N1PT3y2OtBQuAy3knJy65MtWxIaD0e8G DFxYcnD8q1H3EDT3bvUNqW2gig98ea5TocluWriYX4Xs5apN3LBcghH73W7WSXMwfGQLEw 1cj/p6Qo8ltSLNrfaAyqlLz44h6ptI2p+2tmqG4YD/ukUP71lMQHX/N15qmbbQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VKMph6GTtzTrR; Wed, 17 Apr 2024 13:54:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43HDsa1c037160; Wed, 17 Apr 2024 13:54:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43HDsame037157; Wed, 17 Apr 2024 13:54:36 GMT (envelope-from git) Date: Wed, 17 Apr 2024 13:54:36 GMT Message-Id: <202404171354.43HDsame037157@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: f3e2beb306c6 - stable/14 - tcp: address a warning List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: f3e2beb306c6778ab5d3c5774ad28643d939fad4 Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=f3e2beb306c6778ab5d3c5774ad28643d939fad4 commit f3e2beb306c6778ab5d3c5774ad28643d939fad4 Author: Michael Tuexen AuthorDate: 2024-04-03 22:14:59 +0000 Commit: Michael Tuexen CommitDate: 2024-04-17 13:54:13 +0000 tcp: address a warning t_state is an unsigned variable, so no need for testing that it is non-negative. Reported by: Coverity Scan CID: 1390885 Reviewed by: glebius Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D44619 (cherry picked from commit 6b454da6bbaa3327cf9b7185d198c96ffc1b88f4) --- sys/netinet/tcp_subr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c index c11bfce889e6..0ba35ea13130 100644 --- a/sys/netinet/tcp_subr.c +++ b/sys/netinet/tcp_subr.c @@ -1077,7 +1077,7 @@ tcp_default_fb_init(struct tcpcb *tp, void **ptr) /* We don't use the pointer */ *ptr = NULL; - KASSERT(tp->t_state >= 0 && tp->t_state < TCPS_TIME_WAIT, + KASSERT(tp->t_state < TCPS_TIME_WAIT, ("%s: connection %p in unexpected state %d", __func__, tp, tp->t_state));