From nobody Wed Apr 17 13:51:22 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VKMky2gBPz5GwdF; Wed, 17 Apr 2024 13:51:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VKMky2BxWz4psv; Wed, 17 Apr 2024 13:51:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713361882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5uKRLH0t+04UbOuBspskeTG1TVPhtAqlgmLr9lXPf9g=; b=jBgLEFfCFWlk52+jobdCM2w8yRkmLRucQK401V0cBkEBPfNDOlElKAxbHc1cSI0sbIrokd nD6cc1hhuBFeqnfXmeiKQQx5idn+cndLj/NuHWLfuHUC12xocg1z5SC7vhBKqtVLkv3fG0 MFa9GqEziTisy8bjTYfsTC42bJO5UwCOrrgais/7GPoFuJxKWypdNzpp+q0Z6UMan56mTj bRW4pUDOMXFFluG82YnN1sn6HiAaYwZYoZNO9IMncCoJQ6nCP/UWpghGDD2p8SkHLl/IlE MgJcv1g6kha3xfzkk3IGrms1Yar1EDVK/gHSAhCwltzjCkMVs7T+7uep01Rgag== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713361882; a=rsa-sha256; cv=none; b=C2jn9qzhCkyg+9s/Ntgunil7hfejqoS6t2dyQl0wu+o9pj6th0w/OYmzA77kvAXB6QkxxK 1AJsGfFpqt5jhWyLVqei6kWKCAZK7Qqv/J/acIt1s55aH65FXuFM7v7W8TLonuuvs0Z4wR hWaAfhQ2RVtNMLFlkb5tsaAtWfG83NTNjSktwrCmPfjG08ja+juZD8cxtNcE9KWVIU1Lx2 xRJ47TzPipojI3Z+mm9wcLWmRa6EyO2mFZx8KZbFiahG4UboMOvbnXruEAxhd+ElYCEQRl uyaM4AKXxsTpkSoi0h5f8zkSWk2VdsympWrLu2a2YGrJPw0cHkyv4hK+VQZxOQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713361882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5uKRLH0t+04UbOuBspskeTG1TVPhtAqlgmLr9lXPf9g=; b=Xb6KEd+gxN6yacYujS97e6IhYYGFmGP0FXaS00Z/a4YrVDJxPaIVpQyKGGgiPeV1NTZr22 DlzqZPctkQhe+uEUyeOlL4akti4uRovVcSbA2yiNJvJxi6gS50OgZ3hkO8fkqafu9Gws3F yQYlumCCulkG6WOVwQCxA7yew3eVsNmu41CfB9Im06AT1opKPkFscmLtfmqpaLWBEKGSfi ezKy3M2UW8IdE37YHVvRob+ymf4RjMIsdCiu19es4hLoN7wCtccDxkaR+ziu0956So6/at CQUipblXUpXaIWnxwG5Hn+PamY/l1S1x0TJsBcZWaiSCLbUYQxW7RpSxMXlIQw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VKMky1VfzzTQ2; Wed, 17 Apr 2024 13:51:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43HDpMXD034434; Wed, 17 Apr 2024 13:51:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43HDpMFH034431; Wed, 17 Apr 2024 13:51:22 GMT (envelope-from git) Date: Wed, 17 Apr 2024 13:51:22 GMT Message-Id: <202404171351.43HDpMFH034431@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: fbc8dfd0ed80 - stable/14 - tcp bblog: use correct length List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: fbc8dfd0ed80ba7d12d2683c8afecf6d16ce3388 Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=fbc8dfd0ed80ba7d12d2683c8afecf6d16ce3388 commit fbc8dfd0ed80ba7d12d2683c8afecf6d16ce3388 Author: Michael Tuexen AuthorDate: 2024-03-27 13:31:48 +0000 Commit: Michael Tuexen CommitDate: 2024-04-17 13:51:00 +0000 tcp bblog: use correct length The length of tldl_reason is TCP_LOG_REASON_LEN, not TCP_LOG_ID_LEN. No functional change intended. Reported by: Coverity Scan CID: 1418074 CID: 1418276 Reviewed by: glebius, rscheff Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D44510 (cherry picked from commit ed505f893ab08aa61e2a1046ae54df357a108260) --- sys/netinet/tcp_log_buf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/netinet/tcp_log_buf.c b/sys/netinet/tcp_log_buf.c index 5e168c5066e4..7b937958a4fb 100644 --- a/sys/netinet/tcp_log_buf.c +++ b/sys/netinet/tcp_log_buf.c @@ -2442,7 +2442,7 @@ tcp_log_dump_tp_logbuf(struct tcpcb *tp, char *reason, int how, bool force) if (reason != NULL) strlcpy(entry->tldl_reason, reason, TCP_LOG_REASON_LEN); else - strlcpy(entry->tldl_reason, "UNKNOWN", TCP_LOG_ID_LEN); + strlcpy(entry->tldl_reason, "UNKNOWN", TCP_LOG_REASON_LEN); entry->tldl_ie = inp->inp_inc.inc_ie; if (inp->inp_inc.inc_flags & INC_ISIPV6) entry->tldl_af = AF_INET6; @@ -2532,7 +2532,7 @@ tcp_log_dump_node_logbuf(struct tcp_log_id_node *tln, char *reason, int how) if (reason != NULL) strlcpy(entry->tldl_reason, reason, TCP_LOG_REASON_LEN); else - strlcpy(entry->tldl_reason, "UNKNOWN", TCP_LOG_ID_LEN); + strlcpy(entry->tldl_reason, "UNKNOWN", TCP_LOG_REASON_LEN); entry->tldl_ie = tln->tln_ie; entry->tldl_entries = tln->tln_entries; entry->tldl_count = tln->tln_count;