From nobody Tue Apr 16 20:12:52 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VJwFc53lRz5H0QZ; Tue, 16 Apr 2024 20:12:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VJwFc3HMVz4t4R; Tue, 16 Apr 2024 20:12:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713298372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=blR7E0jGBYPxNDCSyX7HUCy44+dGT1JAMOmpFVxz0sM=; b=ooqJ00g7B3ZVUXoWw6cwFo2mqo/lq+izZRaCh/jpghwXPs+vH2yx1YpdJlLA514CZol3eD nRPXl1Dq65CO91M342kC44wwY0sakMwwo0qwPKiDgjWYBqAkcHuAsoSAOAzDgnCXSSWEvn ZklwOcpXCOC+5nyU+n++qxYdW1FoZktLHdy18760ec+hzctoEf+SlMNBCII8OJkxo9Ea5h x4S9dqykkSHOn16WRbo1PGa9RyYpa88ZiQpJHMWgAfE7uVeObgzj+vfKVidE3Exnx+Fxrh XYcyI6krlXWHpjcEpLIn0WtuQVpYgMJZPz/aWKn534IEehU/7mR0C4nALZb/2g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713298372; a=rsa-sha256; cv=none; b=oD6xX1VQCTLkcpA8Vm9So9/nY9NKgM9aANWD4ymp8K1WD06hSG1HlvrwXc15huAxn8bFOK /ar0KrjXa81YxjuvbixdBGvXja6g8bSC9SERFDhQL7SEmntIiEiWKHeam2z8aNS58fTmCf CSieAG/SX+BEep8pypCuIMfqeHiREcJn3WH1TAJ1TM/SuSd+dwK9/NruNSxvQ1TiW3E7jZ lQ2bV7QwTXDCqmSJSt7EH17GgrP7LRd6pOyvZ2O8ljEImOexANJJP+qRGjXPXLKFNCUimy 747ygb3Jk6MBRmD9gYmsSxatBofGcR6yNKpvpeodwE8IHIinQRJtLOeNqv4atA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713298372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=blR7E0jGBYPxNDCSyX7HUCy44+dGT1JAMOmpFVxz0sM=; b=FWZ0Nf1aADM7P0e/mmdrUA2A+LKJbHlrcP9/4zqvZ17LlvLQvHvHPfoqdMQtCnxBzc/wwF p/XVm+tKjerZG1Nenq0K9tjOJ98epAWyMIPjgU0kiOWCLq1Ig/QG9q3W2QWbR2G5TyQsVF y+kaPuQTBB1rYg6XQAl6pEb/Q30hulYh3z6Km+ZBI6fryFqKzAomMaulAqFNF3H09ZZDAM G3O608LdeSN2p44n8taaNo4XUGG0x4RZQHA/6bHNLw9vOZyWnfOeY3tUmVOmODyCDYxU4/ P8aZF3hZG1fXZ/liaGHBLh7xr/2YmocUq5dIF0FlCbAt7rbEqb29BD1ncg1AmA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VJwFc2Tphzwhf; Tue, 16 Apr 2024 20:12:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43GKCqK3038109; Tue, 16 Apr 2024 20:12:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43GKCqqu038106; Tue, 16 Apr 2024 20:12:52 GMT (envelope-from git) Date: Tue, 16 Apr 2024 20:12:52 GMT Message-Id: <202404162012.43GKCqqu038106@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Warner Losh Subject: git: 19388dd2ad91 - stable/14 - loader: Move drawer.lua over to gfx table. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 19388dd2ad91c087ca65fd3fbad4ca69ffdd0912 Auto-Submitted: auto-generated The branch stable/14 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=19388dd2ad91c087ca65fd3fbad4ca69ffdd0912 commit 19388dd2ad91c087ca65fd3fbad4ca69ffdd0912 Author: Warner Losh AuthorDate: 2024-02-16 03:54:04 +0000 Commit: Warner Losh CommitDate: 2024-04-16 19:54:24 +0000 loader: Move drawer.lua over to gfx table. Drawer.lua is the only bit of lua code in the base that uses any of the functons moved from the loader table to the gfx table. Move the main code to using the gfx dispatch. Add compat code for running on old loaders that creates the newer-style gfx table with the term_* functions we call in it populated. This will even work on the super old versions of the loader that don't have them (we'll still skip using them). Sponsored by: Netflix Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D43908 (cherry picked from commit 0fd98b8a7691b4f11e1bfbcb53a3a7c68d7c1fb7) --- stand/lua/drawer.lua | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/stand/lua/drawer.lua b/stand/lua/drawer.lua index 2dcf7d5de0f8..a009b78164df 100644 --- a/stand/lua/drawer.lua +++ b/stand/lua/drawer.lua @@ -47,6 +47,19 @@ local frame_size local default_shift local shift +-- Make this code compatible with older loader binaries. We moved the term_* +-- functions from loader to the gfx. if we're running on an older loader that +-- has these functions, create aliases for them in gfx. The loader binary might +-- be so old as to not have them, but in that case, we want to copy the nil +-- values. The new loader will provide loader.* versions of all the gfx.* +-- functions for backwards compatibility, so we only define the functions we use +-- here. +if gfx == nil then + gfx = {} + gfx.term_drawrect = loader.term_drawrect + gfx.term_putimage = loader.term_putimage +end + local function menuEntryName(drawing_menu, entry) local name_handler = menu_name_handlers[entry.entry_type] @@ -225,8 +238,8 @@ local function drawframe() x = x + shift.x y = y + shift.y - if core.isFramebufferConsole() and loader.term_drawrect ~= nil then - loader.term_drawrect(x, y, x + w, y + h) + if core.isFramebufferConsole() and gfx.term_drawrect ~= nil then + gfx.term_drawrect(x, y, x + w, y + h) return true end @@ -312,9 +325,9 @@ local function drawbrand() end if core.isFramebufferConsole() and - loader.term_putimage ~= nil and + gfx.term_putimage ~= nil and branddef.image ~= nil then - if loader.term_putimage(branddef.image, 1, 1, 0, 7, 0) + if gfx.term_putimage(branddef.image, 1, 1, 0, 7, 0) then return true end @@ -363,14 +376,14 @@ local function drawlogo() end if core.isFramebufferConsole() and - loader.term_putimage ~= nil and + gfx.term_putimage ~= nil and logodef.image ~= nil then local y1 = 15 if logodef.image_rl ~= nil then y1 = logodef.image_rl end - if loader.term_putimage(logodef.image, x, y, 0, y + y1, 0) + if gfx.term_putimage(logodef.image, x, y, 0, y + y1, 0) then return true end