From nobody Tue Apr 16 20:12:40 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VJwFP2bsjz5H0Py; Tue, 16 Apr 2024 20:12:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VJwFP15QZz4stf; Tue, 16 Apr 2024 20:12:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713298361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zdXXLKRvURGqFP900aK1VMjvkb1maXYEJWlFgKb2MNg=; b=gpBLBUq70zAYD1Fmj05iOBe21vAp7TRPP9B5UYoe2VjZ9SW97qwu7BbIV2GaVaOA3p5ZUC vLLOqFiY+YDAwkMNFUVxrMMAO6g5Z0IZ3GgIIKBY+vVO2a07KJ60n3k0pp95B6i1T/M83y 2HTy2Ju+b0ZZg7N7erdQBc9Kt/NUHFoiq/vgFg5uur1+DA6Tf8tp+iN6N1Qd4JI0uBHhYn VdGWKSTyhw3pnHKm3HbmnkoUMDP8ZhShzoYyn2ds46DXwwYq2fE7Fr5hYFwqueFmyLUvFH 5lU/sCqRwSCW33GJ88BxTjA+ouecoXghyC3nrgAUS31VUcpiaWe6y/DDOHK8nw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713298361; a=rsa-sha256; cv=none; b=kabBR8bf2PtU+HUZ94WPRCftKWtWoTsMJxVSubCnTX+9at9GEj3FaL71CQQXrpQsy3YMD+ JuW79EkB8Bcxr7Q7QLvNoTQck/tPTlAwk6LWcjoVjy6BtHeIm5GkYZiclxpjk2daEd10TL jSk188cVI3mI0K8fEi4dd8w6F9LfcXl0F916nRzrtbA00BsgJGekbZziPqiUwSALlwzwJN tYVAvosb7K7bBkhYbYmTpvs/319srKyp5anH0bTTnjnT11DuDHrTXo5ehxzMQ57p9BQVh/ mgQX1CeMiXpjMUZG+pbvh+J4rWsg1OK7Eg1QF/PXeULSz1aYdps7E5kjigEQJQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713298361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zdXXLKRvURGqFP900aK1VMjvkb1maXYEJWlFgKb2MNg=; b=k2P8oXE4vhE/tEq8vr+Jk8qNLBvS7oZPHQuFLulDD82bvIh7ma2lM3mYfYJyopgVpOtdFe EPmIW/SJSWVtar6nI1iG0L5DqrlPt8uF/5uLVdNxbWoE4tKfF+WMoVDuTpbYBN1mZb+d/K pjfbEI9QnavSRkKjEWgU5BZhMu3RPh0mM0a25vblK+0DEAXOUYGC0/NU7NuEPz8XlYpilD hTf8LOlcKNuSimKOzjYnVHEdMZ+jlnhdJqqAbdPpiW8xk3AHNs5JhctRw2Er/HWhyaVF4f TAXSeWvo+PUzHpJORhNoYkfD3YyDuPqf5r3AZdqzyRYEaZtNfkl1YO8Pve9qZQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VJwFP0j6zzxdc; Tue, 16 Apr 2024 20:12:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43GKCeIf037605; Tue, 16 Apr 2024 20:12:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43GKCeYl037602; Tue, 16 Apr 2024 20:12:40 GMT (envelope-from git) Date: Tue, 16 Apr 2024 20:12:40 GMT Message-Id: <202404162012.43GKCeYl037602@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Warner Losh Subject: git: 4b559231c468 - stable/14 - loader: Make vidc_biosputchar static List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 4b559231c468a0361e3f520ecbbe2d65fb389f45 Auto-Submitted: auto-generated The branch stable/14 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=4b559231c468a0361e3f520ecbbe2d65fb389f45 commit 4b559231c468a0361e3f520ecbbe2d65fb389f45 Author: Warner Losh AuthorDate: 2024-02-14 18:07:10 +0000 Commit: Warner Losh CommitDate: 2024-04-16 19:54:23 +0000 loader: Make vidc_biosputchar static It's currently unused outside of vidconsole.c. Gerald Hicks' fix to the beep code from de37e4a6d2333/1998 introduced the funciton as static. Maxim Sobolev (sobomax) made it non-static since his spinconsole called it in c4c3b35172d67/2009. When sobomax dropped the direct call after making spinconsole console independent in b35172d67/2017, vidc_biosputchar remained a harmless unreferenced global. Make it static once again. Fixes: c7e10205ae0d Sponsored by: Netflix (cherry picked from commit a27c1350e43a863fbe2bf0927ef762a20babe5d5) --- stand/i386/libi386/vidconsole.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stand/i386/libi386/vidconsole.c b/stand/i386/libi386/vidconsole.c index aec41a6373d6..f8a6bf34acad 100644 --- a/stand/i386/libi386/vidconsole.c +++ b/stand/i386/libi386/vidconsole.c @@ -1046,7 +1046,7 @@ vidc_init(int arg) return (0); /* XXX reinit? */ } -void +static void vidc_biosputchar(int c) {