From nobody Sat Apr 06 08:00:21 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VBST252RTz5G543; Sat, 6 Apr 2024 08:00:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VBST14hB9z46DS; Sat, 6 Apr 2024 08:00:21 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712390421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EHxsbyGPn4nIKrtfLz6AQraPVisDe/XA+zSG8us29KU=; b=KkC3+Z3AXOK63rz2XfW9aOODIHnIN0adeckZErsGIYvYvyGngI5vaeAtN4XhxWj9lDDQHf TP11ImaDRY/6zxBqM10oK+7w0ya0eq+ODfXEquY61bv5QjuLwS6QMj4w9v2pqi00XT89RC 1O2MYt8Sw+wR8eTDHkYbz652yU8Vr+HcE3bZV39eKlofxrlRbhKPtB1NoQi/b4LdxGd4Rr S4G1/MGO/gs3+tUjwnjbibS44m9E4IfQvTCHQIWIbINPrmuhd5qdI535aLULBgaxACbygk HjtIkD5DUevZHt5VILUhu8yMpvNO1H+h4FW6sXESrntPqIcK6RsjdFYrrsPS0Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1712390421; a=rsa-sha256; cv=none; b=WwkuE7fE4meD7M7gsccOQoA77uqNaZ7mlkJlyjbtXRhOVPBkGGNJ3xCDPVMKRJu88FhHkF nKQIBxPcTKa/JTqJbQBj7/awjeoPiJ9/ynz6NTlG3WKEmOJwbzFe97pYxQjREQ3eA1QePR iFQKus7ieWTEckOshdWF+OK87ZdOF3LL2g0UifG5GK7EnkItMuWK4xdm+hdLyBlTaBZFYj MCospO2CJdV+pd8yYKBRCxjwYQ/fXTCGCsKLjb7NS4MCacB7XOTGcRAVJmIg5Q2ZY4JsQY sZ96LC277vye8cOWxyNc9qcMAvCoz1Q99Mp1WGRvCthJU1e3KC4MikZQkk7JIw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712390421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=EHxsbyGPn4nIKrtfLz6AQraPVisDe/XA+zSG8us29KU=; b=bkRt/dVfCJxQnzZHTExHibsPxaNskimlZbjoxGgRDZQS8OcZpw7QWpisT9BpbUHk9VPmSZ JDTTMBLopIVwT5dmAqCjqofBUadIkcyphzUwTQF599fwLG9z+D95V6jQF9VHyn+bfH5ZnS 10A7/wTEz8HZq6bGQIMBZL44fXnmXucSaRcLUuwPQIddN1z4y+cQsM9KBBf2ZkKmAmpgRy DCcvN2+Sjo4IgDPA8cfFuYIcFnvIiN2jtlLVBo52IziEAGnkDd+LqV4QgRElrHcgNriTpT d/Z35WgboZagzM6R7122KGQDc8M4NLjjbjfw3eP9ARtcpB/D7TxwzpHeXSkEHQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VBST14HCPzbyP; Sat, 6 Apr 2024 08:00:21 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43680LUZ087137; Sat, 6 Apr 2024 08:00:21 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43680LmO087134; Sat, 6 Apr 2024 08:00:21 GMT (envelope-from git) Date: Sat, 6 Apr 2024 08:00:21 GMT Message-Id: <202404060800.43680LmO087134@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: d902c8f55b8d - main - tcp rack: fix memory corruption List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d902c8f55b8da6902ab45e67ed756cc99f5a9d5a Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=d902c8f55b8da6902ab45e67ed756cc99f5a9d5a commit d902c8f55b8da6902ab45e67ed756cc99f5a9d5a Author: Michael Tuexen AuthorDate: 2024-04-06 07:55:46 +0000 Commit: Michael Tuexen CommitDate: 2024-04-06 07:55:46 +0000 tcp rack: fix memory corruption When in rack_output() jumping to the label out, don't write errno into the log buffer, since the pointer is not initialized. Reported by: Coverity Scan CID: 1523773 Reviewed by: rscheff MFC after: 3 days Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D44647 --- sys/netinet/tcp_stacks/rack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index ea52eb0a92cd..5b76480ee55d 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -23718,12 +23718,12 @@ send: mtu = inp->inp_route.ro_nh->nh_mtu; } #endif /* INET */ - -out: if (lgb) { lgb->tlb_errno = error; lgb = NULL; } + +out: /* * In transmit state, time the transmission and arrange for the * retransmit. In persist state, just set snd_max.