Re: git: 7494fb6b7d80 - main - EC2: Flavour existing AMIs as "base"

Reply: Colin Percival : "Re: git: 7494fb6b7d80 - main - EC2: Flavour existing AMIs as "base""
In reply to: Colin Percival : "git: 7494fb6b7d80 - main - EC2: Flavour existing AMIs as "base""
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Alexey Dokuchaev <danfe_at_freebsd.org>
Date: Fri, 29 Sep 2023 05:52:06 UTC

On Thu, Sep 28, 2023 at 10:18:52PM +0000, Colin Percival wrote:
> commit 7494fb6b7d809257d4eb9eff06ce226143f27add
> 
>   EC2: Flavour existing AMIs as "base"

I think it should be "flavor" since FreeBSD prefers American spelling.

> @@ -31,6 +31,7 @@ BASIC-CI_DESC=		Image for CI
>  EC2_FORMAT=	raw
>  EC2_FSLIST=	ufs zfs
>  EC2_DESC=	Amazon EC2 image
> +EC2_FLAVOURS=	BASE

Since other nearby values (format, filesystems) are lowercase, perhaps
it makes sense to say EC2_FLAVORS=base and :tu it when needed in the
code to keep declarations consistent and tidy.

>  GCE_FORMAT=	raw
>  GCE_FSLIST=	ufs zfs

./danfe