From nobody Tue Sep 26 17:32:19 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rw6J93zqKz4vRGB; Tue, 26 Sep 2023 17:32:25 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rw6J93T9Tz3CSt; Tue, 26 Sep 2023 17:32:25 +0000 (UTC) (envelope-from rpokala@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695749545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=smxkvWDf2085u1m1VJ3uB0LN6Y1Xymi33lQTAInKgf8=; b=NRHlww3AxpDVZaUcxzcHCAv4phNSs3krqN3jXapmu8ripxv3hjExyH14nLM0D50j5frlpJ NelGw3sdJ63Ktz3rQ0Ih76mRNer8CqTb2q4S+OCqN9nsp3RcwAas9E+DEkIa01uBx2BrrZ Jm9h3R2ATeRXgcDnk2DpuwTmVEopXNoUGdZmtsGA3YxUTiQSiAXC5IgIJKSerOxMLfLP1w 9G8NfK3lVATnLrQj9LR3RARSu5z4gSbFubw/rMETKi8O62DWc24975SgArMCQ8960PXEj8 t77ByVImw03zIF1DjgDGTf42Jv4552wHSg4fc0xI6PGmjMozjDhfr/hkobvCGg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695749545; a=rsa-sha256; cv=none; b=aM7SfKWEzYVWeICFe/y21Z+Io3S0L1OcKypAWcmVMGdlF2A8w8KLcd3TbwugXok9+k0E4G bYCYZEWL46TKNJQ4/hDUxvG/Vqqez/hHWL4tRXDXZAyZosNWAYGFlQq8Xl7kXYtyN19vh3 SMkNrwXlf+aCKO9x99U05H1gDiqajk+biS+ZraETWPblODlfXGO883281rxHriev0jIHV1 OmdBuHd23fN8ZIGzfTkyeoUuOSrhsTu7f5vBD5dlgRbBi2pVsbpdaZ/OGZKaweomUBjO8P 7M6i11GhDsJvUFWZgHJnLqaxLGybqPf84KdeDgeDY0g2xT52dTHpSHgTr8aspA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695749545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=smxkvWDf2085u1m1VJ3uB0LN6Y1Xymi33lQTAInKgf8=; b=tYw5bKLs+7W02OQbubeRfcoqGgBf/DToDFwcJpnG6tyQKrWyMK0GXi15ObQXWWC6TXqyTn BAAvszYyuMlOtjj1jSm7h0EoASbMKTxmmGHK0UodzwS60e9z5DSidSX9SLi+21hB2S5z78 ZZi9mbj7o8RBBW3nj2Z/hoqSrse7BQ+eKtJ0EPHFpZ1sIYpagZrUu/XcBMmewIYSiNcoN1 Hike2vIYDc3PJMIJvr+rU+UJrMMP56HHjdmam2tn6ZZkhYuSbXfGNAiLkChBQbbtvb7iub 5ZZTf4J1JQ6bqOiX492CdAmgia+LCvPZU16LpCIvH96y8dNfMvTe4IFTpm4SGQ== Received: from [192.168.1.12] (c-98-248-120-44.hsd1.ca.comcast.net [98.248.120.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Rw6J85SG4zn8l; Tue, 26 Sep 2023 17:32:24 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.77.23091703 Date: Tue, 26 Sep 2023 10:32:19 -0700 Subject: Re: e6dc6a27230f - main - sys/conf/newvers.sh: whack sccs tag From: Ravi Pokala To: Warner Losh , Mateusz Guzik CC: src-committers , "" , "" Message-ID: <52507A54-AAB7-43E9-BD06-41B9C78CF296@panasas.com> Thread-Topic: e6dc6a27230f - main - sys/conf/newvers.sh: whack sccs tag References: <202309261437.38QEbWmw002059@gitrepo.freebsd.org> In-Reply-To: List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-version: 1.0 Content-type: multipart/alternative; boundary="B_3778569145_1222604024" > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3778569145_1222604024 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: quoted-printable In that case, an updated comment seems appropriate, so it=E2=80=99s not removed a= gain. =20 -Ravi (rpokala@) =20 =20 From: on behalf of Warner Losh Date: Tuesday, September 26, 2023 at 07:51 To: Mateusz Guzik Cc: src-committers , "" , "" Subject: Re: git: e6dc6a27230f - main - sys/conf/newvers.sh: whack sccs tag =20 Can you put this back? It is still useful. I have automated scripts that lo= ok for this pattern to find the version of a core dump. There are no other w= ays that are as reliable to find this data. Some other heuristics exist, but= my experience with snagging data from maybe a thousand core dumps from $WOR= K's network found issues in all the alternatives. It's why I didn't whack it= already. Even though the text says SCCS which is prehistory for this projec= t, it's still in use today. =20 Warner =20 On Tue, Sep 26, 2023, 8:37 AM Mateusz Guzik wrote: The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=3De6dc6a27230f836a131118326731b7= c5fd417723 commit e6dc6a27230f836a131118326731b7c5fd417723 Author: Mateusz Guzik AuthorDate: 2023-09-26 14:36:51 +0000 Commit: Mateusz Guzik CommitDate: 2023-09-26 14:36:51 +0000 sys/conf/newvers.sh: whack sccs tag In the same spirit as removing cvs $FreeBSD$ tags. Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/conf/newvers.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh index 73fd6857d307..18b1817ca287 100644 --- a/sys/conf/newvers.sh +++ b/sys/conf/newvers.sh @@ -311,11 +311,9 @@ fi vers_content_new=3D$(cat << EOF $COPYRIGHT -#define SCCSSTR "@(#)${VERINFO}" #define VERSTR "${VERSTR}" #define RELSTR "${RELEASE}" -char sccs[sizeof(SCCSSTR) > 128 ? sizeof(SCCSSTR) : 128] =3D SCCSSTR; char version[sizeof(VERSTR) > 256 ? sizeof(VERSTR) : 256] =3D VERSTR; char compiler_version[] =3D "${compiler_v}"; char ostype[] =3D "${TYPE}"; --B_3778569145_1222604024 Content-type: text/html; charset="UTF-8" Content-transfer-encoding: quoted-printable

In that case, an updated comment seems appropri= ate, so it=E2=80=99s not removed again.

 

=

-Ravi (= rpokala@)

 

 

From: <owner-src-committers@freebsd.org> on behalf of Warner Losh <imp@b= sdimp.com>
Date: Tuesday, September 26, 2023 at 07:51
To:= Mateusz Guzik <mjg@freebsd.org>
Cc: src-committers <= src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>= ;" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-m= ain@freebsd.org>" <dev-commits-src-main@freebsd.org>
Sub= ject: Re: git: e6dc6a27230f - main - sys/conf/newvers.sh: whack sccs tag=

 

Can you put this back? It is still useful. I have automated scripts that lo= ok for this pattern to find the version of a core dump. There are no other w= ays that are as reliable to find this data. Some other heuristics exist, but= my experience with snagging data from maybe a thousand core dumps from $WOR= K's network found issues in all the alternatives. It's why I didn't whack it= already. Even though the text says SCCS which is prehistory for this projec= t, it's still in use today.

 

Warner

 

On Tue, Sep 26, 2023, 8:37 AM Mateusz Guzik <mjg@freebsd.org> wrote:

The branch main has been updated by mjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=3De6dc6a27230f836a= 131118326731b7c5fd417723

commit e6dc6a27230f836a131118326731b7c5f= d417723
Author:     Mateusz Guzik <mjg@FreeBSD.org><= br>AuthorDate: 2023-09-26 14:36:51 +0000
Commit:     Mateu= sz Guzik <mjg@FreeBSD.org>
CommitDate: 2023-09-26 14:36:51 +0000
    sys/conf/newvers.sh: whack sccs tag

    = In the same spirit as removing cvs $FreeBSD$ tags.

    Spon= sored by:   Rubicon Communications, LLC ("Netgate")
-= --
 sys/conf/newvers.sh | 2 --
 1 file changed, 2 deletions(= -)

diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh
index 73= fd6857d307..18b1817ca287 100644
--- a/sys/conf/newvers.sh
+++ b/sys/co= nf/newvers.sh
@@ -311,11 +311,9 @@ fi

 vers_content_new=3D$(cat= << EOF
 $COPYRIGHT
-#define SCCSSTR "@(#)${VERINFO}&q= uot;
 #define VERSTR "${VERSTR}"
 #define RELSTR &= quot;${RELEASE}"

-char sccs[sizeof(SCCSSTR) > 128 ? sizeof(SC= CSSTR) : 128] =3D SCCSSTR;
 char version[sizeof(VERSTR) > 256 ? siz= eof(VERSTR) : 256] =3D VERSTR;
 char compiler_version[] =3D "${comp= iler_v}";
 char ostype[] =3D "${TYPE}";

<= /blockquote>
--B_3778569145_1222604024--