From nobody Tue Sep 26 14:51:45 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rw2l56Gr7z4vFqY for ; Tue, 26 Sep 2023 14:52:01 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rw2l45wGVz4Qb9 for ; Tue, 26 Sep 2023 14:52:00 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-405497850dbso70755035e9.0 for ; Tue, 26 Sep 2023 07:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1695739917; x=1696344717; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wt7O+tzlCZ0EYMnnDMNW2TdkHWuI4aLkIDqOZfvb8eg=; b=fVMQLyAfanzDsPmcyiZRXcLL6+s7rUiX2jRJhehlfWwGDEaHBrEbDg8Kr86sgQ4nUW LvKBG8JqmQ3vPh6neAnREOzQWrqT7x1WGy7Ht+RuvLXmrKE7uOJvKrvrvPfiqhdEfbnP GsFSLssJ6+o6+7xmhBKeTcN1Xi/EG2HowQIyMOZ8DUH3+lFwcOk6wxerGFJqBiazhbdc mNbnh1u6nkrOznb7cirbP1aGeWqhYD2Ku0o9J9dIXOp1fUbQxUO347tKc04+6fImGYj5 MRQjimNoGaO1f6IFQLNifkKTH0mOeUZKxgr8WFCIa+h8bcxvzlVF7UFiwarHWs4LaLgZ V8nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695739917; x=1696344717; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wt7O+tzlCZ0EYMnnDMNW2TdkHWuI4aLkIDqOZfvb8eg=; b=RenJjN+VTH5z8x2A7bNYySLUeZQOFrwLDzBpQhQD9X4OZ6ndih+txEts/p8dBZPzGe PmtFpEEPOv6sOIfT9wGuVOMNF+QtqA4MTZ/PglPiy8KGbOVun3O4/xWILHsTV1V7fVOQ cXOaba684jNTG4iToLK+1q2Qqf+5+C+q51wwdeTxUFh6PXuBKMHFb8hydPO5ECSgzy6N Hq4QctoYKwuxXYVytkbv617daO3uAIUPqzEdQp7a2CEyWjDL/5Asoo+v72OqPdco1rOV boykGGNREPNjT7Mnco15QQeYK6CbvEbSFp9jWEHZNLyXowyldxMVxI0RkKJ2giVTEB7f b5Mw== X-Gm-Message-State: AOJu0YzPKOjfAP8WjW8rABDA6tdbfKry0EdyB2uLOpxIzQ/7ETb+DwBo 3b5GJ19lKpEb1SsDafZiqtYPIVphqichlWH1JzE5SQ== X-Google-Smtp-Source: AGHT+IF8dbwLCVA8uMx4TsxZ2pbTI5TVCYG5GI/1iQ8esm4Vtyq/eWHsJjlnaX+aH58poQsFNueqw6seRAQOPIs3FfU= X-Received: by 2002:adf:b199:0:b0:323:2b6a:59c5 with SMTP id q25-20020adfb199000000b003232b6a59c5mr4815053wra.67.1695739917110; Tue, 26 Sep 2023 07:51:57 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202309261437.38QEbWmw002059@gitrepo.freebsd.org> In-Reply-To: <202309261437.38QEbWmw002059@gitrepo.freebsd.org> From: Warner Losh Date: Tue, 26 Sep 2023 08:51:45 -0600 Message-ID: Subject: Re: git: e6dc6a27230f - main - sys/conf/newvers.sh: whack sccs tag To: Mateusz Guzik Cc: src-committers , "" , "" Content-Type: multipart/alternative; boundary="000000000000642dfa06064437b9" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4Rw2l45wGVz4Qb9 --000000000000642dfa06064437b9 Content-Type: text/plain; charset="UTF-8" Can you put this back? It is still useful. I have automated scripts that look for this pattern to find the version of a core dump. There are no other ways that are as reliable to find this data. Some other heuristics exist, but my experience with snagging data from maybe a thousand core dumps from $WORK's network found issues in all the alternatives. It's why I didn't whack it already. Even though the text says SCCS which is prehistory for this project, it's still in use today. Warner On Tue, Sep 26, 2023, 8:37 AM Mateusz Guzik wrote: > The branch main has been updated by mjg: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=e6dc6a27230f836a131118326731b7c5fd417723 > > commit e6dc6a27230f836a131118326731b7c5fd417723 > Author: Mateusz Guzik > AuthorDate: 2023-09-26 14:36:51 +0000 > Commit: Mateusz Guzik > CommitDate: 2023-09-26 14:36:51 +0000 > > sys/conf/newvers.sh: whack sccs tag > > In the same spirit as removing cvs $FreeBSD$ tags. > > Sponsored by: Rubicon Communications, LLC ("Netgate") > --- > sys/conf/newvers.sh | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh > index 73fd6857d307..18b1817ca287 100644 > --- a/sys/conf/newvers.sh > +++ b/sys/conf/newvers.sh > @@ -311,11 +311,9 @@ fi > > vers_content_new=$(cat << EOF > $COPYRIGHT > -#define SCCSSTR "@(#)${VERINFO}" > #define VERSTR "${VERSTR}" > #define RELSTR "${RELEASE}" > > -char sccs[sizeof(SCCSSTR) > 128 ? sizeof(SCCSSTR) : 128] = SCCSSTR; > char version[sizeof(VERSTR) > 256 ? sizeof(VERSTR) : 256] = VERSTR; > char compiler_version[] = "${compiler_v}"; > char ostype[] = "${TYPE}"; > --000000000000642dfa06064437b9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Can you put this back? It is still useful. I have automat= ed scripts that look for this pattern to find the version of a core dump. T= here are no other ways that are as reliable to find this data. Some other h= euristics exist, but my experience with snagging data from maybe a thousand= core dumps from $WORK's network found issues in all the alternatives. = It's why I didn't whack it already. Even though the text says SCCS = which is prehistory for this project, it's still in use today.

Warner

On Tue, Sep 26, 2023, 8:3= 7 AM Mateusz Guzik <mjg@freebsd.org> wrote:
The branch main has b= een updated by mjg:

URL: ht= tps://cgit.FreeBSD.org/src/commit/?id=3De6dc6a27230f836a131118326731b7c5fd4= 17723

commit e6dc6a27230f836a131118326731b7c5fd417723
Author:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik <mjg@FreeBSD.org>
AuthorDate: 2023-09-26 14:36:51 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik <mjg@FreeBSD.org>
CommitDate: 2023-09-26 14:36:51 +0000

=C2=A0 =C2=A0 sys/conf/newvers.sh: whack sccs tag

=C2=A0 =C2=A0 In the same spirit as removing cvs $FreeBSD$ tags.

=C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0Rubicon Communications, LLC ("= Netgate")
---
=C2=A0sys/conf/newvers.sh | 2 --
=C2=A01 file changed, 2 deletions(-)

diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh
index 73fd6857d307..18b1817ca287 100644
--- a/sys/conf/newvers.sh
+++ b/sys/conf/newvers.sh
@@ -311,11 +311,9 @@ fi

=C2=A0vers_content_new=3D$(cat << EOF
=C2=A0$COPYRIGHT
-#define SCCSSTR "@(#)${VERINFO}"
=C2=A0#define VERSTR "${VERSTR}"
=C2=A0#define RELSTR "${RELEASE}"

-char sccs[sizeof(SCCSSTR) > 128 ? sizeof(SCCSSTR) : 128] =3D SCCSSTR; =C2=A0char version[sizeof(VERSTR) > 256 ? sizeof(VERSTR) : 256] =3D VERS= TR;
=C2=A0char compiler_version[] =3D "${compiler_v}";
=C2=A0char ostype[] =3D "${TYPE}";
--000000000000642dfa06064437b9--